From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=195.135.221.5; helo=smtp.nue.novell.com; envelope-from=glin@suse.com; receiver=edk2-devel@lists.01.org Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC441203B99A9 for ; Sun, 24 Jun 2018 23:18:36 -0700 (PDT) Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Mon, 25 Jun 2018 08:18:34 +0200 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.202]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Mon, 25 Jun 2018 07:18:08 +0100 Date: Mon, 25 Jun 2018 14:18:03 +0800 From: Gary Lin To: "Zhu, Yonghong" Cc: "edk2-devel@lists.01.org" , "Gao, Liming" Message-ID: <20180625061803.fvc2jjskyz3t6rky@GaryWorkstation> References: <20180622082122.bj6rpjgfcbsbeohf@GaryWorkstation> <20180622084537.5c262wd2fnafmpil@GaryWorkstation> <20180622091323.h5tcdy32wx5yjmmv@GaryWorkstation> <20180622094819.bzzqyvfoqrhdazxo@GaryWorkstation> <20180625033450.kmwulo4mjtwasttk@GaryWorkstation> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170912 (1.9.0) Subject: Re: [PATCH v3 05/20] BaseTools: Use the python3-range functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 06:18:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 25, 2018 at 05:58:42AM +0000, Zhu, Yonghong wrote: > You're correct, it is Patch 13 cause the 'long' type issue. > Thanks for the confirmation! I'll revert the patch in the next version. Gary Lin > Best Regards, > Zhu Yonghong > > > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Monday, June 25, 2018 11:35 AM > To: Zhu, Yonghong > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range functions > > On Fri, Jun 22, 2018 at 10:22:10AM +0000, Zhu, Yonghong wrote: > > No. I tried to only patch 1 to 15, it still report this failure. > > > One possible patch may be patch 13, because the error is about long type, and patch 13 converts 'long' to 'int'. > > Since I couldn't reproduce the error, would you mind to bisect through patch 1~13 if reverting patch 13 doesn't work? > > Thanks, > > Gary Lin > > > > Best Regards, > > Zhu Yonghong > > > > > > -----Original Message----- > > From: Gary Lin [mailto:glin@suse.com] > > Sent: Friday, June 22, 2018 5:48 PM > > To: Zhu, Yonghong > > Cc: edk2-devel@lists.01.org; Gao, Liming > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the python3-range > > functions > > > > On Fri, Jun 22, 2018 at 09:24:44AM +0000, Zhu, Yonghong wrote: > > > Any comment on which patch may cause this issue ? I revert all the 20 patches, OVMF could build PASS. > > > > > I wonder if reverting patch 16~20 helps or not. Changing to absolute import may be not as safe as I thought. > > > > Thanks, > > > > Gary Lin > > > > > Best Regards, > > > Zhu Yonghong > > > > > > > > > -----Original Message----- > > > From: Zhu, Yonghong > > > Sent: Friday, June 22, 2018 5:22 PM > > > To: 'Gary Lin' > > > Cc: edk2-devel@lists.01.org; Gao, Liming ; > > > Zhu, Yonghong > > > Subject: RE: [edk2] [PATCH v3 05/20] BaseTools: Use the > > > python3-range functions > > > > > > Yes, after modify build.bat and GenFds.bat, I can avoid the previous error, but a new error: > > > > > > build.py... > > > d:\git\edk2_new\OvmfPkg\OvmfPkg.fdf.inc(83): error 3000: Invalid syntax/format > > > near line 83, column 0: SET > > > gUefiOvmfPkgTokenSpaceGuid.Pcd OvmfFlashNvStorageEventLogBase = > > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorag > > > eVariableBase + > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > > > > > > Best Regards, > > > Zhu Yonghong > > > > > > > > > -----Original Message----- > > > From: Gary Lin [mailto:glin@suse.com] > > > Sent: Friday, June 22, 2018 5:13 PM > > > To: Zhu, Yonghong > > > Cc: edk2-devel@lists.01.org; Gao, Liming > > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the > > > python3-range functions > > > > > > On Fri, Jun 22, 2018 at 08:53:04AM +0000, Zhu, Yonghong wrote: > > > > Hi Gary, > > > > > > > > My test env is Windows. I applied Patch 16, and seems this patch only for Linux. > > > > > > > Ah, right. The patch is Linux only, and sadly I only have Linux. > > > I guess the similar change may work for windows. > > > > > > Could you try to modify build.bat and GenFds.bat in BaseTools\BinWrappers\WindowsLike\ as the following? > > > > > > @setlocal > > > @set ToolName=%~n0% > > > @set PYTHONPATH=%PYTHONPATH%;%BASE_TOOLS_PATH%\Source\Python > > > @%PYTHON_HOME%\python.exe -m %ToolName%.%ToolName% %* > > > > > > I'm not sure whether it should be '-m' or '/m' though. The goal is treat build and GenFds as modules to avoid the error you saw. > > > > > > Thanks, > > > > > > Gary Lin > > > > > > > Best Regards, > > > > Zhu Yonghong > > > > > > > > > > > > -----Original Message----- > > > > From: Gary Lin [mailto:glin@suse.com] > > > > Sent: Friday, June 22, 2018 4:46 PM > > > > To: Zhu, Yonghong > > > > Cc: edk2-devel@lists.01.org; Gao, Liming > > > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the > > > > python3-range functions > > > > > > > > On Fri, Jun 22, 2018 at 04:21:23PM +0800, Gary Lin wrote: > > > > > On Fri, Jun 22, 2018 at 05:29:21AM +0000, Zhu, Yonghong wrote: > > > > > > Hi Gary, > > > > > > > > > > > > Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace. You can use the BaseTools\Scripts\PatchCheck.py to check its format. > > > > > > > > > > > Ok, will fix them in the next version. > > > > > > > > > > > I try to build OVMF platform, it directly report error: > > > > > > from .BuildReport import BuildReport > > > > > > ValueError: Attempted relative import in non-package > > > > > > > > > > > I didn't see this in my system. Will investigate what's wrong. > > > > > > > > > Hi Yonghong, > > > > > > > > The error showed when I reverted patch 16. Would you mind to check whether patch 16 was applied or not? > > > > > > > > Thanks, > > > > > > > > Gary Lin > > > > > > > > > Thanks, > > > > > > > > > > Gary Lin > > > > > > > > > > > Best Regards, > > > > > > Zhu Yonghong > > > > > > > > > > > > -----Original Message----- > > > > > > From: Gary Lin [mailto:glin@suse.com] > > > > > > Sent: Friday, June 22, 2018 10:04 AM > > > > > > To: Zhu, Yonghong > > > > > > Cc: edk2-devel@lists.01.org; Gao, Liming > > > > > > > > > > > > Subject: Re: [edk2] [PATCH v3 05/20] BaseTools: Use the > > > > > > python3-range functions > > > > > > > > > > > > On Thu, Jun 21, 2018 at 12:40:29PM +0000, Zhu, Yonghong wrote: > > > > > > > Hi Gary, > > > > > > > > > > > > > > Python 2.7 doesn't have the module builtins, if we apply this patch now, it will cause build failure on Python 2.7. > > > > > > > > > > > > > Urhh, I thought it's a "built-in" module but it's actually > > > > > > from python-future. > > > > > > > > > > > > I'll revert this patch and post a new patchset. > > > > > > BTW, would you might review the first patch? It's just a typo > > > > > > fix and I just caught it while running the futurize script, so > > > > > > the patch is actually independent from this patch series. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Gary Lin > > > > > > > > > > > > > Best Regards, > > > > > > > Zhu Yonghong > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Gary Lin [mailto:glin@suse.com] > > > > > > > Sent: Thursday, June 21, 2018 12:44 PM > > > > > > > To: edk2-devel@lists.01.org > > > > > > > Cc: Zhu, Yonghong ; Gao, Liming > > > > > > > > > > > > > > Subject: [PATCH v3 05/20] BaseTools: Use the python3-range > > > > > > > functions > > > > > > > > > > > > > > Replace xrange() and range() with the newer range() function Based on "futurize -f libfuturize.fixes.fix_xrange_with_import" > > > > > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > Cc: Yonghong Zhu > > > > > > > Cc: Liming Gao > > > > > > > Signed-off-by: Gary Lin > > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >