From: Sami Mujawar <sami.mujawar@arm.com>
To: edk2-devel@lists.01.org
Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>,
Daniil Egranov <Daniil.Egranov@arm.com>,
Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
leif.lindholm@linaro.org, evan.lloyd@arm.com,
Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
nd@arm.com
Subject: [PATCH edk2-platforms v1 3/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix variable declaration
Date: Wed, 27 Jun 2018 17:48:45 +0100 [thread overview]
Message-ID: <20180627164848.24124-4-sami.mujawar@arm.com> (raw)
In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com>
Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
Notes:
v1:
- Fix ecc tool reported issues [SAMI]
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index a67a09cb6c197a14b376d4a8ef9a90e438efb2bb..35104612e691613f7bbc43511bb921ff111e1fe9 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -303,9 +303,10 @@ GetStandardNameSpaceObject (
IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
)
{
- EFI_STATUS Status = EFI_SUCCESS;
+ EFI_STATUS Status;
EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo;
+ Status = EFI_SUCCESS;
if ((This == NULL) || (CmObject == NULL)) {
ASSERT (This != NULL);
ASSERT (CmObject != NULL);
@@ -353,9 +354,10 @@ GetArmNameSpaceObject (
IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
)
{
- EFI_STATUS Status = EFI_SUCCESS;
+ EFI_STATUS Status;
EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo;
+ Status = EFI_SUCCESS;
if ((This == NULL) || (CmObject == NULL)) {
ASSERT (This != NULL);
ASSERT (CmObject != NULL);
@@ -437,8 +439,9 @@ GetOemNameSpaceObject (
IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject
)
{
- EFI_STATUS Status = EFI_SUCCESS;
+ EFI_STATUS Status;
+ Status = EFI_SUCCESS;
if ((This == NULL) || (CmObject == NULL)) {
ASSERT (This != NULL);
ASSERT (CmObject != NULL);
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2018-06-27 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 16:48 [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool Sami Mujawar
2018-06-27 16:48 ` [PATCH edk2-platforms v1 1/6][platforms/devel-dynamictables] Platform/ARM: FVP: Add module info to file header Sami Mujawar
2018-06-27 16:48 ` [PATCH edk2-platforms v1 2/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix function documentation Sami Mujawar
2018-06-27 16:48 ` Sami Mujawar [this message]
2018-06-27 16:48 ` [PATCH edk2-platforms v1 4/6][platforms/devel-dynamictables] Platform/ARM: Juno: Add module info to file header Sami Mujawar
2018-06-27 16:48 ` [PATCH edk2-platforms v1 5/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix function documentation Sami Mujawar
2018-06-27 16:48 ` [PATCH edk2-platforms v1 6/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix variable declaration Sami Mujawar
2018-06-27 16:58 ` [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool Evan Lloyd
2018-06-28 15:46 ` Leif Lindholm
2018-06-29 12:10 ` Evan Lloyd
2018-07-02 14:01 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627164848.24124-4-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox