Re: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Jun 27, 2018 at 04:58:04PM +0000, Evan Lloyd wrote:
> 
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Should I take this one (and the one on the other accompanying set) as
Reviewed-by?

/
    Leif

> > -----Original Message-----
> > From: Sami Mujawar <sami.mujawar@arm.com>
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> > <Daniil.Egranov@arm.com>; Thomas Abraham
> > <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd
> > <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> > Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> > <nd@arm.com>
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> > issues reported by ecc tool
> > 
> > This patch series fixes the issues reported by the ecc tool.
> > 
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> > 
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> > 
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc                            |  3 +-
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c          | 86 +++++++++---------
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf     |  1 +
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf           |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc                        |  3 +-
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c      | 93 ++++++++++----------
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf       |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> > 
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> > 
>