From: Leif Lindholm <leif.lindholm@linaro.org>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: edk2-devel@lists.01.org, evan.lloyd@arm.com,
Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com,
nd@arm.com
Subject: Re: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool
Date: Mon, 2 Jul 2018 15:00:40 +0100 [thread overview]
Message-ID: <20180702140040.zimxibawvzc5vuno@bivouac.eciton.net> (raw)
In-Reply-To: <20180627164746.36188-1-sami.mujawar@arm.com>
On Wed, Jun 27, 2018 at 05:47:41PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
>
> The changes can be seen at https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1
For series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 726ccd02b1..d4b26ac2bb.
/
Leif
> Sami Mujawar (5):
> DynamicTablesPkg: Add module info to file header
> DynamicTablesPkg: Fix function documentation
> DynamicTablesPkg: Fix variable naming issue
> DynamicTablesPkg: Fix macro to prevent side effect
> DynamicTablesPkg: Fix variable declaration
>
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c | 6 +-
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c | 6 +-
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h | 6 +-
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c | 2 +-
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 1 +
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c | 6 +-
> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c | 59 +++---
> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 1 +
> DynamicTablesPkg/DynamicTablesPkg.dec | 5 +-
> DynamicTablesPkg/Include/AcpiTableGenerator.h | 30 +--
> DynamicTablesPkg/Include/ConfigurationManagerHelper.h | 2 +-
> DynamicTablesPkg/Include/ConfigurationManagerObject.h | 12 +-
> DynamicTablesPkg/Include/DeviceTreeTableGenerator.h | 24 +--
> DynamicTablesPkg/Include/Library/TableHelperLib.h | 6 +-
> DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h | 4 +-
> DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 6 +-
> DynamicTablesPkg/Include/SmbiosTableGenerator.h | 24 +--
> DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +-
> DynamicTablesPkg/Include/TableGenerator.h | 32 ++--
> DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 16 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 20 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 38 ++--
> DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 194 ++++++++++----------
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 32 ++--
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c | 16 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c | 13 +-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf | 1 +
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 12 +-
> DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 +-
> DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf | 1 +
> 37 files changed, 316 insertions(+), 272 deletions(-)
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
prev parent reply other threads:[~2018-07-02 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 16:47 [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool Sami Mujawar
2018-06-27 16:47 ` [staging/dynamictables PATCH v1 1/5] DynamicTablesPkg: Add module info to file header Sami Mujawar
2018-06-27 16:47 ` [staging/dynamictables PATCH v1 2/5] DynamicTablesPkg: Fix function documentation Sami Mujawar
2018-06-27 16:47 ` [staging/dynamictables PATCH v1 3/5] DynamicTablesPkg: Fix variable naming issue Sami Mujawar
2018-06-27 16:47 ` [staging/dynamictables PATCH v1 4/5] DynamicTablesPkg: Fix macro to prevent side effect Sami Mujawar
2018-06-28 16:50 ` Leif Lindholm
2018-06-28 17:10 ` Sami Mujawar
2018-06-29 9:41 ` Leif Lindholm
2018-06-27 16:47 ` [staging/dynamictables PATCH v1 5/5] DynamicTablesPkg: Fix variable declaration Sami Mujawar
2018-06-27 16:57 ` [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool Evan Lloyd
2018-07-02 14:00 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702140040.zimxibawvzc5vuno@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox