From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A31CF203B99DE for ; Mon, 2 Jul 2018 07:00:45 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id l15-v6so7891480wmc.1 for ; Mon, 02 Jul 2018 07:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m9ZBRDkZISoLRE3/w2vpR/HglqbxzKShz01wEHo28hA=; b=Q42wwaktUtdpntWBJ8J1sKRK8l9FPgBmYySA6zOmC0nemrQVa4HdJiRzCYyYoIhNnf ulcXU4i5i/nK42U4SgAuTWmUAlLX09jCfXwcDHM/2Vhxv9qQz5qifT4NMQHk/rBvM47q uCAUGDoDRjK83IRWudU2etiIh69GMmgTz9EX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m9ZBRDkZISoLRE3/w2vpR/HglqbxzKShz01wEHo28hA=; b=oBzMEZdphHf7HdlnbTPSSC9cqahzyZDPjWg7t/2kGoaj99e+BNUKDiC2li/cC5biGs c0SK69j+Klck1KoHbHc1SkJ/oLaWPjaUcdazn+EtGf4V8C00NO675QmbLxlmg+gk4N39 uAnyrv/4cuCYnRB6pvy6O7EeM+0XlQNhqu/kuLVDG31OS/TTyHUd0KEhxbJOVtLF8eBk neUqURZnrsFKbGzg5WSmYOp/IKsulTbzJMxd040LzDdlKM7SJGzmwn4JYKtsvSI8c4Wm GzxA+KSKrMSNykDscY5VKKQ4F+wFYIencpAsYAkQqnL2208QU7V1BnuPJBqhiYMaej4w F8pQ== X-Gm-Message-State: APt69E2qSJ3BfKjtwMPvNAttGFkBZ+LX0+5Bg+6Rr70nliMDlhoxKgX5 ZJf6lwR1+4/EOyjn4bH4Jdvdfg== X-Google-Smtp-Source: AAOMgpex2tJ5fSdc7b+FSLE0NzyhcXyvJziT8pY70kXur4Ke+Dq6wPu+IRJOWp4oaasqxv/iYCMeYQ== X-Received: by 2002:a1c:8a04:: with SMTP id m4-v6mr5037972wmd.137.1530540043532; Mon, 02 Jul 2018 07:00:43 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e128-v6sm10736154wma.46.2018.07.02.07.00.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 07:00:42 -0700 (PDT) Date: Mon, 2 Jul 2018 15:00:40 +0100 From: Leif Lindholm To: Sami Mujawar Cc: edk2-devel@lists.01.org, evan.lloyd@arm.com, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com Message-ID: <20180702140040.zimxibawvzc5vuno@bivouac.eciton.net> References: <20180627164746.36188-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20180627164746.36188-1-sami.mujawar@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 14:00:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 27, 2018 at 05:47:41PM +0100, Sami Mujawar wrote: > This patch series fixes the issues reported by the ecc tool. > > The changes can be seen at https://github.com/samimujawar/edk2-staging/tree/290_fix_ecc_issues_v1 For series: Reviewed-by: Leif Lindholm Pushed as 726ccd02b1..d4b26ac2bb. / Leif > Sami Mujawar (5): > DynamicTablesPkg: Add module info to file header > DynamicTablesPkg: Fix function documentation > DynamicTablesPkg: Fix variable naming issue > DynamicTablesPkg: Fix macro to prevent side effect > DynamicTablesPkg: Fix variable declaration > > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/AcpiTableFactory.c | 6 +- > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactory/DeviceTreeTableFactory.c | 6 +- > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory.h | 6 +- > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c | 2 +- > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 1 + > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/SmbiosTableFactory.c | 6 +- > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c | 59 +++--- > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 1 + > DynamicTablesPkg/DynamicTablesPkg.dec | 5 +- > DynamicTablesPkg/Include/AcpiTableGenerator.h | 30 +-- > DynamicTablesPkg/Include/ConfigurationManagerHelper.h | 2 +- > DynamicTablesPkg/Include/ConfigurationManagerObject.h | 12 +- > DynamicTablesPkg/Include/DeviceTreeTableGenerator.h | 24 +-- > DynamicTablesPkg/Include/Library/TableHelperLib.h | 6 +- > DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h | 4 +- > DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 6 +- > DynamicTablesPkg/Include/SmbiosTableGenerator.h | 24 +-- > DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +- > DynamicTablesPkg/Include/TableGenerator.h | 32 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 16 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 20 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 38 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 194 ++++++++++---------- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 32 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c | 16 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c | 13 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 12 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 4 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf | 1 + > 37 files changed, 316 insertions(+), 272 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >