[PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Sami Mujawar]

This patch series fixes the issues reported by the ecc tool.

The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

Sami Mujawar (6):
  Platform/ARM: FVP: Add module info to file header
  Platform/ARM: FVP: Fix function documentation
  Platform/ARM: FVP: Fix variable declaration
  Platform/ARM: Juno: Add module info to file header
  Platform/ARM: Juno: Fix function documentation
  Platform/ARM: Juno: Fix variable declaration

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                            |  3 +-
 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          | 86 +++++++++---------
 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  1 +
 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf           |  1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        |  3 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 93 ++++++++++----------
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       |  1 +
 8 files changed, 101 insertions(+), 88 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 1/6][platforms/devel-dynamictables] Platform/ARM: FVP: Add module info to file header

[Sami Mujawar]

The ecc tool reports that the Header comment section must
have Abstract information.

Added a brief module description to the file header.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        | 3 ++-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 1 +
 Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc
index 8402742ebb0249d8b585d2315e24bba2f5ecf480..68dbff08fb95721b766439c7e8e93849a1a76e5a 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc
@@ -1,6 +1,7 @@
 ## @file
+#  dsc include file for Configuration Manager
 #
-#  Copyright (c) 2017, ARM Limited. All rights reserved.
+#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
index ff61763f661289e2f86911b5f68576ac657a400c..3cef37fc61c03e0f740fc431608835038c9e26c5 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
@@ -1,4 +1,5 @@
 ## @file
+# Configuration Manager Dxe
 #
 #  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
index 28426e18f32dc25af6faf51826e11d5e09fe105d..9a5f3d05fbe05461756bd6198dd1ecd95d26ac97 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
@@ -1,4 +1,5 @@
 ## @file
+#  Platform ASL Tables
 #
 #  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 2/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix function documentation

[Sami Mujawar]

Fixed function documentation issues reported by ecc tool.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 84 ++++++++++----------
 1 file changed, 42 insertions(+), 42 deletions(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 2e1be34acf49962fd1899d84dec96c8cb9155b2c..a67a09cb6c197a14b376d4a8ef9a90e438efb2bb 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -230,7 +230,7 @@ EFI_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = {
 
   @retval
     EFI_SUCCESS   Success
-*/
+**/
 STATIC
 EFI_STATUS
 EFIAPI
@@ -243,16 +243,16 @@ InitializePlatformRepository (
 
 /** Return a GT Block timer frame info list.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       A token for identifying the object
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       A token for identifying the object
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetGTBlockTimerFrameInfo (
@@ -283,17 +283,17 @@ GetGTBlockTimerFrameInfo (
 
 /** Return a standard namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetStandardNameSpaceObject (
@@ -333,17 +333,17 @@ GetStandardNameSpaceObject (
 
 /** Return an ARM namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetArmNameSpaceObject (
@@ -414,12 +414,12 @@ GetArmNameSpaceObject (
 
 /** Return an OEM namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
@@ -427,7 +427,7 @@ GetArmNameSpaceObject (
   @retval EFI_BAD_BUFFER_SIZE   The size returned by the Configuration Manager
                                 is less than the Object size for the requested
                                 object.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetOemNameSpaceObject (
@@ -465,17 +465,17 @@ GetOemNameSpaceObject (
     Configuration Manager Protocol for returning the Configuration
     Manager Objects.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 ArmVExpressPlatformGetObject (
@@ -522,15 +522,15 @@ ArmVExpressPlatformGetObject (
     Configuration Manager Protocol for updating the Configuration
     Manager Objects.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in]      CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the Object.
 
   @retval EFI_UNSUPPORTED  This operation is not supported.
-*/
+**/
 EFI_STATUS
 EFIAPI
 ArmVExpressPlatformSetObject (
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 3/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix variable declaration

[Sami Mujawar]

Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index a67a09cb6c197a14b376d4a8ef9a90e438efb2bb..35104612e691613f7bbc43511bb921ff111e1fe9 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -303,9 +303,10 @@ GetStandardNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS                      Status = EFI_SUCCESS;
+  EFI_STATUS                      Status;
   EFI_PLATFORM_REPOSITORY_INFO  * PlatformRepo;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
@@ -353,9 +354,10 @@ GetArmNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS                      Status = EFI_SUCCESS;
+  EFI_STATUS                      Status;
   EFI_PLATFORM_REPOSITORY_INFO  * PlatformRepo;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
@@ -437,8 +439,9 @@ GetOemNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS  Status = EFI_SUCCESS;
+  EFI_STATUS  Status;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 4/6][platforms/devel-dynamictables] Platform/ARM: Juno: Add module info to file header

[Sami Mujawar]

The ecc tool reports that the Header comment section must
have Abstract information.

Added a brief module description to the file header.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        | 3 ++-
 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 1 +
 Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc
index d811556603cbdd157cfcfe2c61976b469ea15e29..4a36ffcd46129b1d6207fa7ffe83443404f93629 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc
@@ -1,6 +1,7 @@
 ## @file
+#  dsc include file for Configuration Manager
 #
-#  Copyright (c) 2017, ARM Limited. All rights reserved.
+#  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
index c1bd6de9a2fb9fbe592d91ee77c6107580a3fb5a..70c97e788aea7e5297eb152a7383b528994f1021 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
@@ -1,4 +1,5 @@
 ## @file
+#  Configuration Manager Dxe
 #
 #  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf b/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
index 4b6e48d3efcd3ceb094c4b291eaa4c3060e93b92..3a706f2c27d4c28a17354e1d60a84af71d34a4a9 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf
@@ -1,4 +1,5 @@
 ## @file
+#  Platform ASL Tables
 #
 #  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
 #
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 5/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix function documentation

[Sami Mujawar]

Fixed function documentation issues reported by ecc tool.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 72 ++++++++++----------
 1 file changed, 36 insertions(+), 36 deletions(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index 4c878f663ab247307a17582c07f303ddb11b7d41..c0086bddb82fb7108aa0d5dccffb6b02c0cb73c4 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -228,7 +228,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInfo = {
   @param [in]  This        Pointer to the Configuration Manager Protocol.
 
   @retval EFI_SUCCESS   Success
-*/
+**/
 STATIC
 EFI_STATUS
 EFIAPI
@@ -247,17 +247,17 @@ InitializePlatformRepository (
 
 /** Return a standard namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetStandardNameSpaceObject (
@@ -319,17 +319,17 @@ GetStandardNameSpaceObject (
 
 /** Return an ARM namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetArmNameSpaceObject (
@@ -399,17 +399,17 @@ GetArmNameSpaceObject (
 
 /** Return an OEM namespace object.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 GetOemNameSpaceObject (
@@ -447,17 +447,17 @@ GetOemNameSpaceObject (
     Configuration Manager Protocol for returning the Configuration
     Manager Objects.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the requested Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in, out] CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the requested Object.
 
   @retval EFI_SUCCESS           Success.
   @retval EFI_INVALID_PARAMETER A parameter is invalid.
   @retval EFI_NOT_FOUND         The required object information is not found.
-*/
+**/
 EFI_STATUS
 EFIAPI
 ArmJunoPlatformGetObject (
@@ -504,15 +504,15 @@ ArmJunoPlatformGetObject (
     Configuration Manager Protocol for updating the Configuration
     Manager Objects.
 
-  @param [in]  This        Pointer to the Configuration Manager Protocol.
-  @param [in]  CmObjectId  The Configuration Manager Object ID.
-  @param [in]  Token       An optional token identifying the object. If
-                           unused this must be CM_NULL_TOKEN.
-  @param [out] CmObject    Pointer to the Configuration Manager Object
-                           descriptor describing the Object.
+  @param [in]      This        Pointer to the Configuration Manager Protocol.
+  @param [in]      CmObjectId  The Configuration Manager Object ID.
+  @param [in]      Token       An optional token identifying the object. If
+                               unused this must be CM_NULL_TOKEN.
+  @param [in]      CmObject    Pointer to the Configuration Manager Object
+                               descriptor describing the Object.
 
   @retval EFI_UNSUPPORTED  This operation is not supported.
-*/
+**/
 EFI_STATUS
 EFIAPI
 ArmJunoPlatformSetObject (
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

[PATCH edk2-platforms v1 6/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix variable declaration

[Sami Mujawar]

Fixed the 'There should be no initialization of a variable
as part of its declaration Variable Name' errors reported
by the ecc tool.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Fix ecc tool reported issues                                  [SAMI]

 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
index c0086bddb82fb7108aa0d5dccffb6b02c0cb73c4..db29d1351f4e2ae7195887b4c9a2833ef078f6f4 100644
--- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
+++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
@@ -267,9 +267,11 @@ GetStandardNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS                      Status = EFI_SUCCESS;
+  EFI_STATUS                      Status;
   EFI_PLATFORM_REPOSITORY_INFO  * PlatformRepo;
+  UINT32                          TableCount;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
@@ -284,8 +286,8 @@ GetStandardNameSpaceObject (
       if (PlatformRepo->JunoRevision != JUNO_REVISION_R0) {
         CmObject->Size = sizeof (PlatformRepo->CmAcpiTableList);
       } else {
-        UINT32 TableCount = sizeof (PlatformRepo->CmAcpiTableList) /
-                              sizeof (PlatformRepo->CmAcpiTableList[0]);
+        TableCount = sizeof (PlatformRepo->CmAcpiTableList) /
+                       sizeof (PlatformRepo->CmAcpiTableList[0]);
         /* The last 2 tables in the ACPI table list enable PCIe support.
            Reduce the CmObject size so that the PCIe specific ACPI
            tables are not installed on Juno R0
@@ -339,9 +341,10 @@ GetArmNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS                      Status = EFI_SUCCESS;
+  EFI_STATUS                      Status;
   EFI_PLATFORM_REPOSITORY_INFO  * PlatformRepo;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
@@ -419,8 +422,9 @@ GetOemNameSpaceObject (
   IN  OUT   CM_OBJ_DESCRIPTOR                   * CONST CmObject
   )
 {
-  EFI_STATUS  Status = EFI_SUCCESS;
+  EFI_STATUS  Status;
 
+  Status = EFI_SUCCESS;
   if ((This == NULL) || (CmObject == NULL)) {
     ASSERT (This != NULL);
     ASSERT (CmObject != NULL);
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Evan Lloyd]

Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: 27 June 2018 17:49
> To: edk2-devel@lists.01.org
> Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> <Daniil.Egranov@arm.com>; Thomas Abraham
> <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd
> <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> <nd@arm.com>
> Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> issues reported by ecc tool
> 
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-
> platforms/tree/290_fix_ecc_issues_v1
> 
> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> nc                            |  3 +-
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManager.c          | 86 +++++++++---------
> 
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> onfigurationManagerDxe.inf     |  1 +
> 
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> rmASLTablesLib.inf           |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> sc.inc                        |  3 +-
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManager.c      | 93 ++++++++++----------
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> xe/ConfigurationManagerDxe.inf |  1 +
> 
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> atformASLTablesLib.inf       |  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

Re: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Leif Lindholm]

On Wed, Jun 27, 2018 at 04:58:04PM +0000, Evan Lloyd wrote:
> 
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Should I take this one (and the one on the other accompanying set) as
Reviewed-by?

/
    Leif

> > -----Original Message-----
> > From: Sami Mujawar <sami.mujawar@arm.com>
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> > <Daniil.Egranov@arm.com>; Thomas Abraham
> > <thomas.abraham@arm.com>; leif.lindholm@linaro.org; Evan Lloyd
> > <Evan.Lloyd@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
> > Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
> > <nd@arm.com>
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix
> > issues reported by ecc tool
> > 
> > This patch series fixes the issues reported by the ecc tool.
> > 
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> > 
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> > 
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc                            |  3 +-
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c          | 86 +++++++++---------
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf     |  1 +
> > 
> > Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf           |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc                        |  3 +-
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c      | 93 ++++++++++----------
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> > 
> > Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf       |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> > 
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> > 
> 

Re: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Evan Lloyd]

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Evan
> Lloyd
> Sent: 27 June 2018 17:58
> To: Sami Mujawar <Sami.Mujawar@arm.com>; edk2-devel@lists.01.org
> Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Stephanie Hughes-Fitt
> <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> Subject: Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-
> dynamictables] Fix issues reported by ecc tool
> 
> 
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

 [[Evan Lloyd]] Oops, copy pasted wrong line, sorry.
Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>

> 
> > -----Original Message-----
> > From: Sami Mujawar <sami.mujawar@arm.com>
> > Sent: 27 June 2018 17:49
> > To: edk2-devel@lists.01.org
> > Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Daniil Egranov
> > <Daniil.Egranov@arm.com>; Thomas Abraham
> <thomas.abraham@arm.com>;
> > leif.lindholm@linaro.org; Evan Lloyd <Evan.Lloyd@arm.com>; Matteo
> > Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt
> > <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
> > Subject: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables]
> > Fix issues reported by ecc tool
> >
> > This patch series fixes the issues reported by the ecc tool.
> >
> > The changes can be seen at https://github.com/samimujawar/edk2-
> > platforms/tree/290_fix_ecc_issues_v1
> >
> > Sami Mujawar (6):
> >   Platform/ARM: FVP: Add module info to file header
> >   Platform/ARM: FVP: Fix function documentation
> >   Platform/ARM: FVP: Fix variable declaration
> >   Platform/ARM: Juno: Add module info to file header
> >   Platform/ARM: Juno: Fix function documentation
> >   Platform/ARM: Juno: Fix variable declaration
> >
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.i
> > nc                            |  3 +-
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManager.c          | 86 +++++++++---------
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/C
> > onfigurationManagerDxe.inf     |  1 +
> >
> >
> Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo
> > rmASLTablesLib.inf           |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.d
> > sc.inc                        |  3 +-
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManager.c      | 93 ++++++++++----------
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerD
> > xe/ConfigurationManagerDxe.inf |  1 +
> >
> >
> Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl
> > atformASLTablesLib.inf       |  1 +
> >  8 files changed, 101 insertions(+), 88 deletions(-)
> >
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

[Leif Lindholm]

On Wed, Jun 27, 2018 at 05:48:42PM +0100, Sami Mujawar wrote:
> This patch series fixes the issues reported by the ecc tool.
> 
> The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/290_fix_ecc_issues_v1

For series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 693bbd8747..63de92e662.

/
    Leif

> Sami Mujawar (6):
>   Platform/ARM: FVP: Add module info to file header
>   Platform/ARM: FVP: Fix function documentation
>   Platform/ARM: FVP: Fix variable declaration
>   Platform/ARM: Juno: Add module info to file header
>   Platform/ARM: Juno: Fix function documentation
>   Platform/ARM: Juno: Fix variable declaration
> 
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc                            |  3 +-
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          | 86 +++++++++---------
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  1 +
>  Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf           |  1 +
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                        |  3 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 93 ++++++++++----------
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  1 +
>  Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASLTablesLib.inf       |  1 +
>  8 files changed, 101 insertions(+), 88 deletions(-)
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
>