From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55B06210F2CF9 for ; Tue, 3 Jul 2018 03:44:34 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id t6-v6so1454875wrn.7 for ; Tue, 03 Jul 2018 03:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=puDXZWz/629IXJFZWGWprvZLd5E5hCrHZUTnI0t9VEk=; b=fPO1EHMF8zZEE/c10P3dQIp9vAasMmS/HgLRH2wuDhI+M/BeCSjIOYqSYkPSwGzSlx B6QkipHpo6lLUBM/5FNEjZW6hMk695mQTZRUdjGRrG0FC0fSdEAFncX9rXYpPbR8ZUcJ 5bo6mcUcJ7eWT3WFbo0nXKDEPdfMK1tD/C5lw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=puDXZWz/629IXJFZWGWprvZLd5E5hCrHZUTnI0t9VEk=; b=eYF5dlshqszN53BSyiOBuTlrJr1kh7SEu/JKG2YWlk3Be/EO+S4xNt5z4fBB4zbgT7 PWPrNkHrulgm1LXkdnglgEjASNEidl9rBAsA4HuEGLQgPf2xSnby047PbZKOU/U597J0 Dntra2IPCFT1iDNWzbcCqUSjnWCpPK5O00Uw/04ad0MvGtNy8pw3ME5SuJaeNTq/whmC /BwpcZs8eEsIc3HqNDjuwnpxg3wndmdaLmwZoWKpUcGHRVt1oJDks9po2ZDJSzWuu3rM 0/OJU/GapPJW7T+HjVjmz3TjYB+d+YMCk/zBNNJ846rbnPpH0goPDvtcUlFetxva6GbW 7LPA== X-Gm-Message-State: APt69E1WwjLxcLA1vEdNGHF3IcF0T4yGXtKyLEOHH2N4zYqlrJbHSD1K cheroJygOhamRytCdGFjrO73zJo8lic= X-Google-Smtp-Source: AAOMgpe/2ICmghgGcd9YiygOs9LaK3l0juoXvvI8RGt9/XBELQS3mtZAeD12rANcDBDQ/CSIUI1TTA== X-Received: by 2002:adf:9465:: with SMTP id 92-v6mr24117811wrq.283.1530614672645; Tue, 03 Jul 2018 03:44:32 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g75-v6sm1356383wmd.38.2018.07.03.03.44.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 03:44:31 -0700 (PDT) Date: Tue, 3 Jul 2018 11:44:30 +0100 From: Leif Lindholm To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org, Achin Gupta , Ard Biesheuvel Message-ID: <20180703104430.lu3qxsjpptzhhbtu@bivouac.eciton.net> References: <1530611715-9819-1-git-send-email-supreeth.venkatesh@arm.com> <1530611715-9819-4-git-send-email-supreeth.venkatesh@arm.com> MIME-Version: 1.0 In-Reply-To: <1530611715-9819-4-git-send-email-supreeth.venkatesh@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 3/6] ArmPkg/Include: Add MM interface SVC return codes. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 10:44:34 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 03, 2018 at 03:25:12PM +0530, Supreeth Venkatesh wrote: > This patch adds the Management Mode(MM) - Secure Partition > Manager(SPM) SVC return codes. > > Also, It corrects SVC ID for retrieving SPM version information. That sounds unrelated. And looking at it, worthy of a longer explanation, so probably worth breaking out as a separate patch. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > index 4c7b6c3..a64b9ec 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > @@ -20,7 +20,7 @@ > * delegated events and request the Secure partition manager to perform > * privileged operations on its behalf. > */ > -#define ARM_SVC_ID_SPM_VERSION_AARCH64 0xC4000060 > +#define ARM_SVC_ID_SPM_VERSION_AARCH32 0x84000060 So, this isn't "correcting" a value - it's replacing a 64-bit call with a 32-bit one. Which is potentially fine, but then it deserves a separate patch and a commit message clearly describing why this is the right thing to do. Regards, Leif > #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64 0xC4000061 > #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 0xC4000064 > #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64 0xC4000065 > @@ -40,4 +40,11 @@ > ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << SET_MEM_ATTR_CODE_PERM_SHIFT) | \ > (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << SET_MEM_ATTR_DATA_PERM_SHIFT)) > > +/* MM SVC Return error codes */ > +#define ARM_SVC_SPM_RET_SUCCESS 0 > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED -1 > +#define ARM_SVC_SPM_RET_INVALID_PARAMS -2 > +#define ARM_SVC_SPM_RET_DENIED -3 > +#define ARM_SVC_SPM_RET_NO_MEMORY -5 > + > #endif > -- > 2.7.4 >