public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update
@ 2018-07-09  3:09 Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 1/4] AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros Hao Wu
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Hao Wu @ 2018-07-09  3:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jiewen Yao

The series updates the IPMI-related codes to stop using the file
'IpmiEx.h', and to use the IPMI headers within edk2\MdePkg.

Test performed:
MinPurley VS2015 build pass.

Cc: Jiewen Yao <jiewen.yao@intel.com>

Hao Wu (4):
  AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros
  AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg
  PurleyOpenBoardPkg Ipmi: Update codes for header changes in MdePkg
  AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h

 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c                                     |   4 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c                                          |  11 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c                                          |   5 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h                                      | 296 --------------------
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h                      |   3 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c                                     |  11 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c                                |  10 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c                                |  10 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c       |   1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c   |   1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c   |   7 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c |   1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c                     |   1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c                                         |   7 +-
 Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c                                 |  11 +-
 Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c              |   3 +-
 16 files changed, 43 insertions(+), 339 deletions(-)
 delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h

-- 
2.12.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms\devel-MinPlatform 1/4] AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros
  2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
@ 2018-07-09  3:09 ` Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 2/4] AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg Hao Wu
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Hao Wu @ 2018-07-09  3:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jiewen Yao

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
index 8371a90015..acba9d8e23 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
@@ -53,20 +53,20 @@ Returns:
   //
   Status = IpmiGetDeviceId (&ControllerInfo);
   if (EFI_ERROR (Status)) {
-    DEBUG((EFI_D_ERROR, "!!! IpmiFru  IpmiGetDeviceId Status=%x\n", Status));
+    DEBUG((DEBUG_ERROR, "!!! IpmiFru  IpmiGetDeviceId Status=%x\n", Status));
     return Status;
   }
 
-  DEBUG((EFI_D_ERROR, "!!! IpmiFru  FruInventorySupport %x\n", ControllerInfo.FruInventorySupport));
+  DEBUG((DEBUG_ERROR, "!!! IpmiFru  FruInventorySupport %x\n", ControllerInfo.FruInventorySupport));
 
   if (ControllerInfo.FruInventorySupport) {
     GetFruInventoryAreaInfoRequest.DeviceId = 0;
     Status = IpmiGetFruInventoryAreaInfo (&GetFruInventoryAreaInfoRequest, &GetFruInventoryAreaInfoResponse);
     if (EFI_ERROR (Status)) {
-      DEBUG((EFI_D_ERROR, "!!! IpmiFru  IpmiGetFruInventoryAreaInfo Status=%x\n", Status));
+      DEBUG((DEBUG_ERROR, "!!! IpmiFru  IpmiGetFruInventoryAreaInfo Status=%x\n", Status));
       return Status;
     }
-    DEBUG((EFI_D_ERROR, "!!! IpmiFru  InventoryAreaSize=%x\n", GetFruInventoryAreaInfoResponse.InventoryAreaSize));
+    DEBUG((DEBUG_ERROR, "!!! IpmiFru  InventoryAreaSize=%x\n", GetFruInventoryAreaInfoResponse.InventoryAreaSize));
   }
 
   return EFI_SUCCESS;
-- 
2.12.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms\devel-MinPlatform 2/4] AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg
  2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 1/4] AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros Hao Wu
@ 2018-07-09  3:09 ` Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 3/4] PurleyOpenBoardPkg Ipmi: " Hao Wu
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Hao Wu @ 2018-07-09  3:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jiewen Yao

The commit will remove the dependency on file:
Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h

The IPMI header files within:
edk2/MdePkg/Include/IndustryStandard/

already have the structure definitions in this IpmiEx.h file.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c                                     |  4 ++--
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c                                          | 11 +++++------
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c                                          |  5 ++---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h                      |  3 +--
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c                                     |  5 ++---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c                                | 10 ++++++++--
 Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c                                | 10 ++++++++--
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c       |  1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c   |  1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c   |  7 +++----
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c |  1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c                     |  1 -
 Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c                                         |  7 +++----
 Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c                                 | 11 +++++------
 14 files changed, 39 insertions(+), 38 deletions(-)

diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
index 988b179c01..6125e2bd94 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
@@ -130,7 +130,7 @@ Returns:
   }
 
   if (EnableElog == NULL) {
-    *ElogStatus = GetBmcGlobalEnables.SystemEventLogging;
+    *ElogStatus = GetBmcGlobalEnables.GetEnables.Bits.SystemEventLogging;
   } else {
     if (Status == EFI_SUCCESS) {
       if (*EnableElog) {
@@ -138,7 +138,7 @@ Returns:
       }
 
       CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + sizeof(UINT8), sizeof(UINT8));
-      SetBmcGlobalEnables.EnableSystemEventLogging = ElogStat;
+      SetBmcGlobalEnables.SetEnables.Bits.SystemEventLogging = ElogStat;
 
       Status = IpmiSetBmcGlobalEnables (&SetBmcGlobalEnables, &CompletionCode);
     }
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c
index 42fc6fc2ec..719d968b5a 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c
@@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/PcdLib.h>
 #include <Library/IpmiCommandLib.h>
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 EFI_STATUS
 EfiDisableFrb (
@@ -56,7 +55,7 @@ EfiDisableFrb (
   //
   // Check if timer is still running, if not abort disable routine.
   //
-  if (GetWatchdogTimer.TimerUse.TimerRunning == 0) {
+  if (GetWatchdogTimer.TimerUse.Bits.TimerRunning == 0) {
     return EFI_ABORTED;
   }
 
@@ -64,8 +63,8 @@ EfiDisableFrb (
   //
   // Just flip the Timer Use bit. This should release the timer.
   //
-  SetWatchdogTimer.TimerUse.TimerRunning         = 0;
-  SetWatchdogTimer.TimerUse.TimerUse             = IPMI_WATCHDOG_TIMER_BIOS_FRB2;
+  SetWatchdogTimer.TimerUse.Bits.TimerRunning    = 0;
+  SetWatchdogTimer.TimerUse.Bits.TimerUse        = IPMI_WATCHDOG_TIMER_BIOS_FRB2;
   SetWatchdogTimer.TimerUseExpirationFlagsClear &= ~BIT2;
   SetWatchdogTimer.TimerUseExpirationFlagsClear |= BIT1 | BIT4;
 
@@ -150,7 +149,7 @@ CheckForAndReportErrors(
   SetWatchdogTimer.PretimeoutInterval             = GetWatchdogTimer.PretimeoutInterval;
   SetWatchdogTimer.TimerUseExpirationFlagsClear   = GetWatchdogTimer.TimerUseExpirationFlagsClear;
   SetWatchdogTimer.InitialCountdownValue          = GetWatchdogTimer.InitialCountdownValue;
-  SetWatchdogTimer.TimerUse.TimerRunning          = 1;
+  SetWatchdogTimer.TimerUse.Bits.TimerRunning     = 1;
   SetWatchdogTimer.TimerUseExpirationFlagsClear  |= BIT1 | BIT2 | BIT3;
 
   Status = IpmiSetWatchdogTimer (&SetWatchdogTimer, &CompletionCode);
@@ -192,7 +191,7 @@ ReportFrb2Status (
   //
   // Check if timer is running, report status to DEBUG_MODE output.
   //
-  if (GetWatchdogTimer.TimerUse.TimerRunning == 1) {
+  if (GetWatchdogTimer.TimerUse.Bits.TimerRunning == 1) {
     DEBUG ((DEBUG_INFO, "FRB2 Timer is running.\n"));
   } else {
     DEBUG ((DEBUG_INFO, "FRB2 Timer is not running.\n"));
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c
index 73f401284c..2a077bc3b9 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c
@@ -20,7 +20,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiCommandLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 VOID
 SetWatchDogTimer (
@@ -40,9 +39,9 @@ SetWatchDogTimer (
   if (Frb2Enabled) {
     ZeroMem (&FrbTimer, sizeof(FrbTimer));
     //Byte 1
-    FrbTimer.TimerUse.TimerUse = IPMI_WATCHDOG_TIMER_BIOS_FRB2;
+    FrbTimer.TimerUse.Bits.TimerUse = IPMI_WATCHDOG_TIMER_BIOS_FRB2;
     //Byte 2 
-    FrbTimer.TimerActions = 0;    //NormalBoot, NoTimeOutInterrupt. i.e no action when BMC watchdog timeout
+    FrbTimer.TimerActions.Uint8 = 0;    //NormalBoot, NoTimeOutInterrupt. i.e no action when BMC watchdog timeout
     //Byte 3
     FrbTimer.PretimeoutInterval = 0;
     //Byte 4
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h
index 216f2adb55..592d9c6846 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h
@@ -17,7 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
 #include <Uefi.h>
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 //
 // NetFnApp
@@ -228,7 +227,7 @@ IpmiSetSelTime (
 EFI_STATUS
 EFIAPI
 IpmiGetSdrRepositoryInfo (
-  OUT IPMI_GET_SDR_REPOSITORY_INFO  *GetSdrRepositoryInfo
+  OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE  *GetSdrRepositoryInfoResp
   );
 
 EFI_STATUS
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
index acba9d8e23..1be62a882b 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c
@@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/BaseMemoryLib.h>
 #include <Library/IpmiCommandLib.h>
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 EFI_STATUS
 InitializeFru (
@@ -57,9 +56,9 @@ Returns:
     return Status;
   }
 
-  DEBUG((DEBUG_ERROR, "!!! IpmiFru  FruInventorySupport %x\n", ControllerInfo.FruInventorySupport));
+  DEBUG((DEBUG_ERROR, "!!! IpmiFru  FruInventorySupport %x\n", ControllerInfo.DeviceSupport.Bits.FruInventorySupport));
 
-  if (ControllerInfo.FruInventorySupport) {
+  if (ControllerInfo.DeviceSupport.Bits.FruInventorySupport) {
     GetFruInventoryAreaInfoRequest.DeviceId = 0;
     Status = IpmiGetFruInventoryAreaInfo (&GetFruInventoryAreaInfoRequest, &GetFruInventoryAreaInfoResponse);
     if (EFI_ERROR (Status)) {
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c
index 0a49b87859..5c5079d7fb 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c
@@ -104,8 +104,14 @@ Returns:
     }
   } while (TRUE);
 
-  DEBUG((DEBUG_INFO, "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n", BmcInfo.DeviceId, BmcInfo.MajorFirmwareRev, BmcInfo.MinorFirmwareRev));
-  *UpdateMode = (BOOLEAN)BmcInfo.UpdateMode;
+  DEBUG((
+    DEBUG_INFO,
+    "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n",
+    BmcInfo.DeviceId,
+    BmcInfo.FirmwareRev1.Bits.MajorFirmwareRev,
+    BmcInfo.MinorFirmwareRev
+    ));
+  *UpdateMode = (BOOLEAN)BmcInfo.FirmwareRev1.Bits.UpdateMode;
   return Status;
 }
 
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c
index 962aff6f4b..85dfcf77e0 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c
@@ -62,8 +62,14 @@ Returns:
     }
   } while (TRUE);
 
-  DEBUG((DEBUG_INFO, "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n", BmcInfo.DeviceId, BmcInfo.MajorFirmwareRev, BmcInfo.MinorFirmwareRev));
-  *UpdateMode = (BOOLEAN)BmcInfo.UpdateMode;
+  DEBUG((
+    DEBUG_INFO,
+    "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n",
+    BmcInfo.DeviceId,
+    BmcInfo.FirmwareRev1.Bits.MajorFirmwareRev,
+    BmcInfo.MinorFirmwareRev
+    ));
+  *UpdateMode = (BOOLEAN)BmcInfo.FirmwareRev1.Bits.UpdateMode;
   return Status;
 }
 
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
index f11b23a439..4280f8805a 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
@@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 EFI_STATUS
 EFIAPI
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
index eb699907a2..1f50ca1834 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
@@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 
 EFI_STATUS
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
index ce2b7b9eb8..c7af988bd8 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
@@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 
 EFI_STATUS
@@ -242,19 +241,19 @@ IpmiSetSelTime (
 EFI_STATUS
 EFIAPI
 IpmiGetSdrRepositoryInfo (
-  OUT IPMI_GET_SDR_REPOSITORY_INFO  *GetSdrRepositoryInfo
+  OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE  *GetSdrRepositoryInfoResp
   )
 {
   EFI_STATUS                   Status;
   UINT32                       DataSize;
 
-  DataSize = sizeof(*GetSdrRepositoryInfo);
+  DataSize = sizeof(*GetSdrRepositoryInfoResp);
   Status = IpmiSubmitCommand (
              IPMI_NETFN_STORAGE,
              IPMI_STORAGE_GET_SDR_REPOSITORY_INFO,
              NULL,
              0,
-             (VOID *)GetSdrRepositoryInfo,
+             (VOID *)GetSdrRepositoryInfoResp,
              &DataSize
              );
   return Status;
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
index 925436e61e..309cea819f 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
@@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 
 EFI_STATUS
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c
index cdeac9d651..13b7e0b5a7 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c
@@ -16,7 +16,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/DebugLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 /**
   This service enables submitting commands via Ipmi.
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c
index c64c70f2a9..1001cb0192 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c
@@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/UefiBootServicesTableLib.h>
 #include <Library/IpmiCommandLib.h>
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 BOOLEAN mOsWdtFlag = FALSE;
 
@@ -71,9 +70,9 @@ Returns:
   //
   // Just flip the Timer Use bit. This should release the timer.
   //
-  SetWatchdogTimer.TimerUse.TimerRunning         = 1;
-  SetWatchdogTimer.TimerUse.TimerUse             = IPMI_WATCHDOG_TIMER_OS_LOADER;
-  SetWatchdogTimer.TimerActions                  = IPMI_WATCHDOG_TIMER_ACTION_HARD_RESET;
+  SetWatchdogTimer.TimerUse.Bits.TimerRunning    = 1;
+  SetWatchdogTimer.TimerUse.Bits.TimerUse        = IPMI_WATCHDOG_TIMER_OS_LOADER;
+  SetWatchdogTimer.TimerActions.Uint8            = IPMI_WATCHDOG_TIMER_ACTION_HARD_RESET;
   SetWatchdogTimer.TimerUseExpirationFlagsClear &= ~BIT4;
   SetWatchdogTimer.TimerUseExpirationFlagsClear |= BIT1 | BIT2;
   SetWatchdogTimer.InitialCountdownValue         = 600; // 100ms / count
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c
index 6d2dbd5bea..4163fa1229 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c
@@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/UefiRuntimeServicesTableLib.h>
 #include <Library/IpmiCommandLib.h>
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 #define SOL_CMD_RETRY_COUNT           10
 
@@ -55,8 +54,8 @@ GetSOLStatus (
 
   for (RetryCount = 0; RetryCount < SOL_CMD_RETRY_COUNT; RetryCount++) {
     ZeroMem (&GetConfigurationParametersRequest, sizeof(GetConfigurationParametersRequest));
-    GetConfigurationParametersRequest.ChannelNumber     = Channel;
-    GetConfigurationParametersRequest.ParameterSelector = ParamSel;
+    GetConfigurationParametersRequest.ChannelNumber.Bits.ChannelNumber = Channel;
+    GetConfigurationParametersRequest.ParameterSelector                = ParamSel;
 
     ZeroMem (&GetConfigurationParametersResponse, sizeof(GetConfigurationParametersResponse));
 
@@ -110,9 +109,9 @@ SetSOLParams (
 
   for (RetryCount = 0; RetryCount < SOL_CMD_RETRY_COUNT; RetryCount++) {
     ZeroMem (&SetConfigurationParametersRequest, sizeof(SetConfigurationParametersRequest));
-    SetConfigurationParametersRequest.ChannelNumber     = Channel;
-    SetConfigurationParametersRequest.ParameterSelector = ParamSel;
-    SetConfigurationParametersRequest.ParameterData[0]  = Data;
+    SetConfigurationParametersRequest.ChannelNumber.Bits.ChannelNumber = Channel;
+    SetConfigurationParametersRequest.ParameterSelector                = ParamSel;
+    SetConfigurationParametersRequest.ParameterData[0]                 = Data;
 
     CompletionCode = 0;
 
-- 
2.12.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms\devel-MinPlatform 3/4] PurleyOpenBoardPkg Ipmi: Update codes for header changes in MdePkg
  2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 1/4] AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 2/4] AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg Hao Wu
@ 2018-07-09  3:09 ` Hao Wu
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 4/4] AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h Hao Wu
  2018-07-09  3:31 ` [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Yao, Jiewen
  4 siblings, 0 replies; 6+ messages in thread
From: Hao Wu @ 2018-07-09  3:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jiewen Yao

The commit will remove the dependency on file:
Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h

The IPMI header files within:
edk2/MdePkg/Include/IndustryStandard/

already have the structure definitions in this IpmiEx.h file.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c
index 143618d464..62114fb3e5 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c
+++ b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c
@@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/IpmiPlatformHookLib.h>
 
 #include <IndustryStandard/Ipmi.h>
-#include <IpmiEx.h>
 
 #include "KcsBmc.h"
 
@@ -142,7 +141,7 @@ UpdateBmcStatusOnResponse (
       IpmiInstance->BmcStatus = EFI_BMC_HARDFAIL;
     } else {
       BmcInfo = (VOID *)IpmiResponse->ResponseData;
-      if (BmcInfo->UpdateMode) {
+      if (BmcInfo->FirmwareRev1.Bits.UpdateMode) {
         IpmiInstance->BmcStatus = EFI_BMC_UPDATE_IN_PROGRESS;
       }
     }
-- 
2.12.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH edk2-platforms\devel-MinPlatform 4/4] AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h
  2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
                   ` (2 preceding siblings ...)
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 3/4] PurleyOpenBoardPkg Ipmi: " Hao Wu
@ 2018-07-09  3:09 ` Hao Wu
  2018-07-09  3:31 ` [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Yao, Jiewen
  4 siblings, 0 replies; 6+ messages in thread
From: Hao Wu @ 2018-07-09  3:09 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jiewen Yao

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h | 296 --------------------
 1 file changed, 296 deletions(-)

diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h
deleted file mode 100644
index 788ad40890..0000000000
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h
+++ /dev/null
@@ -1,296 +0,0 @@
-/** @file
-  IPMI 2.0 definitions from the IPMI Specification Version 2.0, Revision 1.1.
-
-  See IPMI specification, Appendix G, Command Assignments
-  and Appendix H, Sub-function Assignments.
-
-  Copyright (c) 1999 - 2015, Intel Corporation. All rights reserved.<BR>
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD License
-  which accompanies this distribution.  The full text of the license may be found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-**/
-
-#ifndef _IPMI_EX_H_
-#define _IPMI_EX_H_
-
-#pragma pack(1)
-
-//
-// Generic completion Codes
-//
-#define IPMI_COMP_CODE_NORMAL                  0x00
-#define IPMI_COMP_CODE_NODE_BUSY               0xC0
-#define IPMI_COMP_CODE_TIMEOUT                 0xC3
-#define IPMI_COMP_CODE_OUT_OF_SPACE            0xC4
-#define IPMI_COMP_CODE_OUT_OF_RANGE            0xC9
-#define IPMI_COMP_CODE_CMD_RESP_NOT_PROVIDED   0xCE
-#define IPMI_COMP_CODE_FAIL_DUP_REQUEST        0xCF
-#define IPMI_COMP_CODE_SDR_REP_IN_UPDATE_MODE  0xD0
-#define IPMI_COMP_CODE_DEV_IN_FW_UPDATE_MODE   0xD1
-#define IPMI_COMP_CODE_BMC_INIT_IN_PROGRESS    0xD2
-#define IPMI_COMP_CODE_UNSPECIFIED             0xFF
-
-//
-// Watchdog timer 
-//
-#define IPMI_WATCHDOG_TIMER_BIOS_FRB2  0x1
-#define IPMI_WATCHDOG_TIMER_BIOS_POST  0x2
-#define IPMI_WATCHDOG_TIMER_OS_LOADER  0x3
-#define IPMI_WATCHDOG_TIMER_SMS        0x4
-
-#define IPMI_WATCHDOG_TIMER_ACTION_NO_ACTION   0x0
-#define IPMI_WATCHDOG_TIMER_ACTION_HARD_RESET  0x1
-#define IPMI_WATCHDOG_TIMER_ACTION_POWER_DONW  0x2
-#define IPMI_WATCHDOG_TIMER_ACTION_POWER_CYCLE 0x3
-
-//
-// Device and Messaging
-//
-
-typedef struct {
-  UINT8  EnableReceiveMessageQueueInterrupt : 1;
-  UINT8  EnableEventMessageBufferFullInterrupt : 1;
-  UINT8  EnableEventMessageBuffer : 1;
-  UINT8  EnableSystemEventLogging : 1;
-  UINT8  Reserved : 1;
-  UINT8  Oem0Enable : 1;
-  UINT8  Oem1Enable : 1;
-  UINT8  Oem2Enable : 1;
-} IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ReceiveMessageQueueInterrupt : 1;
-  UINT8  EventMessageBufferFullInterrupt : 1;
-  UINT8  EventMessageBuffer : 1;
-  UINT8  SystemEventLogging : 1;
-  UINT8  Reserved : 1;
-  UINT8  Oem0Enable : 1;
-  UINT8  Oem1Enable : 1;
-  UINT8  Oem2Enable : 1;
-} IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE;
-
-typedef struct {
-  UINT8  ClearReceiveMessageQueue : 1;
-  UINT8  ClearEventMessageBuffer : 1;
-  UINT8  Reserved0 : 1;
-  UINT8  ClearWatchdogPerTimeoutInterruptFlag : 1;
-  UINT8  Reserved : 1;
-  UINT8  ClearOem0Enable : 1;
-  UINT8  ClearOem1Enable : 1;
-  UINT8  ClearOem2Enable : 1;
-} IPMI_CLEAR_MESSAGE_FLAGS_REQUEST;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ReceiveMessageAvailable : 1;
-  UINT8  EventMessageBufferFull : 1;
-  UINT8  Reserved0 : 1;
-  UINT8  WatchdogPerTimeoutInterruptOccurred : 1;
-  UINT8  Reserved : 1;
-  UINT8  Oem0DataAvailable : 1;
-  UINT8  Oem1DataAvailable : 1;
-  UINT8  Oem2DataAvailable : 1;
-} IPMI_GET_MESSAGE_FLAGS_RESPONSE;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ChannelNumber : 4;
-  UINT8  InferredPrivilegeLevel : 4;
-  UINT8  MessageData[];
-} IPMI_GET_MESSAGE_RESPONSE;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ChannelNumber : 4;
-  UINT8  Authentication : 1;
-  UINT8  Encryption : 1;
-  UINT8  Tracking : 2;
-  UINT8  MessageData[];
-} IPMI_SEND_MESSAGE_REQUEST;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ResponseData[];
-} IPMI_SEND_MESSAGE_RESPONSE;
-
-//
-// SOL
-//
-
-typedef struct {
-  UINT8  SessionState : 4;
-  UINT8  Reserved : 4;
-  UINT8  PayloadInstance;
-  UINT8  FormatVersionMajor; // 1
-  UINT8  FormatVersionMinor; // 0
-} IPMI_SOL_ACTIVATING_REQUEST;
-
-typedef struct {
-  UINT8  ChannelNumber : 4;
-  UINT8  Reserved : 4;
-  UINT8  ParameterSelector;
-  UINT8  ParameterData[1];
-} IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST;
-
-typedef struct {
-  UINT8  ChannelNumber : 4;
-  UINT8  Reserved : 3;
-  UINT8  GetParameter : 1;
-  UINT8  ParameterSelector;
-  UINT8  SetSelector;
-  UINT8  BlockSelector;
-} IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST;
-
-typedef struct {
-  UINT8  CompletionCode;
-  UINT8  ParameterRevision;
-  UINT8  ParameterData[1];
-} IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE;
-
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SET_IN_PROGRESS       0
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_ENABLE            1
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_AUTHENTICATION    2
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_CHARACTER_PARAM   3
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_RETRY             4
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_NV_BIT_RATE       5
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_VOLATILE_BIT_RATE 6
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_PAYLOAD_CHANNEL   7
-#define IPMI_SOL_CONFIGURATION_PARAMETER_SOL_PAYLOAD_PORT      8
-
-//
-// Chasis
-//
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   CapabilitiesFlags;
-  UINT8   ChassisFruInfoDeviceAddress;
-  UINT8   ChassisSDRDeviceAddress;
-  UINT8   ChassisSELDeviceAddress;
-  UINT8   ChassisSystemManagementDeviceAddress;
-  UINT8   ChassisBridgeDeviceAddress;
-} IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   CurrentPowerState;
-  UINT8   LastPowerEvent;
-  UINT8   MiscChassisState;
-  UINT8   FrontPanelButtonCapabilities;
-} IPMI_GET_CHASSIS_STATUS_RESPONSE;
-
-typedef struct {
-  UINT8   ChassisControl:4;
-  UINT8   Reserved:4;
-} IPMI_CHASSIS_CONTROL_REQUEST;
-
-typedef struct {
-  UINT8   PowerRestorePolicy:3;
-  UINT8   Reserved:5;
-} IPMI_SET_POWER_RESTORE_POLICY_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   PowerRestorePolicySupport;
-} IPMI_SET_POWER_RESTORE_POLICY_RESPONSE;
-
-//
-// FRU
-//
-
-typedef struct {
-  UINT8  DeviceId;
-} IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT16  InventoryAreaSize;
-  UINT8   AccessType;
-} IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE;
-
-typedef struct {
-  UINT8   DeviceId;
-  UINT16  InventoryOffset;
-  UINT8   CountToRead;
-} IPMI_READ_FRU_DATA_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   CountReturned;
-  UINT8   Data[];
-} IPMI_READ_FRU_DATA_RESPONSE;
-
-typedef struct {
-  UINT8   DeviceId;
-  UINT16  InventoryOffset;
-  UINT8   Data[];
-} IPMI_WRITE_FRU_DATA_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   CountWritten;
-} IPMI_WRITE_FRU_DATA_RESPONSE;
-
-//
-// SEL
-//
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT16  NextSelRecord;
-  UINT8   RecordData[];
-} IPMI_GET_SEL_ENTRY_RESPONSE;
-
-typedef struct {
-  UINT8   RecordData[16];
-} IPMI_ADD_SEL_ENTRY_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT16  RecordId;
-} IPMI_ADD_SEL_ENTRY_RESPONSE;
-
-typedef struct {
-  UINT16  ReservationId;
-  UINT16  RecordId;
-  UINT8   OffsetIntoRecord;
-  UINT8   InProgress;
-  UINT8   RecordData[];
-} IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT16  RecordId;
-} IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT8   ErasureProgress;
-} IPMI_CLEAR_SEL_RESPONSE;
-
-typedef struct {
-  UINT8   CompletionCode;
-  UINT32  Timestamp;
-} IPMI_GET_SEL_TIME_RESPONSE;
-
-typedef struct {
-  UINT32  Timestamp;
-} IPMI_SET_SEL_TIME_REQUEST;
-
-//
-// SDR
-//
-typedef struct {
-  UINT8   CompletionCode;
-  UINT16  RecordId;
-  UINT8   RecordData[];
-} IPMI_GET_SDR_RESPONSE;
-
-#pragma pack()
-
-#endif
\ No newline at end of file
-- 
2.12.0.windows.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update
  2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
                   ` (3 preceding siblings ...)
  2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 4/4] AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h Hao Wu
@ 2018-07-09  3:31 ` Yao, Jiewen
  4 siblings, 0 replies; 6+ messages in thread
From: Yao, Jiewen @ 2018-07-09  3:31 UTC (permalink / raw)
  To: Wu, Hao A; +Cc: edk2-devel@lists.01.org

Series reviewed by Jiewen.yao@intel.com

thank you!
Yao, Jiewen


> 在 2018年7月8日,下午7:09,Wu, Hao A <hao.a.wu@intel.com> 写道:
> 
> The series updates the IPMI-related codes to stop using the file
> 'IpmiEx.h', and to use the IPMI headers within edk2\MdePkg.
> 
> Test performed:
> MinPurley VS2015 build pass.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> 
> Hao Wu (4):
>  AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros
>  AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg
>  PurleyOpenBoardPkg Ipmi: Update codes for header changes in MdePkg
>  AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h
> 
> Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c                                     |   4 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c                                          |  11 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c                                          |   5 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h                                      | 296 --------------------
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h                      |   3 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c                                     |  11 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c                                |  10 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c                                |  10 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c       |   1 -
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c   |   1 -
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c   |   7 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c |   1 -
> Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c                     |   1 -
> Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c                                         |   7 +-
> Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c                                 |  11 +-
> Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c              |   3 +-
> 16 files changed, 43 insertions(+), 339 deletions(-)
> delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h
> 
> -- 
> 2.12.0.windows.1
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-09  3:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-09  3:09 [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Hao Wu
2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 1/4] AdvancedFeaturePkg/IpmiFru.c: Use 'DEBUG_' prefix for debug macros Hao Wu
2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 2/4] AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg Hao Wu
2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 3/4] PurleyOpenBoardPkg Ipmi: " Hao Wu
2018-07-09  3:09 ` [PATCH edk2-platforms\devel-MinPlatform 4/4] AdvancedFeaturePkg/Ipmi: Delete IpmiEx.h Hao Wu
2018-07-09  3:31 ` [PATCH edk2-platforms\devel-MinPlatform 0/4] IPMI codes update Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox