From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BEB57202E53F3 for ; Mon, 9 Jul 2018 02:45:18 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id g6-v6so1347318wrp.0 for ; Mon, 09 Jul 2018 02:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mbN3jQ5jJbY/iXfoJdLPn/zhHaFhwqaut2szBmYe6DI=; b=UkU9V+c3oz52rkQ/huOwCxjP24syuYyAe08nomdsgYEnFaMPQOyX3L8Sc4U+RSJnJy YXE+U7ozeyI2MUyyEXE6j2swfS/iaHBdcjWa0SH6MiWM+f65mxrDJnx6MzZoBtCHDUVO Ck9TecbW4DbbRqlgs2sQPkoNqJpFTP3WOwjOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mbN3jQ5jJbY/iXfoJdLPn/zhHaFhwqaut2szBmYe6DI=; b=VHyVviUgLRyDCN0wVLqlnBGRoprbaaSDmVCzJHdPcD9mr6JztYr2e5julF7qZhpB6i OnJccKY98a6IJ7jfqtOmYosxvTRD+e+FONI5NdnDsVkeFT6sAk13819hO4T1ruktBYIs vdltAHL70QTUsNkKB7e6UrRXvz3FIkPdO375POEVhSjecH4MP0Jv2VFXY3QltkBofWzI dNJ0kdLMCttAs52274akFD5CicudAE9F9QMELL8m6zYcOEAGBJ+I42jOvSJIYJ2jP/Vs RK6McwEFBTgoLZSQ9xh0qW4hUUF8cAXT1Mrwrxih1wbUUcsW5hRifLYMv04M15XZ2441 ImDw== X-Gm-Message-State: APt69E1Lxk6Uep2Q3Urv88LjQOyLDwj0CYu+fvVim0jztcB31zzgr/Jg tbMdDzEl3M+DoXse3FTGxE6j8A== X-Google-Smtp-Source: AAOMgpc7gFSxg9RXmMLR7ys9fHiRDP4C69LV0oC29cvj22zYUWf/cIZZQnykqjnNwxLjz+m+fqsZrA== X-Received: by 2002:adf:e14a:: with SMTP id f10-v6mr13425724wri.42.1531129516422; Mon, 09 Jul 2018 02:45:16 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i95-v6sm18111327wri.63.2018.07.09.02.45.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 02:45:15 -0700 (PDT) Date: Mon, 9 Jul 2018 10:45:13 +0100 From: Leif Lindholm To: Sughosh Ganu Cc: Supreeth Venkatesh , edk2-devel@lists.01.org Message-ID: <20180709094513.kkjbxhwogcm27fi4@bivouac.eciton.net> References: <1530611715-9819-1-git-send-email-supreeth.venkatesh@arm.com> <1530611715-9819-3-git-send-email-supreeth.venkatesh@arm.com> <20180703141206.xyqthexlyucxknoo@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 2/6] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 09:45:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 09, 2018 at 02:05:32PM +0530, Sughosh Ganu wrote: > hi Leif, > > On Tue, Jul 3, 2018 at 7:42 PM, Leif Lindholm wrote: > > On Tue, Jul 03, 2018 at 03:25:11PM +0530, Supreeth Venkatesh wrote: > >> PI v1.5 Specification Volume 4 defines Management Mode Core Interface > >> and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > >> means of communicating between drivers outside of MM and MMI > >> handlers inside of MM. > >> > >> This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE runtime > >> driver for AARCH64 platforms. It uses SMCs allocated from the standard > >> SMC range defined in DEN0060A_ARM_MM_Interface_Specification.pdf > > > > I would prefer the document to be referred to by its official name and > > its document number: > > ARM Management Mode Interface Specification (ARM DEN0060A) > > > >> to communicate with the standalone MM environment in the secure world. > >> > >> This patch also adds the MM Communication driver (.inf) file to > >> define entry point for this driver and other compile > >> related information the driver needs. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Achin Gupta > >> Signed-off-by: Supreeth Venkatesh > > > > Oh, and only one Signed-off-by per patch please. > > If authorship is to be indicated, ensure that's correct in git before > > calling format-patch. > > Supreeth has moved onto some other work, hence I will be working on > the upstreaming of these patches henceforth. Splendid, welcome aboard. > Will handle your comments > on all the patches and send an updated version. Regarding the > inclusion of a single Signed-off-By, i have a doubt. Work on these > patches was initially done by Achin, and then Supreeth. I will be > handling your review comments and posting the updated version. You > have posted a comment saying that we can have only a single s-o-b in > any given patch. In such a scenario, how can we attribute the work > done by all the engineers for these patches. Can you please let me > know on this. As per my understanding, other projects do allow > multiple s-o-b's per patch. Thanks. We do permit multiple s-o-b. When multiple developers are working together in public, adding non-trivial bits to a patch in flight, you can add multiple s-o-b. What is not appropriate is to post a patch containing company-internal details about who handled the patch before it was sent public. The signed-off-by is a statement regarding the suitability of the contribution - it is not attribution. The Author field is the only attribution. Regards, Leif p.s. I presume you're taking the set over because you work for ARM - so please communicate with the mailing list from your @arm.com account.