* [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout
@ 2018-07-10 13:28 Liming Gao
2018-07-12 7:03 ` Yao, Jiewen
0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2018-07-10 13:28 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
timeout command may not work well in some environment.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
index a6e0605..4c4aec3 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
@@ -111,13 +111,13 @@ echo.
echo --------------------------------------------------------------------
echo.
call postbuild.bat
+if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
timeout 1
echo --------------------------------------------------------------------
echo.
echo PostBuild End
echo.
echo --------------------------------------------------------------------
-if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
echo %date% %time%
echo.
@@ -128,7 +128,6 @@ echo Purley Build End
echo.
echo --------------------------------------------------------------------------------------------
-if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
:done
endlocal & EXIT /b %SCRIPT_ERROR%
--
2.10.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout
2018-07-10 13:28 [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout Liming Gao
@ 2018-07-12 7:03 ` Yao, Jiewen
0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2018-07-12 7:03 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, July 10, 2018 9:29 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg:
> Update batch file not to check the return value of timeout
>
> timeout command may not work well in some environment.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> index a6e0605..4c4aec3 100644
> --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat
> @@ -111,13 +111,13 @@ echo.
> echo --------------------------------------------------------------------
> echo.
> call postbuild.bat
> +if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
> timeout 1
> echo --------------------------------------------------------------------
> echo.
> echo PostBuild End
> echo.
> echo --------------------------------------------------------------------
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
>
> echo %date% %time%
> echo.
> @@ -128,7 +128,6 @@ echo Purley Build
> End
> echo.
> echo --------------------------------------------------------------------------------------------
>
> -if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL%
> :done
> endlocal & EXIT /b %SCRIPT_ERROR%
>
> --
> 2.10.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-12 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10 13:28 [Patch edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Update batch file not to check the return value of timeout Liming Gao
2018-07-12 7:03 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox