From: BobCF <bob.c.feng@intel.com>
To: edk2-devel@lists.01.org
Cc: "bob.c.feng@intel.com" <bob.c.feng@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH] BaseTool: Fixed the incorrect cache key.
Date: Wed, 11 Jul 2018 00:19:24 +0800 [thread overview]
Message-ID: <20180710161924.116716-1-bob.c.feng@intel.com> (raw)
From: "bob.c.feng@intel.com" <bob.c.feng@intel.com>
This patch is to fix the incorrect cache key of
skip ModuleAutoGen cache.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py
index b27290989e..54c6b7330f 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -4320,7 +4320,7 @@ class ModuleAutoGen(AutoGen):
# If any source file is newer than the module than we cannot skip
#
def CanSkip(self):
- if self.MetaFile in GlobalData.gSikpAutoGenCache:
+ if self.MakeFileDir in GlobalData.gSikpAutoGenCache:
return True
if not os.path.exists(self.GetTimeStampPath()):
return False
@@ -4340,7 +4340,7 @@ class ModuleAutoGen(AutoGen):
ModuleAutoGen.TimeDict[source] = os.stat(source)[8]
if ModuleAutoGen.TimeDict[source] > DstTimeStamp:
return False
- GlobalData.gSikpAutoGenCache.add(self.MetaFile)
+ GlobalData.gSikpAutoGenCache.add(self.MakeFileDir)
return True
def GetTimeStampPath(self):
--
2.18.0.windows.1
next reply other threads:[~2018-07-10 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 16:19 BobCF [this message]
2018-07-12 0:41 ` [PATCH] BaseTool: Fixed the incorrect cache key Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710161924.116716-1-bob.c.feng@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox