From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=bob.c.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4726209603EB for ; Tue, 10 Jul 2018 09:20:16 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 09:20:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,335,1526367600"; d="scan'208";a="55456579" Received: from shwdeopenpsi105.ccr.corp.intel.com ([10.239.9.110]) by orsmga007.jf.intel.com with ESMTP; 10 Jul 2018 09:20:15 -0700 From: BobCF To: edk2-devel@lists.01.org Cc: "bob.c.feng@intel.com" , Liming Gao Date: Wed, 11 Jul 2018 00:19:24 +0800 Message-Id: <20180710161924.116716-1-bob.c.feng@intel.com> X-Mailer: git-send-email 2.16.2.windows.1 Subject: [PATCH] BaseTool: Fixed the incorrect cache key. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 16:20:17 -0000 From: "bob.c.feng@intel.com" This patch is to fix the incorrect cache key of skip ModuleAutoGen cache. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index b27290989e..54c6b7330f 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -4320,7 +4320,7 @@ class ModuleAutoGen(AutoGen): # If any source file is newer than the module than we cannot skip # def CanSkip(self): - if self.MetaFile in GlobalData.gSikpAutoGenCache: + if self.MakeFileDir in GlobalData.gSikpAutoGenCache: return True if not os.path.exists(self.GetTimeStampPath()): return False @@ -4340,7 +4340,7 @@ class ModuleAutoGen(AutoGen): ModuleAutoGen.TimeDict[source] = os.stat(source)[8] if ModuleAutoGen.TimeDict[source] > DstTimeStamp: return False - GlobalData.gSikpAutoGenCache.add(self.MetaFile) + GlobalData.gSikpAutoGenCache.add(self.MakeFileDir) return True def GetTimeStampPath(self): -- 2.18.0.windows.1