From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 77FDD2096DCF4 for ; Fri, 13 Jul 2018 03:12:09 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r16-v6so24550210wrt.11 for ; Fri, 13 Jul 2018 03:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xHTwT+Zcq07Av66COGCr0qMhAk3BSi1CwBBeW3vCsz4=; b=D6q4yDJjPIVJ+3PKyuevmHlP+ayjgrR7hn2PWbGAsjkK+hdfa6T4YId3sXfqUNOwTX mkd7O+RVShTrL8aozD2EhOrW7cp0hIXB75x+u0CLr842e6tYrZmUkixuIlt3yd/eakFV +ifDrXj37bgsIXxsSCy6YnksWvaWNTEuXgRwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xHTwT+Zcq07Av66COGCr0qMhAk3BSi1CwBBeW3vCsz4=; b=V9NQRKgCsUqiAq9u1BqMQQWvqVv10OmSggG0x7wtBtDWv4BMJxYRUCIKiNTx1lj3Y8 j9mG4cBak0EOBw2XYhrrmrE0uAz+ORLJgQkeVtm2m4nFFzgrWKhj9fKAVG5DmeJ7jqKq 3MY+ztJ3JoZOP8xpoUsN3fBa2d0SaXTjDeyYUzr3ax/wyiJkLh4y9a7szgrtMlQ3TS5e qAnbWT4GKFsneWyHkt9yYLUMCF93B2fGK3qf1FJjS9BxloBsBROyMTrRunkvHVgQNrNi dGTgoYVTLlHOacL67HmOKNUBIlHZLyYxJsj+7GFTo4FOIlvIrQsWsfxekBgPaI+5CE4j O/HQ== X-Gm-Message-State: AOUpUlGK8/H/A3ujez47Ckt1vWCI3v+oZ2cCIJEF1XYzUZTOL1m9zvLF hyuiEEwVDDTodu5a6xGQm3kXRA== X-Google-Smtp-Source: AAOMgpd8W9o7i1XRWau2OiK8gslYs4bdPFnJ2DZUtBag/m0F2wppnlx5M3Xc7N2Jv2tXa5dLKcCqGw== X-Received: by 2002:adf:ffc7:: with SMTP id x7-v6mr4563535wrs.137.1531476727700; Fri, 13 Jul 2018 03:12:07 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t6-v6sm6828242wrn.97.2018.07.13.03.12.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jul 2018 03:12:06 -0700 (PDT) Date: Fri, 13 Jul 2018 11:12:05 +0100 From: Leif Lindholm To: AlexeiFedorov Cc: edk2-devel@lists.01.org, Ard.Biesheuvel@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Evan.Lloyd@arm.com, Sami.Mujawar@arm.com, Jaben Carsey , Ruiyu Ni Message-ID: <20180713101205.wiff7szhszo3kizs@bivouac.eciton.net> References: <20180713100721.19224-1-Alexei.Fedorov@arm.com> MIME-Version: 1.0 In-Reply-To: <20180713100721.19224-1-Alexei.Fedorov@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 10:12:09 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline + Jaben, Ruiyu. On Fri, Jul 13, 2018 at 11:07:21AM +0100, AlexeiFedorov wrote: > This patch fixes VS2017 compilation errors for > UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c > and > UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c > reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=985 > https://bugzilla.tianocore.org/show_bug.cgi?id=986 > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > --- > All the changes can be seen at > https://github.com/AlexeiFedorov/edk2/tree/298_fix_acpiview_v1 > > Notes: > v1: > - GtdtParser.c DumpFTBlock() function: > change UINT16 type of Length parameter to UINT32 > change UINT16 type of GTBlockTimerLength variable to UINT32 > - XsdtParser.c ParseAcpiXsdt() function: > change name of local variable Ptr to SignaturePtr > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 4 ++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > index 3a3cee948ad8cd35ef3a6e13fec9d44300dbe73f..0ab460b02c9e062ac181e42e7e77f875a40c86dc 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > @@ -161,12 +161,12 @@ STATIC > VOID > DumpGTBlock ( > IN UINT8* Ptr, > - IN UINT16 Length > + IN UINT32 Length > ) > { > UINT32 Index; > UINT32 Offset; > - UINT16 GTBlockTimerLength; > + UINT32 GTBlockTimerLength; > > Offset = ParseAcpi ( > TRUE, > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > index 99521cd67a714065c2eb9e4e5ec0f2e21f4c9da9..014b6259aa9cfe4093b6f19d4ff0be1e8096fd9b 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > @@ -96,7 +96,7 @@ ParseAcpiXsdt ( > CONST UINT8* Revision; > > if ((UINT64*)(UINTN)(*TablePointer) != NULL) { > - UINT8* Ptr; > + UINT8* SignaturePtr; > > ParseAcpiHeader ( > (UINT8*)(UINTN)(*TablePointer), > @@ -105,17 +105,17 @@ ParseAcpiXsdt ( > &Revision > ); > > - Ptr = (UINT8*)Signature; > + SigPtr = (UINT8*)Signature; > > UnicodeSPrint ( > Buffer, > sizeof (Buffer), > L"Entry[%d] - %c%c%c%c", > EntryIndex++, > - Ptr[0], > - Ptr[1], > - Ptr[2], > - Ptr[3] > + SignaturePtr[0], > + SignaturePtr[1], > + SignaturePtr[2], > + SignaturePtr[3] > ); > } else { > UnicodeSPrint ( > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >