From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=alexei.fedorov@arm.com; receiver=edk2-devel@lists.01.org Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0C362098844A for ; Fri, 13 Jul 2018 04:05:45 -0700 (PDT) Received: from E107992.Emea.Arm.com (e107992.emea.arm.com [10.1.211.7]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w6DB5aaZ003730; Fri, 13 Jul 2018 12:05:36 +0100 From: AlexeiFedorov To: edk2-devel@lists.01.org Cc: Ard.Biesheuvel@linaro.org, Leif.Lindholm@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com, Jaben.Carsey@intel.com, Ruiyu.Ni@intel.com, Evan.Lloyd@arm.com, Sami.Mujawar@arm.com Date: Fri, 13 Jul 2018 12:05:36 +0100 Message-Id: <20180713110536.30792-2-Alexei.Fedorov@arm.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180713110536.30792-1-Alexei.Fedorov@arm.com> References: <20180713110536.30792-1-Alexei.Fedorov@arm.com> Subject: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 11:05:46 -0000 Please find v2 patch which corrects local variable name SigPtr to SignaturePtr. This patch fixes VS2017 compilation errors for UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c and UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c reported in https://bugzilla.tianocore.org/show_bug.cgi?id=985 https://bugzilla.tianocore.org/show_bug.cgi?id=986 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alexei Fedorov --- All the changes can be seen at https://github.com/AlexeiFedorov/edk2/tree/298_fix_acpiview_v2 Notes: v1: - GtdtParser.c DumpFTBlock() function: change UINT16 type of Length parameter to UINT32 change UINT16 type of GTBlockTimerLength variable to UINT32 - XsdtParser.c ParseAcpiXsdt() function: change name of local variable Ptr to SignaturePtr v2: - XsdtParser.c ParseAcpiXsdt() function: correct name of local variable SigPtr to SignaturePtr ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c index 014b6259aa9cfe4093b6f19d4ff0be1e8096fd9b..a5e1412484b56258c40e0cb4d795157ffbce6826 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c @@ -105,7 +105,7 @@ ParseAcpiXsdt ( &Revision ); - SigPtr = (UINT8*)Signature; + SignaturePtr = (UINT8*)Signature; UnicodeSPrint ( Buffer, -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'