* [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf"
@ 2018-07-18 12:52 Laszlo Ersek
2018-07-18 14:02 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2018-07-18 12:52 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Ard Biesheuvel, Jordan Justen, Steven Shi
None of the source files referenced by "AcpiPlatformDxe.inf" #include
"MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
therein, so drop DxeServicesLib from [LibraryClasses].
"AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI
tables built into the firmware image from under "OvmfPkg/AcpiTables/", in
case dynamically generated ACPI tables are not available from Xen or QEMU.
For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for
that in [Protocols].
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
Reported-by: Steven Shi <steven.shi@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Notes:
Repo: https://github.com/lersek/edk2.git
Branch: acpiplatform_redundant_tiano_1014
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
index edc192e03d73..8440e7b343d8 100644
--- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
+++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
@@ -46,7 +46,6 @@ [Packages]
[LibraryClasses]
UefiLib
- DxeServicesLib
PcdLib
BaseMemoryLib
DebugLib
@@ -62,6 +61,7 @@ [LibraryClasses]
[Protocols]
gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED
+ gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
[Guids]
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf"
2018-07-18 12:52 [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf" Laszlo Ersek
@ 2018-07-18 14:02 ` Ard Biesheuvel
2018-07-19 14:56 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-07-18 14:02 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, Jordan Justen, Steven Shi
On 18 July 2018 at 21:52, Laszlo Ersek <lersek@redhat.com> wrote:
> None of the source files referenced by "AcpiPlatformDxe.inf" #include
> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
> therein, so drop DxeServicesLib from [LibraryClasses].
>
> "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI
> tables built into the firmware image from under "OvmfPkg/AcpiTables/", in
> case dynamically generated ACPI tables are not available from Xen or QEMU.
> For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for
> that in [Protocols].
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Steven Shi <steven.shi@intel.com>
> Reported-by: Steven Shi <steven.shi@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>
> Notes:
> Repo: https://github.com/lersek/edk2.git
> Branch: acpiplatform_redundant_tiano_1014
>
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> index edc192e03d73..8440e7b343d8 100644
> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> @@ -46,7 +46,6 @@ [Packages]
>
> [LibraryClasses]
> UefiLib
> - DxeServicesLib
> PcdLib
> BaseMemoryLib
> DebugLib
> @@ -62,6 +61,7 @@ [LibraryClasses]
>
> [Protocols]
> gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
> gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
>
> [Guids]
> --
> 2.14.1.3.gb7cf6e02401b
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf"
2018-07-18 14:02 ` Ard Biesheuvel
@ 2018-07-19 14:56 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2018-07-19 14:56 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Jordan Justen, edk2-devel-01
On 07/18/18 16:02, Ard Biesheuvel wrote:
> On 18 July 2018 at 21:52, Laszlo Ersek <lersek@redhat.com> wrote:
>> None of the source files referenced by "AcpiPlatformDxe.inf" #include
>> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
>> therein, so drop DxeServicesLib from [LibraryClasses].
>>
>> "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI
>> tables built into the firmware image from under "OvmfPkg/AcpiTables/", in
>> case dynamically generated ACPI tables are not available from Xen or QEMU.
>> For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for
>> that in [Protocols].
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Steven Shi <steven.shi@intel.com>
>> Reported-by: Steven Shi <steven.shi@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thank you, commit a3fffb4f5e15.
Laszlo
>
>> ---
>>
>> Notes:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: acpiplatform_redundant_tiano_1014
>>
>> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> index edc192e03d73..8440e7b343d8 100644
>> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> @@ -46,7 +46,6 @@ [Packages]
>>
>> [LibraryClasses]
>> UefiLib
>> - DxeServicesLib
>> PcdLib
>> BaseMemoryLib
>> DebugLib
>> @@ -62,6 +61,7 @@ [LibraryClasses]
>>
>> [Protocols]
>> gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED
>> + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
>> gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
>>
>> [Guids]
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-19 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 12:52 [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf" Laszlo Ersek
2018-07-18 14:02 ` Ard Biesheuvel
2018-07-19 14:56 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox