public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Chao Zhang <chao.b.zhang@intel.com>,
	Eric Dong <eric.dong@intel.com>,
	Jaben Carsey <jaben.carsey@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Roman Bacik <roman.bacik@broadcom.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs
Date: Wed, 18 Jul 2018 22:50:37 +0200	[thread overview]
Message-ID: <20180718205043.17574-1-lersek@redhat.com> (raw)

Repo:   https://github.com/lersek/edk2.git
Branch: open_file_by_devpath_tiano_1008

This series addresses
<https://bugzilla.tianocore.org/show_bug.cgi?id=1008>.

In this version of the patch set, EfiOpenFileByDevicePath() is not added
to the FrameworkUefiLib instance. If FrameworkUefiLib actually needs a
definition of the function, I suggest that we add it once everybody
agrees on the implementation.

Tested with:

- MdeModulePkg/RamDiskDxe: created a virtual disk from an ISO file,
  using the HII form; browsed the disk contents from the UEFI shell.

- NetworkPkg/TlsAuthConfigDxe: loaded a CA certificate from a file via
  the HII form, successfully booted via HTTPSv4.

- SecurityPkg/SecureBootConfigDxe: enrolled
  "MicCorKEKCA2011_2011-06-24.crt", "MicCorUEFCA2011_2011-06-27.crt",
  and "MicWinProPCA2011_2011-10-19.crt", using the HII form; verified
  Secure Boot with a Fedora guest.

- ShellPkg/UefiShellLib: couldn't test the "old shell method" code path.
  Help with testing would be appreciated.

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Roman Bacik <roman.bacik@broadcom.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>

Thanks,
Laszlo

Laszlo Ersek (6):
  MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()
  MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib
    API
  NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with
    UefiLib API
  SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with
    UefiLib API
  ShellPkg/UefiShellLib: drop DeviceHandle param of
    ShellOpenFileByDevicePath()
  ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib
    API

 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf                                |   1 -
 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c                         | 140 ------------
 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c                                 |   2 +-
 MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h                                 |  39 ----
 MdePkg/Include/Library/UefiLib.h                                                     |  86 ++++++++
 MdePkg/Library/UefiLib/UefiLib.c                                                     | 226 ++++++++++++++++++++
 MdePkg/Library/UefiLib/UefiLib.inf                                                   |   1 +
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf                                     |   1 -
 NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c                                      | 141 +-----------
 SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf        |   1 -
 SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 151 +------------
 ShellPkg/Include/Library/ShellLib.h                                                  |   2 -
 ShellPkg/Library/UefiShellLib/UefiShellLib.c                                         | 118 +---------
 ShellPkg/Library/UefiShellLib/UefiShellLib.inf                                       |   3 +-
 14 files changed, 321 insertions(+), 591 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b



             reply	other threads:[~2018-07-18 20:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 20:50 Laszlo Ersek [this message]
2018-07-18 20:50 ` [PATCH 1/6] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath() Laszlo Ersek
2018-07-18 23:10   ` Yao, Jiewen
2018-07-19 10:47     ` Laszlo Ersek
2018-07-19 13:03       ` Yao, Jiewen
2018-07-24 17:20   ` Laszlo Ersek
2018-07-27  9:15   ` Ni, Ruiyu
2018-07-27  9:28   ` Ni, Ruiyu
2018-07-27 12:06     ` Laszlo Ersek
2018-07-30  1:54       ` Ni, Ruiyu
2018-07-30 14:13         ` Laszlo Ersek
2018-08-02  4:06           ` Gao, Liming
2018-08-02 14:45             ` Laszlo Ersek
2018-07-18 20:50 ` [PATCH 2/6] MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib API Laszlo Ersek
2018-07-19 10:36   ` Zeng, Star
2018-07-19 13:20     ` Laszlo Ersek
2018-07-20 10:22       ` Zeng, Star
2018-07-18 20:50 ` [PATCH 3/6] NetworkPkg/TlsAuthConfigDxe: " Laszlo Ersek
2018-07-24 17:20   ` Laszlo Ersek
2018-07-25  0:30   ` Wu, Jiaxin
2018-07-18 20:50 ` [PATCH 4/6] SecurityPkg/SecureBootConfigDxe: " Laszlo Ersek
2018-07-24  5:09   ` Zhang, Chao B
2018-07-18 20:50 ` [PATCH 5/6] ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath() Laszlo Ersek
2018-07-18 20:50 ` [PATCH 6/6] ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib API Laszlo Ersek
2018-07-18 21:15 ` [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs Carsey, Jaben
2018-07-19  0:07   ` Ard Biesheuvel
2018-07-19 10:38     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718205043.17574-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox