From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 496852097DD37 for ; Wed, 18 Jul 2018 13:50:50 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7044387A85; Wed, 18 Jul 2018 20:50:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-92.rdu2.redhat.com [10.10.120.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id C477A111CD4C; Wed, 18 Jul 2018 20:50:46 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Chao Zhang , Eric Dong , Jaben Carsey , Jiaxin Wu , Jiewen Yao , Liming Gao , Michael D Kinney , Roman Bacik , Ruiyu Ni , Siyuan Fu , Star Zeng Date: Wed, 18 Jul 2018 22:50:37 +0200 Message-Id: <20180718205043.17574-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 18 Jul 2018 20:50:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 18 Jul 2018 20:50:49 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 20:50:50 -0000 Repo: https://github.com/lersek/edk2.git Branch: open_file_by_devpath_tiano_1008 This series addresses . In this version of the patch set, EfiOpenFileByDevicePath() is not added to the FrameworkUefiLib instance. If FrameworkUefiLib actually needs a definition of the function, I suggest that we add it once everybody agrees on the implementation. Tested with: - MdeModulePkg/RamDiskDxe: created a virtual disk from an ISO file, using the HII form; browsed the disk contents from the UEFI shell. - NetworkPkg/TlsAuthConfigDxe: loaded a CA certificate from a file via the HII form, successfully booted via HTTPSv4. - SecurityPkg/SecureBootConfigDxe: enrolled "MicCorKEKCA2011_2011-06-24.crt", "MicCorUEFCA2011_2011-06-27.crt", and "MicWinProPCA2011_2011-10-19.crt", using the HII form; verified Secure Boot with a Fedora guest. - ShellPkg/UefiShellLib: couldn't test the "old shell method" code path. Help with testing would be appreciated. Cc: Chao Zhang Cc: Eric Dong Cc: Jaben Carsey Cc: Jiaxin Wu Cc: Jiewen Yao Cc: Liming Gao Cc: Michael D Kinney Cc: Roman Bacik Cc: Ruiyu Ni Cc: Siyuan Fu Cc: Star Zeng Thanks, Laszlo Laszlo Ersek (6): MdePkg/UefiLib: introduce EfiOpenFileByDevicePath() MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib API NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with UefiLib API SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with UefiLib API ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath() ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib API MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf | 1 - MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c | 140 ------------ MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 2 +- MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 39 ---- MdePkg/Include/Library/UefiLib.h | 86 ++++++++ MdePkg/Library/UefiLib/UefiLib.c | 226 ++++++++++++++++++++ MdePkg/Library/UefiLib/UefiLib.inf | 1 + NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 1 - NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 141 +----------- SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf | 1 - SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigFileExplorer.c | 151 +------------ ShellPkg/Include/Library/ShellLib.h | 2 - ShellPkg/Library/UefiShellLib/UefiShellLib.c | 118 +--------- ShellPkg/Library/UefiShellLib/UefiShellLib.inf | 3 +- 14 files changed, 321 insertions(+), 591 deletions(-) -- 2.14.1.3.gb7cf6e02401b