public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] UefiCpuPkg/MpInitLib: Remove useless code.
@ 2018-07-19 12:12 Eric Dong
  2018-07-19 13:08 ` Laszlo Ersek
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dong @ 2018-07-19 12:12 UTC (permalink / raw)
  To: edk2-devel; +Cc: Laszlo Ersek, Ruiyu Ni

Remove the useless code error added by change
58942277bcbf41abda5f6e3a1c89d571105d5983.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 06d966b227..e6e1b7c57d 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -44,21 +44,6 @@ EFI_PEI_NOTIFY_DESCRIPTOR        mS3SmmInitDoneNotifyDesc = {
   NotifyOnS3SmmInitDonePpi
 };
 
-/**
-  The function prototype for invoking a function on an Application Processor.
-
-  This definition is used by the UEFI MP Serices Protocol, and the
-  PI SMM System Table.
-
-  @param[in,out] Buffer  The pointer to private data buffer.
-**/
-VOID
-EmptyApProcedure (
-  IN OUT VOID * Buffer
-  )
-{
-}
-
 /**
   S3 SMM Init Done notification function.
 
-- 
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] UefiCpuPkg/MpInitLib: Remove useless code.
  2018-07-19 12:12 [Patch] UefiCpuPkg/MpInitLib: Remove useless code Eric Dong
@ 2018-07-19 13:08 ` Laszlo Ersek
  0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2018-07-19 13:08 UTC (permalink / raw)
  To: Eric Dong, edk2-devel; +Cc: Ruiyu Ni

On 07/19/18 14:12, Eric Dong wrote:
> Remove the useless code error added by change
> 58942277bcbf41abda5f6e3a1c89d571105d5983.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> index 06d966b227..e6e1b7c57d 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> @@ -44,21 +44,6 @@ EFI_PEI_NOTIFY_DESCRIPTOR        mS3SmmInitDoneNotifyDesc = {
>    NotifyOnS3SmmInitDonePpi
>  };
>  
> -/**
> -  The function prototype for invoking a function on an Application Processor.
> -
> -  This definition is used by the UEFI MP Serices Protocol, and the
> -  PI SMM System Table.
> -
> -  @param[in,out] Buffer  The pointer to private data buffer.
> -**/
> -VOID
> -EmptyApProcedure (
> -  IN OUT VOID * Buffer
> -  )
> -{
> -}
> -
>  /**
>    S3 SMM Init Done notification function.
>  
> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-19 13:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 12:12 [Patch] UefiCpuPkg/MpInitLib: Remove useless code Eric Dong
2018-07-19 13:08 ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox