public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: <edk2-devel@lists.01.org>
Cc: Eric Dong <eric.dong@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v2] UefiCpuPkg/MpInitLib: Fix build of Microcode
Date: Thu, 19 Jul 2018 16:52:20 +0100	[thread overview]
Message-ID: <20180719155220.7344-1-anthony.perard@citrix.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2BDD0B@SHSMSX104.ccr.corp.intel.com>

On Debian Jessie, this fail to build with:

/build/UefiCpuPkg/Library/MpInitLib/Microcode.c: In function 'MicrocodeDetect':
/build/UefiCpuPkg/Library/MpInitLib/Microcode.c:248:37: error: 'ProcessorFlags' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     CpuMpData->ProcessorFlags       = ProcessorFlags;
                                     ^

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v2:
        Fix coding style.

 UefiCpuPkg/Library/MpInitLib/Microcode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c
index efda143e67..cea1d34c0a 100644
--- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
+++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
@@ -87,6 +87,7 @@ MicrocodeDetect (
   }
 
   ExtendedTableLength = 0;
+  ProcessorFlags = 0;
   //
   // Here data of CPUID leafs have not been collected into context buffer, so
   // GetProcessorCpuid() cannot be used here to retrieve CPUID data.
-- 
Anthony PERARD



  reply	other threads:[~2018-07-19 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 14:58 [PATCH] UefiCpuPkg/MpInitLib: Fix build of Microcode Anthony PERARD
2018-07-19 15:27 ` Gao, Liming
2018-07-19 15:52   ` Anthony PERARD [this message]
2018-07-19 18:32     ` [PATCH v2] " Laszlo Ersek
2018-07-20  9:42       ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719155220.7344-1-anthony.perard@citrix.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox