From: Leif Lindholm <leif.lindholm@linaro.org>
To: Chris Co <Christopher.Co@microsoft.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver
Date: Tue, 31 Jul 2018 21:33:15 +0100 [thread overview]
Message-ID: <20180731203315.a334nudun6qu43ds@bivouac.eciton.net> (raw)
In-Reply-To: <20180717020529.19496-2-christopher.co@microsoft.com>
Hi Chris,
On Tue, Jul 17, 2018 at 02:05:42AM +0000, Chris Co wrote:
> This SdMmc driver adds support to boot Windows from SD and eMMC.
> It implements RPMB protocol support for eMMC, unique device path
> creation for each slot on the SD bus, high speed modes,
> eMMC bus width auto-detection, and support for high capacity
> SDXC cards.
>
> Derived from: EmbeddedPkg\Universal\MmcDxe
Hmm, I'm already slightly unhappy that we have duplication between
EmbeddedPkg and MdeModulePkg (not to mention the extra fork for
Marvell's XenonDxe).
I'm obviously keen for the added functionality to be available to more
platforms. Is there any way for this support to be added into either
the EmbeddedPkg or the MdeModulePkg driver?
(Deferring comments on specific content.)
/
Leif
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co <christopher.co@microsoft.com>
> ---
> Platform/Microsoft/Drivers/SdMmcDxe/BlockIo.c | 526 ++++++
> Platform/Microsoft/Drivers/SdMmcDxe/Debug.c | 358 ++++
> Platform/Microsoft/Drivers/SdMmcDxe/Protocol.c | 1774 ++++++++++++++++++++
> Platform/Microsoft/Drivers/SdMmcDxe/Protocol.h | 231 +++
> Platform/Microsoft/Drivers/SdMmcDxe/RpmbIo.c | 611 +++++++
> Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.c | 892 ++++++++++
> Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.h | 529 ++++++
> Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf | 50 +
> Platform/Microsoft/Drivers/SdMmcDxe/SdMmcHw.h | 506 ++++++
> Platform/Microsoft/Include/Protocol/RpmbIo.h | 262 +++
> Platform/Microsoft/Include/Protocol/Sdhc.h | 197 +++
> 11 files changed, 5936 insertions(+)
next prev parent reply other threads:[~2018-07-31 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 2:05 [PATCH edk2-platforms 0/3] Add Platform-Generic Packages to support Windows IoT Core Chris Co
2018-07-17 2:05 ` [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver Chris Co
2018-07-31 20:33 ` Leif Lindholm [this message]
2018-08-02 0:05 ` Chris Co
2018-08-02 11:38 ` Leif Lindholm
2018-07-17 2:05 ` [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg Chris Co
2018-07-31 20:38 ` Leif Lindholm
2018-07-17 2:05 ` [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library Chris Co
2018-07-31 20:56 ` Leif Lindholm
2018-07-31 20:59 ` Ard Biesheuvel
2018-08-01 9:39 ` Leif Lindholm
2018-08-02 1:27 ` Chris Co
2018-08-02 11:22 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731203315.a334nudun6qu43ds@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox