From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 46AA8210C123B for ; Tue, 31 Jul 2018 13:33:20 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id s12-v6so4504808wmc.0 for ; Tue, 31 Jul 2018 13:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=20aPpEYHm/FHBqsy7S1clrcgSAs8/JBjeQOvLxzzGas=; b=fnx7oPJw9fu2Pe133KH5CRxijMj88sqcxn1HdQrpacuhduMY7CZOvPOfAT8ArkqEI8 USQt2se2mTbBqygcjJ61IWn9f95s6Zjx2b3ySrLLRbq6xpr5UdOfpp1mJid9ONovzs1O 4vrhmZ5YdwJr9a+7/b4h+OgJHQ1KOxzVha5pQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=20aPpEYHm/FHBqsy7S1clrcgSAs8/JBjeQOvLxzzGas=; b=e6g/2oHIeceBGYTdKqMwE2EchVYYunp5NxOLdyAVFWuoDKgUsEJwewuXiG1716fyTB mX/jdUnO4s39GYJHr8P2wIoqW5qL3g4hRxoBplD8TGKvKot5l1dQIxYU9Af43M8kicIH PkRX+OXIQfTzsbdsW37yeDjvDdbV3szT0RCBngIAVLPrvdQZamlMZRVVCWcDej2Y7KRg AnIz8nV9C3NHduIWtFYc0mTJjG/6xFwL39VTMuJ8jMTy++kWn+Xw2dl0be9+AbUDt3AX ktx1sGal+KZYjctzlLSYx8x9V+BU+bcrq2FPDcEjwaWNJoXlUb9+WRSJbmWjF4mI8ovS fLYQ== X-Gm-Message-State: AOUpUlECV/1SO4EYROElU1nAymNbmF1BT6RtJgOuEq8C02GdI4VTUUfl 8CjqJnGOIx7p5/+oje8AEWPxSA== X-Google-Smtp-Source: AAOMgpdOlRbWesOt7wG4AJxv6c6JUwgQ59nv+S5BaR5kK322aNfPiEBGKGCD1WgxFZjZbNaIY6ZPrQ== X-Received: by 2002:a1c:e3d5:: with SMTP id a204-v6mr781916wmh.20.1533069197979; Tue, 31 Jul 2018 13:33:17 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b10-v6sm20102788wrp.49.2018.07.31.13.33.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 13:33:16 -0700 (PDT) Date: Tue, 31 Jul 2018 21:33:15 +0100 From: Leif Lindholm To: Chris Co Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Message-ID: <20180731203315.a334nudun6qu43ds@bivouac.eciton.net> References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-2-christopher.co@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20180717020529.19496-2-christopher.co@microsoft.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 20:33:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Chris, On Tue, Jul 17, 2018 at 02:05:42AM +0000, Chris Co wrote: > This SdMmc driver adds support to boot Windows from SD and eMMC. > It implements RPMB protocol support for eMMC, unique device path > creation for each slot on the SD bus, high speed modes, > eMMC bus width auto-detection, and support for high capacity > SDXC cards. > > Derived from: EmbeddedPkg\Universal\MmcDxe Hmm, I'm already slightly unhappy that we have duplication between EmbeddedPkg and MdeModulePkg (not to mention the extra fork for Marvell's XenonDxe). I'm obviously keen for the added functionality to be available to more platforms. Is there any way for this support to be added into either the EmbeddedPkg or the MdeModulePkg driver? (Deferring comments on specific content.) / Leif > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > --- > Platform/Microsoft/Drivers/SdMmcDxe/BlockIo.c | 526 ++++++ > Platform/Microsoft/Drivers/SdMmcDxe/Debug.c | 358 ++++ > Platform/Microsoft/Drivers/SdMmcDxe/Protocol.c | 1774 ++++++++++++++++++++ > Platform/Microsoft/Drivers/SdMmcDxe/Protocol.h | 231 +++ > Platform/Microsoft/Drivers/SdMmcDxe/RpmbIo.c | 611 +++++++ > Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.c | 892 ++++++++++ > Platform/Microsoft/Drivers/SdMmcDxe/SdMmc.h | 529 ++++++ > Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf | 50 + > Platform/Microsoft/Drivers/SdMmcDxe/SdMmcHw.h | 506 ++++++ > Platform/Microsoft/Include/Protocol/RpmbIo.h | 262 +++ > Platform/Microsoft/Include/Protocol/Sdhc.h | 197 +++ > 11 files changed, 5936 insertions(+)