From: Leif Lindholm <leif.lindholm@linaro.org>
To: Chris Co <Christopher.Co@microsoft.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg
Date: Tue, 31 Jul 2018 21:38:02 +0100 [thread overview]
Message-ID: <20180731203802.lmkz52ufrfvukvdd@bivouac.eciton.net> (raw)
In-Reply-To: <20180717020529.19496-3-christopher.co@microsoft.com>
On Tue, Jul 17, 2018 at 02:05:43AM +0000, Chris Co wrote:
> MsPkg is a collection of libraries and drivers that are specific
> to supporting Windows IoT Core but are not Platform/Silicon specific.
Minor comments inline.
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co <christopher.co@microsoft.com>
> ---
> Platform/Microsoft/MsPkg.dec | 42 ++++++++++++++++++++
> Platform/Microsoft/MsPkg.dsc | 32 +++++++++++++++
> 2 files changed, 74 insertions(+)
>
> diff --git a/Platform/Microsoft/MsPkg.dec b/Platform/Microsoft/MsPkg.dec
> new file mode 100644
> index 000000000000..ff17a016943c
> --- /dev/null
> +++ b/Platform/Microsoft/MsPkg.dec
> @@ -0,0 +1,42 @@
> +#/** @file
> +# A package that contains generic headers and components.
> +#
> +# Copyright (c) Microsoft Corporation. All rights reserved.
Please add a year to the copyright statement.
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.php
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +#**/
> +
> +[Defines]
> + DEC_SPECIFICATION = 0x00010005
0x0001001a is the current version, unless there's a specific reason
for holding back.
> + PACKAGE_NAME = MsPkg
> + PACKAGE_GUID = DC909FB7-F45E-4D7F-BF10-327BD9BFA21C
> + PACKAGE_VERSION = 0.1
> +
> +[Includes.common]
> + Include # Root include for the package
> +
> +[LibraryClasses.common]
> +
> +[Guids.common]
> + gMsPkgTokenSpaceGuid = { 0x3ecb4bb9, 0xb80a, 0x4efd, { 0x92, 0xb8, 0x3a, 0x16, 0xe0, 0xc8, 0x19, 0xb } }
> +
> +[PcdsFixedAtBuild.common]
> + gMsPkgTokenSpaceGuid.PcdSecureBootEnable|FALSE|BOOLEAN|0x00
> +
> + #
> + # The DevicePath to a partition on a writeable media used for logging and misc
> + # storage purposes. SD card DevicePath example:
> + # gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L"VenHw(AAFB8DAA-7340-43AC-8D49-0CCE14812489,03000000)/SD(0x0)/HD(1,MBR,0xAE420040,0x1000,0x20000)"
> + #
> + gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L""|VOID*|0x03
> +
> +[Protocols.common]
> + gEfiSdhcProtocolGuid = { 0x46055b0f, 0x992a, 0x4ad7, { 0x8f, 0x81, 0x14, 0x81, 0x86, 0xff, 0xdf, 0x72 } }
> + gEfiRpmbIoProtocolGuid = { 0xfbaee5b2, 0x8b0, 0x41b8, { 0xb0, 0xb0, 0x86, 0xb7, 0x2e, 0xed, 0x1b, 0xb6 } }
Please sort by name alphabetically where no other more logical
ordering exists.
> diff --git a/Platform/Microsoft/MsPkg.dsc b/Platform/Microsoft/MsPkg.dsc
> new file mode 100644
> index 000000000000..b43902cbb04d
> --- /dev/null
> +++ b/Platform/Microsoft/MsPkg.dsc
> @@ -0,0 +1,32 @@
> +## @file
> +# A package that contains generic headers and components.
> +#
> +# Copyright (c) Microsoft Corporation. All rights reserved.
Year.
> +#
> +# This program and the accompanying materials
> +# are licensed and made available under the terms and conditions of the BSD License
> +# which accompanies this distribution. The full text of the license may be found at
> +# http://opensource.org/licenses/bsd-license.
> +#
> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +##
> +
> +[Defines]
> + PLATFORM_NAME = MsPkg
> + PLATFORM_GUID = 2F78367E-9C74-4FBE-82E7-1D2DAAF18CC6
> + PLATFORM_VERSION = 0.01
> + DSC_SPECIFICATION = 0x00010005
0x0001001a
> + OUTPUT_DIRECTORY = Build/MsPkg
> + SUPPORTED_ARCHITECTURES = ARM|AARCH64
> + BUILD_TARGETS = DEBUG|RELEASE
DEBUG|NOOPT|RELEASE ?
/
Leif
> + SKUID_IDENTIFIER = DEFAULT
> +
> +[PcdsFeatureFlag]
> +
> +[PcdsFixedAtBuild]
> +
> +[LibraryClasses]
> +
> +[Components]
> + Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf
> --
> 2.16.2.gvfs.1.33.gf5370f1
>
next prev parent reply other threads:[~2018-07-31 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 2:05 [PATCH edk2-platforms 0/3] Add Platform-Generic Packages to support Windows IoT Core Chris Co
2018-07-17 2:05 ` [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver Chris Co
2018-07-31 20:33 ` Leif Lindholm
2018-08-02 0:05 ` Chris Co
2018-08-02 11:38 ` Leif Lindholm
2018-07-17 2:05 ` [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg Chris Co
2018-07-31 20:38 ` Leif Lindholm [this message]
2018-07-17 2:05 ` [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library Chris Co
2018-07-31 20:56 ` Leif Lindholm
2018-07-31 20:59 ` Ard Biesheuvel
2018-08-01 9:39 ` Leif Lindholm
2018-08-02 1:27 ` Chris Co
2018-08-02 11:22 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731203802.lmkz52ufrfvukvdd@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox