From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC579210C42C7 for ; Tue, 31 Jul 2018 13:38:07 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r16-v6so17955427wrt.11 for ; Tue, 31 Jul 2018 13:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GX/E2B+j8VwOwsyjvc/uCd82CwhwKvjTM6qXXIrVAE8=; b=APe7CisoqPQA1HtHNsItdkIJ4+x7le5m99D9bkX91cjheF3gchOrQlt/+MeoY+6aHx 9HyVvgql3f0tHkVjDpKsCRhZXvMl/Tcn9peNfXK7s1+3l3U7at8CGEgADRjGPFKUBQsB sUUcFHg5bPyvx08SRFHNez4nLPf4GKt0gAmWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GX/E2B+j8VwOwsyjvc/uCd82CwhwKvjTM6qXXIrVAE8=; b=HkGs6IEi7hrIr9f/eIZhjlaVxtB+i7N7ejSGBG7bEVlAp8KcgEScLBFLgF41P7YkmK 24owRDy7S4vl4DI3SzvjE/2lzl977OqBE2Gpcw2eSj2gReIGd4ltAr5tco+x+wPSJ28t A8onDPYp0wg2Y8HZPocouny7sqHUNwSOhxD6lMftwUHBJoe/z0ymFPZVcQxT9S9++91x BAH15j0nY16Iu8/IUJP91a2VfKvAWgOSCASzp7I/DBIvLJx59uWEc5a9c/K2r8/ivfvk 3De7DRpZ/7V8G/rmLFW43zYzU8elfXpxsBZpQGaM4Xhv5SnLuyYs0yAKqbmtcA2oVvft uQuQ== X-Gm-Message-State: AOUpUlGrbfHuOAto4z0CHIAxx/7Bu8aAL+b6RGX42A+tYvIzeWX7bz82 aUKBV8ZbSK586AQNw9bVZnotfg== X-Google-Smtp-Source: AAOMgpfZ0O/pGoWN4EuBBNS+Dc6q5RjcVPzqmyepF3gny050uwj1r9hCE9x8vNJyt5HzZYCbJi4fsA== X-Received: by 2002:adf:8806:: with SMTP id d6-v6mr21385414wrd.41.1533069485786; Tue, 31 Jul 2018 13:38:05 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d78-v6sm78363wma.37.2018.07.31.13.38.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 13:38:04 -0700 (PDT) Date: Tue, 31 Jul 2018 21:38:02 +0100 From: Leif Lindholm To: Chris Co Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Message-ID: <20180731203802.lmkz52ufrfvukvdd@bivouac.eciton.net> References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-3-christopher.co@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20180717020529.19496-3-christopher.co@microsoft.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 20:38:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 17, 2018 at 02:05:43AM +0000, Chris Co wrote: > MsPkg is a collection of libraries and drivers that are specific > to supporting Windows IoT Core but are not Platform/Silicon specific. Minor comments inline. > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > --- > Platform/Microsoft/MsPkg.dec | 42 ++++++++++++++++++++ > Platform/Microsoft/MsPkg.dsc | 32 +++++++++++++++ > 2 files changed, 74 insertions(+) > > diff --git a/Platform/Microsoft/MsPkg.dec b/Platform/Microsoft/MsPkg.dec > new file mode 100644 > index 000000000000..ff17a016943c > --- /dev/null > +++ b/Platform/Microsoft/MsPkg.dec > @@ -0,0 +1,42 @@ > +#/** @file > +# A package that contains generic headers and components. > +# > +# Copyright (c) Microsoft Corporation. All rights reserved. Please add a year to the copyright statement. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + DEC_SPECIFICATION = 0x00010005 0x0001001a is the current version, unless there's a specific reason for holding back. > + PACKAGE_NAME = MsPkg > + PACKAGE_GUID = DC909FB7-F45E-4D7F-BF10-327BD9BFA21C > + PACKAGE_VERSION = 0.1 > + > +[Includes.common] > + Include # Root include for the package > + > +[LibraryClasses.common] > + > +[Guids.common] > + gMsPkgTokenSpaceGuid = { 0x3ecb4bb9, 0xb80a, 0x4efd, { 0x92, 0xb8, 0x3a, 0x16, 0xe0, 0xc8, 0x19, 0xb } } > + > +[PcdsFixedAtBuild.common] > + gMsPkgTokenSpaceGuid.PcdSecureBootEnable|FALSE|BOOLEAN|0x00 > + > + # > + # The DevicePath to a partition on a writeable media used for logging and misc > + # storage purposes. SD card DevicePath example: > + # gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L"VenHw(AAFB8DAA-7340-43AC-8D49-0CCE14812489,03000000)/SD(0x0)/HD(1,MBR,0xAE420040,0x1000,0x20000)" > + # > + gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L""|VOID*|0x03 > + > +[Protocols.common] > + gEfiSdhcProtocolGuid = { 0x46055b0f, 0x992a, 0x4ad7, { 0x8f, 0x81, 0x14, 0x81, 0x86, 0xff, 0xdf, 0x72 } } > + gEfiRpmbIoProtocolGuid = { 0xfbaee5b2, 0x8b0, 0x41b8, { 0xb0, 0xb0, 0x86, 0xb7, 0x2e, 0xed, 0x1b, 0xb6 } } Please sort by name alphabetically where no other more logical ordering exists. > diff --git a/Platform/Microsoft/MsPkg.dsc b/Platform/Microsoft/MsPkg.dsc > new file mode 100644 > index 000000000000..b43902cbb04d > --- /dev/null > +++ b/Platform/Microsoft/MsPkg.dsc > @@ -0,0 +1,32 @@ > +## @file > +# A package that contains generic headers and components. > +# > +# Copyright (c) Microsoft Corporation. All rights reserved. Year. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license. > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +## > + > +[Defines] > + PLATFORM_NAME = MsPkg > + PLATFORM_GUID = 2F78367E-9C74-4FBE-82E7-1D2DAAF18CC6 > + PLATFORM_VERSION = 0.01 > + DSC_SPECIFICATION = 0x00010005 0x0001001a > + OUTPUT_DIRECTORY = Build/MsPkg > + SUPPORTED_ARCHITECTURES = ARM|AARCH64 > + BUILD_TARGETS = DEBUG|RELEASE DEBUG|NOOPT|RELEASE ? / Leif > + SKUID_IDENTIFIER = DEFAULT > + > +[PcdsFeatureFlag] > + > +[PcdsFixedAtBuild] > + > +[LibraryClasses] > + > +[Components] > + Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf > -- > 2.16.2.gvfs.1.33.gf5370f1 >