Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Jul 31, 2018 at 10:59:22PM +0200, Ard Biesheuvel wrote:
> On 31 July 2018 at 22:56, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > On Tue, Jul 17, 2018 at 02:05:45AM +0000, Chris Co wrote:
> >> This debug library provides support for importing symbols to
> >> debug using Lauterbach.
> >>
> >> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib
> >
> > I'm not seeing any difference between this one and the original other
> > than the addition of the Microsoft copyright statement and updating of
> > the debug printouts to modern style.
> >
> > I would be happy to take this as a patch to the original, but I don't
> > see what benefit this copy brings. What prevents you from using the
> > original?
> 
> The 'data.load.elf' statement in
> PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach

Oh, right.

That (original) code badly needs reformatting.

Still, if that's the only difference - and in a debug printout, why
fork the module?

If there is a way to identify which debugger is being used, use that.
If not, dump all the possible strings.

We really don't want a situation where you need to hard-code which
debugger you are using for a specific platform. And even if that is
unavoidable, it needs to live in the main edk2 repository.

/
    Leif