From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B8262096F33E for ; Wed, 1 Aug 2018 02:39:32 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id b15-v6so19419798wrv.10 for ; Wed, 01 Aug 2018 02:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+Sm9de5cTHgC276vNRifcKOWtLqDjWq7+xd7PSwCLa4=; b=VwdgxaBcG+whzr7HHpQVmx04hBiaerEN3BOZj9h5MKvcH9tBBPqTLXjKaosFmoZiME SYoKTaHDiLq85oNrDvnj+MzrHSPS+eM1nxJ2l1Jk1IGZz9loAS+Lf1eYGh2ki9ArEIFP TqUbUu+FmAly8RzFhLk9U1ZXRJVyCFTo9KXQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+Sm9de5cTHgC276vNRifcKOWtLqDjWq7+xd7PSwCLa4=; b=XHkgOJyIvsZLUMiPXh7awJl/GFgBoa0t4IQ+sf4eu1og5t3k/SJ+eCB6bnplgrmc40 IuFFpfcSQ8zf1WSksSfj1V/gAn3oCFCHzA/a7qRav2pvzL+0WTHEpR3gDTEADhA+x8Rr xeXdOPDHfMAz+WWu6KdDxrnoAyPGxnjeASOou7PejJOIDFyLc95hoPBjwaymTHuYrLjl 1NouPVA5a4rMGmxeXk17UdjxGPYnaoP1r4FKfNxgdGfoqqqtLPABGVDy6cTj0APRmSwl W7TWgzvRexfaFAcNswcBllOv7Rb4TZVCyGwobBDKOyaRXJBkAEJckaezTzQjCWiCNxxS JDcw== X-Gm-Message-State: AOUpUlGCcIJqpF0CJeKr9NZCrT45tLO4F0r0bLLMQR9kghMcQH2tziOf h0+eKHuXIZJdmbJtSpNe2hEWyA== X-Google-Smtp-Source: AAOMgpee76NDB6MMZxweXK9iYNBNdAohebM5f2RdXo0vhA5M8iT+AyQZYAU/1wHT/fuQ6iFAZqGAhg== X-Received: by 2002:adf:8503:: with SMTP id 3-v6mr23930073wrh.100.1533116370850; Wed, 01 Aug 2018 02:39:30 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a2-v6sm3869334wmb.6.2018.08.01.02.39.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 02:39:29 -0700 (PDT) Date: Wed, 1 Aug 2018 10:39:28 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Chris Co , "edk2-devel@lists.01.org" , Michael D Kinney Message-ID: <20180801093927.6hja7qgkiwpyvt3m@bivouac.eciton.net> References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-4-christopher.co@microsoft.com> <20180731205637.wxvzwq2xnbiaieju@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 09:39:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 31, 2018 at 10:59:22PM +0200, Ard Biesheuvel wrote: > On 31 July 2018 at 22:56, Leif Lindholm wrote: > > On Tue, Jul 17, 2018 at 02:05:45AM +0000, Chris Co wrote: > >> This debug library provides support for importing symbols to > >> debug using Lauterbach. > >> > >> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib > > > > I'm not seeing any difference between this one and the original other > > than the addition of the Microsoft copyright statement and updating of > > the debug printouts to modern style. > > > > I would be happy to take this as a patch to the original, but I don't > > see what benefit this copy brings. What prevents you from using the > > original? > > The 'data.load.elf' statement in > PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach Oh, right. That (original) code badly needs reformatting. Still, if that's the only difference - and in a debug printout, why fork the module? If there is a way to identify which debugger is being used, use that. If not, dump all the possible strings. We really don't want a situation where you need to hard-code which debugger you are using for a specific platform. And even if that is unavoidable, it needs to live in the main edk2 repository. / Leif