public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [Patch v6 20/23] FmpDevicePkg FmpDxe: Use local variable to store test key digest size
Date: Wed,  1 Aug 2018 16:29:20 -0700	[thread overview]
Message-ID: <20180801232923.18720-21-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20180801232923.18720-1-michael.d.kinney@intel.com>

From: Star Zeng <star.zeng@intel.com>

Some static tool reports "the condition in 'if' statement is constant".

This patch updates the code to use local variable to store test key
digest size. It can pass the static tool's check.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 FmpDevicePkg/FmpDxe/DetectTestKey.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c
index 6dedbdfaee..f9b983bb75 100644
--- a/FmpDevicePkg/FmpDxe/DetectTestKey.c
+++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c
@@ -53,12 +53,14 @@ DetectTestKey (
   UINT8    *PublicKeyDataXdrEnd;
   VOID     *HashContext;
   UINT8    Digest[SHA256_DIGEST_SIZE];
+  UINTN    TestKeyDigestSize;
 
   //
   // If PcdFmpDeviceTestKeySha256Digest is not exacty SHA256_DIGEST_SIZE bytes,
   // then skip the test key detection.
   //
-  if (PcdGetSize (PcdFmpDeviceTestKeySha256Digest) != SHA256_DIGEST_SIZE) {
+  TestKeyDigestSize = PcdGetSize (PcdFmpDeviceTestKeySha256Digest);
+  if (TestKeyDigestSize != SHA256_DIGEST_SIZE) {
     return;
   }
 
-- 
2.14.2.windows.3



  parent reply	other threads:[~2018-08-01 23:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 23:29 [Patch v6 00/23] Add FmpDevicePkg Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 01/23] FmpDevicePkg: Add package, library classes, and PCDs Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 02/23] FmpDevicePkg: Add library instances Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 03/23] FmpDevicePkg: Add FmpDxe module Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 04/23] FmpDevicePkg: Add DSC file to build all package components Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 05/23] FmpDevicePkg FmpDxe: Update function comment for FmpDxeEntryPoint Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 06/23] FmpDevicePkg FmpDxe: Return 0 when LSV check is not required Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 07/23] FmpDevicePkg: Remove IPF Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 08/23] FmpDevicePkg: Add DISABLE_NEW_DEPRECATED_INTERFACES build options Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 09/23] FmpDevicePkg FmpDxe: Check Progress!= NULL before calling Progress(100) Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 10/23] FmpDevicePkg FmpDxe: Add EFI_ABORTED in retval of CheckTheImage() Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 11/23] FmpDevicePkg FmpDxe: Fix typo "EFI_SECURITY_VIOLATIO" Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 12/23] FmpDevicePkg: Remove DisplayUpdateProgressLib mapping for FmpDxe Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 13/23] FmpDevicePkg FmpDxe: Add NULL check to return Value from GetVariable2 Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 14/23] FmpDevicePkg FmpDxe: Check ImageIndex first before Image/ImageSize Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 15/23] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 16/23] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 17/23] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 18/23] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 19/23] FmpDevicePkg: Fix code style issue Kinney, Michael D
2018-08-01 23:29 ` Kinney, Michael D [this message]
2018-08-01 23:29 ` [Patch v6 21/23] FmpDevicePkg/FmpDxe: Fix XCODE build failure Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 22/23] FmpDevicePkg: Remove useless lib mapping in dsc Kinney, Michael D
2018-08-01 23:29 ` [Patch v6 23/23] MdeModulePkg/BdsDxe: Move display of test key usage into BDS module Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801232923.18720-21-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox