Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver

[Leif Lindholm <leif.lindholm@linaro.org>]

On Thu, Aug 02, 2018 at 12:05:38AM +0000, Chris Co wrote:
> > Hmm, I'm already slightly unhappy that we have duplication between
> > EmbeddedPkg and MdeModulePkg (not to mention the extra fork for
> > Marvell's XenonDxe).
> > 
> > I'm obviously keen for the added functionality to be available to more
> > platforms. Is there any way for this support to be added into either the
> > EmbeddedPkg or the MdeModulePkg driver?
> 
> Understood - from talking with the other developers, we duplicated
> since we didn't know if these changes would be desired in edk2 core.
> As part of the review, do let me know if changes would be better
> placed in edk2 core instead of platform.

EDK2 has a history of copy-and-modify rather than refactoring code to
fit multiple cases. I am very strongly pushing for a shift towards the
latter.

Also, since we know there are more consumers than can be found in the
public trees, my threshold for at what point it's useful to add new
functionality in the core is very low.

Particularly for Sd/(e)Mmc, my goal is to integrate the EmbeddedPkg
and MdeModulePkg drivers back together at some point.

> I will be happy to refactor and submit patches to edk2 core.

Thanks!

/
    Leif