From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A25D1210D6935 for ; Thu, 2 Aug 2018 04:38:11 -0700 (PDT) Received: by mail-wm0-x244.google.com with SMTP id f21-v6so2115294wmc.5 for ; Thu, 02 Aug 2018 04:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SqplSUu9nSpRHIpr62z+XmkAXHTetRdwNH8bIMAMPRE=; b=GiA9YMZsYZWRHFd10+1qbTMtwzJbS83D/0pR9QIpSV+Hpu/0KHZ1oDny6MDUeinyLS hNByjzHunurWPRlvGUahG72b4/EuoNmFQUat0fWZLyKiAPZcn5Cv9IUg/wmUQuqCkkte AQafnrQgSsF6A+DPSNFra8LogM4/Y8EDb0Rjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SqplSUu9nSpRHIpr62z+XmkAXHTetRdwNH8bIMAMPRE=; b=sqY7MqxultXhH+22we9VPirrKzP/Edpdt6eDE4DGC6sTpg6HnHZUbNXQ/3Wi9b5KMV bYOaUgSoXXwTE32EH2D5gEzi0AuSOwuoX/kmC26Xy1faTLHLt5WplhjVXPk5DUDYn/jq xGzbEwulsLywxRk0DM2DMgV8Hb7FkIager2Rvh6mIRecst3g+Ia6fc/WhF3IAbKV/qu5 djv1lNpxO3whQXgpbXUDmJKQgSF3UfLSHZiig8Ks+sAqbnjmHBeTftrUIO7ssVIP/2OT V+rydt3AFVFslFl7kktNpedZYVr5kmnf0tnqiPoOdJGPxYuJsysbqmglkZ/FUn6p5lVb U5Xg== X-Gm-Message-State: AOUpUlHVfaWhx9DNsrltRZuhPl96bhNRMxp+flVfF7pwQInJ0KMQ49q4 eA9hSZT5+Q/Dbm4LMqtzeAZZJg== X-Google-Smtp-Source: AAOMgpdMq0qgPQG2VIwd+zWYV6XbmxPyZLeJ1UmraPIoylbBj9CPuNVD64WIivmFKrOCXiKvzHA7/w== X-Received: by 2002:a1c:64d5:: with SMTP id y204-v6mr1684859wmb.14.1533209889708; Thu, 02 Aug 2018 04:38:09 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h83-v6sm1163419wmf.46.2018.08.02.04.38.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 04:38:08 -0700 (PDT) Date: Thu, 2 Aug 2018 12:38:07 +0100 From: Leif Lindholm To: Chris Co Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Message-ID: <20180802113807.qrt3uc2uobdmtn3p@bivouac.eciton.net> References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-2-christopher.co@microsoft.com> <20180731203315.a334nudun6qu43ds@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 11:38:12 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 02, 2018 at 12:05:38AM +0000, Chris Co wrote: > > Hmm, I'm already slightly unhappy that we have duplication between > > EmbeddedPkg and MdeModulePkg (not to mention the extra fork for > > Marvell's XenonDxe). > > > > I'm obviously keen for the added functionality to be available to more > > platforms. Is there any way for this support to be added into either the > > EmbeddedPkg or the MdeModulePkg driver? > > Understood - from talking with the other developers, we duplicated > since we didn't know if these changes would be desired in edk2 core. > As part of the review, do let me know if changes would be better > placed in edk2 core instead of platform. EDK2 has a history of copy-and-modify rather than refactoring code to fit multiple cases. I am very strongly pushing for a shift towards the latter. Also, since we know there are more consumers than can be found in the public trees, my threshold for at what point it's useful to add new functionality in the core is very low. Particularly for Sd/(e)Mmc, my goal is to integrate the EmbeddedPkg and MdeModulePkg drivers back together at some point. > I will be happy to refactor and submit patches to edk2 core. Thanks! / Leif