From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F960210D7F39 for ; Thu, 2 Aug 2018 07:56:40 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id h10-v6so2443490wre.6 for ; Thu, 02 Aug 2018 07:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EFY6aMD4U+kNAaxbE760GVSsFWGfUy7LtF4pZDB8scg=; b=bWULnva8/IxfQn346/l17Vn2dBeAmKI0k7jE61CFvVxSxLSwKkuaCVLy5SYfQgJRS7 y1JLjPLqNpiOQ64bk7WsNr5pFyE8tNv9+qX+KdvvgnYNSLgaYc7dK7FXCU/M9l2nkO36 h0ekRixyjZOSAE8ln9GC+n76cS+Ch93feg8ow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EFY6aMD4U+kNAaxbE760GVSsFWGfUy7LtF4pZDB8scg=; b=Gcq9j2gzFgZ47iimWf4SkoDJkMEWOoVPGjXoLRbaPK0wH7p46gCPHa7DNuB4CHfBJR Jr3MNF5YtMXYD1Bz9AohtcVe0QKJuHrDdc2iCQZZrHmqMDRmGzQa/6gk3gA51u2H6YR3 Xql9oXj4s2Ia4XZa7WMhfc2as9LJ0ky7IXhsYgARQGiF5ajQSGcVWlxAiqIvlPSBXZXx Y29Xvm9cO5tys6TAYvawIS8qn6I+fdXQkeJ/Ub0ikEF+MKsLCdhbwM6QWvaRS1f9udnE UnA/y3s0o49UQyBQd/AJ3qIGsa0uvj1up8Ai0I0IuO13b4ARsYqj50Y7qQm9jbjEDHt6 JyGw== X-Gm-Message-State: AOUpUlFJ5dFjsWMmCjCCdHdF12to9mmYFdrZ5eLadkcPOi3ICiQ9Y9/8 s6NKE4ooK70Tj0QcmR+OoQJd6g== X-Google-Smtp-Source: AAOMgpf8DcnvDg082kdEH70S1743zYjJJgwdTcRGbUi7x1rO/03ux0QJD+IdYl+bjODf/YnpfGE48g== X-Received: by 2002:a5d:5641:: with SMTP id j1-v6mr2328913wrw.209.1533221799436; Thu, 02 Aug 2018 07:56:39 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b8-v6sm1469207wrw.22.2018.08.02.07.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 07:56:38 -0700 (PDT) Date: Thu, 2 Aug 2018 15:56:36 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Zhou You Message-ID: <20180802145636.o4qgzlmx44s4ttcm@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-3-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-3-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 02/38] Silicon/Hisilicon: Separate PlatformArch.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 14:56:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 24, 2018 at 03:08:46PM +0800, Ming Huang wrote: > As the mocro of PlatformArch.h is platform special, so Separate mocro -> macro (typo) special -> specific (subtleties of English language :) Separate -> separate (case) > PlatformArch.h to Hi1610,Hi1616,Hi1620 for unifying D0x. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhou You > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/{ => Hi1610}/Include/PlatformArch.h | 0 > Silicon/Hisilicon/Hi1616/Include/PlatformArch.h | 35 ++++++++++++++++++++ > Silicon/Hisilicon/Hi1620/Include/PlatformArch.h | 34 +++++++++++++++++++ Could you move the Hi1620 file to the "add d06 base files" patch? There is nothing else for D06 in the tree at this point. (Don't forget to update comment to reflect.) > 3 files changed, 69 insertions(+) > > diff --git a/Silicon/Hisilicon/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h > similarity index 100% > rename from Silicon/Hisilicon/Include/PlatformArch.h > rename to Silicon/Hisilicon/Hi1610/Include/PlatformArch.h > diff --git a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h > new file mode 100644 > index 0000000000..45995c5893 > --- /dev/null > +++ b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h > @@ -0,0 +1,35 @@ > +/** @file > +* > +* Copyright (c) 2015, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2015, Linaro Limited. All rights reserved. Update copyright year? > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > + > + > +#ifndef _PLATFORM_ARCH_H_ > +#define _PLATFORM_ARCH_H_ > + > +#define MAX_SOCKET 2 > +#define MAX_DIE 4 > +#define MAX_DDRC 2 > +#define MAX_NODE (MAX_SOCKET * MAX_DIE) > +#define MAX_CHANNEL 4 > +#define MAX_DIMM 3 > +#define MAX_RANK_CH 12 > +#define MAX_RANK_DIMM 4 > +// Max NUMA node number for each node type > +#define MAX_NUM_PER_TYPE 8 > + > +#define S1_BASE 0x40000000000 > + > +#endif > + > diff --git a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h > new file mode 100644 > index 0000000000..7243a9ec35 > --- /dev/null > +++ b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h > @@ -0,0 +1,34 @@ > +/** @file > +* > +* Copyright (c) 2015, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2015, Linaro Limited. All rights reserved. Update copyright year? (in other patch) / Leif > +* > +* This program and the accompanying materials > +* are licensed and made available under the terms and conditions of the BSD License > +* which accompanies this distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > + > + > +#ifndef _PLATFORM_ARCH_H_ > +#define _PLATFORM_ARCH_H_ > + > +#define MAX_SOCKET 2 > +#define MAX_DIE 4 > +#define MAX_DDRC 4 > +#define MAX_NODE (MAX_SOCKET * MAX_DIE) > +#define MAX_CHANNEL 8 > +#define MAX_DIMM 2 > +#define MAX_RANK_CH 8 > +#define MAX_RANK_DIMM 4 > +// Max NUMA node number for each node type > +#define MAX_NUM_PER_TYPE 8 > + > + > +#endif > + > -- > 2.17.0 >