From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8514210D515D for ; Thu, 2 Aug 2018 10:06:00 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a3-v6so2871480wrt.2 for ; Thu, 02 Aug 2018 10:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MW7Z0dB7fyGZqvVVGAZNf11qwwA9FmbQiShzGS7EAds=; b=P/zf5pHju2nNfFGxBPak0BW/H1WUMtN7VzPbrekAbUyYMEMlSRoGLRF5Wct46CCrs3 Dvtgjtaf0QGp2ZCF2TKCw1i8Cd6QDh6wqLBoQ5+3guf750t3XYFyCN2pi4/WDU3QoxXY EY8ufvZw8KEhxpUxBAxVIj2i5lCMU6BRjUEHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MW7Z0dB7fyGZqvVVGAZNf11qwwA9FmbQiShzGS7EAds=; b=GMliPSKINvZwCDCDR2rmfknLwQP1La9DT71ckJ5k/EYhT3SJ+o/qBLoHNWnesAsLG4 oPYZkS0/EBQKZBZ68+XMMbKTblEZMk9HIzt78VZcGDabHSJJbsYg6mzjcrN9PozK5wBs jUhFTI8lSpQGkRi9oqsKLEGu9IKOhQqkLYZmT8n1kbKwF/WT3eSuqbfc72BAxkzBv5La zV5yIgIFtZkORGM/PLXPOPctz1UMlronB5khutz0YzdcOOx+5MroW2jQVJZ0tYQgCNHk 0mFVD714DG7tIt2d3vVI4c0ghBi4LWlv/URnEVKXQMODUdWQf0suRotmMJw6CtuOL2HW bOpg== X-Gm-Message-State: AOUpUlErfCmESdAJ/TXitUPxKU0bL5ohuKAA2KQNpRPB3NvZPDoxBbnV PP4c2lBNE6P9fqOOIT2xRFAvHg== X-Google-Smtp-Source: AAOMgpcrDVKNpdvKsqCxGD6X8pzqerJjBbUErF0i8/7CDRHpCUewswvClXVqjOJjcDkjattiIYfjCg== X-Received: by 2002:adf:fcc3:: with SMTP id f3-v6mr216639wrs.216.1533229559435; Thu, 02 Aug 2018 10:05:59 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j16-v6sm1665863wme.8.2018.08.02.10.05.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 10:05:58 -0700 (PDT) Date: Thu, 2 Aug 2018 18:05:56 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Heyi Guo Message-ID: <20180802170556.aofxspo4mctd6a3b@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-6-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-6-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 05/38] Platform/Hisilicon/D06: Add binary file for D06 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 17:06:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Could the subject be changed to "add edk2-non-osi components for D06"? I should point out that I really like how this is done as a separate patch. On Tue, Jul 24, 2018 at 03:08:49PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D06/D06.dsc | 7 +++++++ > Platform/Hisilicon/D06/D06.fdf | 17 +++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index e05c97e1c6..88869ba26e 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -42,6 +42,8 @@ > > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLib.inf > TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf > + IpmiCmdLib|Silicon/Hisilicon/Hi1610/Library/IpmiCmdLib/IpmiCmdLib.inf > + Hmm, does this suggest that the IpmiCmdLib should move out of Hi1610 to Silicon/Hisilicon/Library? This is now the fourth platform making use of the Hi1610 variant. / Leif > NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > @@ -65,8 +67,12 @@ > > CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf > > + SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf > + > TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > RealTimeClockLib|Platform/Hisilicon/D06/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf > + OemAddressMapLib|Platform/Hisilicon/D06/Library/OemAddressMapD06/OemAddressMapD06.inf > + PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf > @@ -82,6 +88,7 @@ > # USB Requirements > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > + LpcLib|Silicon/Hisilicon/Hi1620/Library/LpcLibHi1620/LpcLib.inf > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > !if $(SECURE_BOOT_ENABLE) == TRUE > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf > index 93c464c9f7..2730eb42a9 100644 > --- a/Platform/Hisilicon/D06/D06.fdf > +++ b/Platform/Hisilicon/D06/D06.fdf > @@ -56,6 +56,7 @@ NumBlocks = 0x40 > > 0x00000000|0x00100000 > gArmTokenSpaceGuid.PcdSecureFvBaseAddress|gArmTokenSpaceGuid.PcdSecureFvSize > +FILE = Platform/Hisilicon/D06/Sec/FVMAIN_SEC.Fv > > 0x00100000|0x00280000 > gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize > @@ -163,6 +164,7 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Core/Dxe/DxeMain.inf > INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > + INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf > # > # PI DXE Drivers producing Architectural Protocols (EFI Services) > # > @@ -170,6 +172,7 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > + INF Platform/Hisilicon/D06/Drivers/SFC/SfcDxeDriver.inf > > > INF Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf > @@ -225,10 +228,15 @@ READ_LOCK_STATUS = TRUE > INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > + INF Platform/Hisilicon/D06/Drivers/Ipmi/IpmiInterfaceDxe/IpmiInterfaceDxe.inf > + INF Platform/Hisilicon/D06/Drivers/GetInfoFromBmc/GetInfoFromBmc.inf > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > INF Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > INF Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.inf > + INF Platform/Hisilicon/D06/Drivers/TransferSmbiosInfo/TransSmbiosInfo.inf > + INF Platform/Hisilicon/D06/Drivers/IpmiMiscOpDxe/IpmiMiscOpDxe.inf > > + INF Platform/Hisilicon/D06/Drivers/IpmiWatchdogDxe/IpmiWatchdogDxe.inf > > > INF Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe.inf > @@ -246,6 +254,7 @@ READ_LOCK_STATUS = TRUE > # > #Network > # > + INF Platform/Hisilicon/D06/Drivers/Net/SnpHi1620NewDxe/SnpDxe.inf > > INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > @@ -282,8 +291,14 @@ READ_LOCK_STATUS = TRUE > INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > + INF Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.inf > + INF Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.inf > > + # VGA Driver > + # > + INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > + INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf > INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > @@ -335,6 +350,8 @@ READ_LOCK_STATUS = TRUE > > INF Silicon/Hisilicon/Drivers/VersionInfoPeim/VersionInfoPeim.inf > > + INF Platform/Hisilicon/D06/Drivers/Ipmi/IpmiInterfacePei/IpmiInterfacePei.inf > + INF Platform/Hisilicon/D06/MemoryInitPei/MemoryInitPeim.inf > INF ArmPkg/Drivers/CpuPei/CpuPei.inf > INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf > INF IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf > -- > 2.17.0 >