From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 636442097FA8F for ; Thu, 2 Aug 2018 20:40:56 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 20:40:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,437,1526367600"; d="scan'208";a="221377343" Received: from ray-dev.ccr.corp.intel.com ([10.239.9.4]) by orsmga004.jf.intel.com with ESMTP; 02 Aug 2018 20:40:55 -0700 From: Ruiyu Ni To: edk2-devel@lists.01.org Cc: Hao A Wu Date: Fri, 3 Aug 2018 11:41:31 +0800 Message-Id: <20180803034131.109784-1-ruiyu.ni@intel.com> X-Mailer: git-send-email 2.16.1.windows.1 Subject: [PATCH] ShellPkg/acpi: Code cleanup to pass static code checker X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 03:40:56 -0000 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Hao A Wu --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 1 + .../Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 18c4983e95..5cab20023d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -297,7 +297,7 @@ DumpUint64 ( Val = *(UINT32*)(Ptr + sizeof (UINT32)); Val <<= 32; - Val |= *(UINT32*)Ptr; + Val |= (UINT64)*(UINT32*)Ptr; Print (Format, Val); } diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index 47ce93f104..4199e82ab1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -284,6 +284,7 @@ ConvertStrToAcpiSignature ( UINT8 Index; CHAR8 Ptr[4]; + ZeroMem (Ptr, sizeof (Ptr)); Index = 0; // Convert to Upper case and convert to ASCII diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c index 245700a253..c6eb7087cf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c @@ -118,7 +118,7 @@ UefiShellAcpiViewCommandLibConstructor ( gShellAcpiViewHiiHandle = NULL; // Check Shell Profile Debug1 bit of the profiles mask - if ((FixedPcdGet8 (PcdShellProfileMask) & BIT1) == 0) { + if ((PcdGet8 (PcdShellProfileMask) & BIT1) == 0) { return EFI_SUCCESS; } -- 2.16.1.windows.1