From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ming Huang <ming.huang@linaro.org>
Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org,
graeme.gregory@linaro.org, ard.biesheuvel@linaro.org,
guoheyi@huawei.com, wanghuiqiang@huawei.com,
huangming23@huawei.com, zhangjinsong2@huawei.com,
huangdaode@hisilicon.com, john.garry@huawei.com,
xinliang.liu@linaro.org, Heyi Guo <heyi.guo@linaro.org>
Subject: Re: [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library
Date: Fri, 3 Aug 2018 14:24:00 +0100 [thread overview]
Message-ID: <20180803132400.3hbh6gvibdq3qrup@bivouac.eciton.net> (raw)
In-Reply-To: <20180724070922.63362-16-ming.huang@linaro.org>
On Tue, Jul 24, 2018 at 03:08:59PM +0800, Ming Huang wrote:
> The hunt of waiting TX/TX finish is used by ten times,
> so move there hunts to a function CheckI2CTimeOut.
I approve of this change, but the subject is inaccurate.
Please change 'optimize' to 'refactor'.
Some style comments below.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <ming.huang@linaro.org>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
> Silicon/Hisilicon/Library/I2CLib/I2CHw.h | 4 +
> Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 176 +++++++-------------
> 2 files changed, 65 insertions(+), 115 deletions(-)
>
> diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> index aa561e929c..fa954c7937 100644
> --- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> +++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
> @@ -265,5 +265,9 @@
> UINT32 Val32;
> } I2C0_ENABLE_STATUS_U;
>
> +typedef enum {
> + I2CTx,
> + I2CRx
> +} I2CTransfer;
>
> #endif
> diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> index ecd2f07c4d..16636987a6 100644
> --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
> @@ -234,6 +234,42 @@ I2C_GetRxStatus(UINT32 Socket,UINT8 Port)
> return ulFifo.bits.rxflr;
> }
>
> +EFI_STATUS
> +EFIAPI
> +CheckI2CTimeOut (
> + UINT32 Socket,
> + UINT8 Port,
> + I2CTransfer Transfer
> +)
> +{
> + UINT32 ulTimes = 0;
> + UINT32 ulFifo;
Are these ul short for unsigned long?
That's called Hungarian notation and explicitly forbidden by the
coding style. Please drop, throughout the patch.
> +
> + if (Transfer == I2CTx) {
> + ulFifo = I2C_GetTxStatus (Socket,Port);
Space after ','.
> + while (ulFifo != 0) {
> + I2C_Delay(2);
> + if (++ulTimes > I2C_READ_TIMEOUT) {
> + (VOID)I2C_Disable (Socket, Port);
> + return EFI_TIMEOUT;
> + }
> + ulFifo = I2C_GetTxStatus (Socket,Port);
Space after ','.
> + }
> + }
> + else {
> + ulFifo = I2C_GetRxStatus (Socket,Port);
Space after ','.
> + while (ulFifo == 0) {
> + I2C_Delay(2);
> + if (++ulTimes > I2C_READ_TIMEOUT) {
> + (VOID)I2C_Disable (Socket, Port);
> + return EFI_TIMEOUT;
> + }
> + ulFifo = I2C_GetRxStatus (Socket,Port);
> + }
> + }
> + return EFI_SUCCESS;
> +}
> +
> EFI_STATUS
> EFIAPI
> WriteBeforeRead(I2C_DEVICE *I2cInfo, UINT32 ulLength, UINT8 *pBuf)
> @@ -247,17 +283,11 @@ WriteBeforeRead(I2C_DEVICE *I2cInfo, UINT32 ulLength, UINT8 *pBuf)
>
> I2C_SetTarget(I2cInfo->Socket,I2cInfo->Port,I2cInfo->SlaveDeviceAddress);
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
> + ulFifo = 0;
> for(ulCnt = 0; ulCnt < ulLength; ulCnt++)
> {
> ulTimes = 0;
> @@ -275,17 +305,8 @@ WriteBeforeRead(I2C_DEVICE *I2cInfo, UINT32 ulLength, UINT8 *pBuf)
> ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> }
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - ulTimes = 0;
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> -
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
> return EFI_SUCCESS;
> @@ -313,16 +334,8 @@ I2CWrite(I2C_DEVICE *I2cInfo, UINT16 InfoOffset, UINT32 ulLength, UINT8 *pBuf)
>
> I2C_SetTarget(I2cInfo->Socket,I2cInfo->Port,I2cInfo->SlaveDeviceAddress);
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
>
> @@ -336,17 +349,8 @@ I2CWrite(I2C_DEVICE *I2cInfo, UINT16 InfoOffset, UINT32 ulLength, UINT8 *pBuf)
> I2C_REG_WRITE(Base + I2C_DATA_CMD_OFFSET, InfoOffset & 0xff);
> }
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - ulTimes = 0;
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
> for(Idx = 0; Idx < ulLength; Idx++)
> @@ -372,20 +376,10 @@ I2CWrite(I2C_DEVICE *I2cInfo, UINT16 InfoOffset, UINT32 ulLength, UINT8 *pBuf)
> }
> }
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - ulTimes = 0;
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> -
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - DEBUG ((EFI_D_ERROR, "I2C Write try to finished,time out!\n"));
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
> +
This added blank line is unrelated to the change. Please drop.
> (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
>
> return EFI_SUCCESS;
> @@ -395,8 +389,6 @@ EFI_STATUS
> EFIAPI
> I2CRead(I2C_DEVICE *I2cInfo, UINT16 InfoOffset,UINT32 ulRxLen,UINT8 *pBuf)
> {
> - UINT32 ulFifo;
> - UINT32 ulTimes = 0;
> UINT8 I2CWAddr[2];
> EFI_STATUS Status;
> UINT32 Idx = 0;
> @@ -434,17 +426,8 @@ I2CRead(I2C_DEVICE *I2cInfo, UINT16 InfoOffset,UINT32 ulRxLen,UINT8 *pBuf)
>
> I2C_SetTarget(I2cInfo->Socket,I2cInfo->Port,I2cInfo->SlaveDeviceAddress);
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> -
> - while(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
> while (ulRxLen > 0) {
> @@ -455,16 +438,9 @@ I2CRead(I2C_DEVICE *I2cInfo, UINT16 InfoOffset,UINT32 ulRxLen,UINT8 *pBuf)
> I2C_REG_WRITE(Base + I2C_DATA_CMD_OFFSET, I2C_READ_SIGNAL | I2C_CMD_STOP_BIT);
> }
>
> - ulTimes = 0;
> - do {
> - I2C_Delay(2);
> -
> - while(++ulTimes > I2C_READ_TIMEOUT) {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetRxStatus(I2cInfo->Socket,I2cInfo->Port);
> - }while(0 == ulFifo);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CRx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> + }
>
> I2C_REG_READ(Base + I2C_DATA_CMD_OFFSET, pBuf[Idx++]);
>
> @@ -481,8 +457,6 @@ I2CReadMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset,UINT32 ulRxLen,UINT8 *pB
> {
> UINT32 ulCnt;
> UINT16 usTotalLen = 0;
> - UINT32 ulFifo;
> - UINT32 ulTimes = 0;
> UINT8 I2CWAddr[4];
> EFI_STATUS Status;
> UINT32 BytesLeft;
> @@ -558,16 +532,9 @@ I2CReadMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset,UINT32 ulRxLen,UINT8 *pB
>
>
> for(ulCnt = 0; ulCnt < BytesLeft; ulCnt++) {
> - ulTimes = 0;
> - do {
> - I2C_Delay(2);
> -
> - while(++ulTimes > I2C_READ_TIMEOUT) {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetRxStatus(I2cInfo->Socket,I2cInfo->Port);
> - }while(0 == ulFifo);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CRx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> + }
>
> I2C_REG_READ(Base + I2C_DATA_CMD_OFFSET, pBuf[Idx++]);
> }
> @@ -580,8 +547,6 @@ EFI_STATUS
> EFIAPI
> I2CWriteMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset, UINT32 ulLength, UINT8 *pBuf)
> {
> - UINT32 ulFifo;
> - UINT32 ulTimes = 0;
> UINT32 Idx;
> UINTN Base;
>
> @@ -597,16 +562,8 @@ I2CWriteMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset, UINT32 ulLength, UINT8
>
> I2C_SetTarget(I2cInfo->Socket,I2cInfo->Port,I2cInfo->SlaveDeviceAddress);
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
>
>
> @@ -630,7 +587,6 @@ I2CWriteMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset, UINT32 ulLength, UINT8
>
> }
>
> - ulTimes = 0;
> for(Idx = 0; Idx < ulLength; Idx++)
> {
>
> @@ -638,20 +594,10 @@ I2CWriteMultiByte(I2C_DEVICE *I2cInfo, UINT32 InfoOffset, UINT32 ulLength, UINT8
>
> }
>
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> - ulTimes = 0;
> - while(0 != ulFifo)
> - {
> - I2C_Delay(2);
> -
> - if(++ulTimes > I2C_READ_TIMEOUT)
> - {
> - DEBUG ((EFI_D_ERROR, "I2C Write try to finished,time out!\n"));
> - (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
> - return EFI_TIMEOUT;
> - }
> - ulFifo = I2C_GetTxStatus(I2cInfo->Socket,I2cInfo->Port);
> + if (CheckI2CTimeOut (I2cInfo->Socket,I2cInfo->Port,I2CTx) == EFI_TIMEOUT) {
Space after ','.
> + return EFI_TIMEOUT;
> }
> +
Unrelated added blank line. Please drop.
/
Leif
> (VOID)I2C_Disable(I2cInfo->Socket, I2cInfo->Port);
>
> return EFI_SUCCESS;
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-08-03 13:24 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 7:08 [PATCH edk2-platforms v1 00/38] Upload for D06 platform Ming Huang
2018-07-24 7:08 ` [PATCH edk2-platforms v1 01/38] Silicon/Hisilicon: Modify the MRC interface for other module Ming Huang
2018-08-02 14:42 ` Leif Lindholm
2018-08-05 3:35 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 02/38] Silicon/Hisilicon: Separate PlatformArch.h Ming Huang
2018-08-02 14:56 ` Leif Lindholm
2018-08-05 15:11 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 03/38] Hisilicon/D06: Add several basal file for D06 Ming Huang
2018-08-02 16:14 ` Leif Lindholm
2018-08-05 15:06 ` Ming
2018-08-06 3:01 ` Ming
2018-08-06 9:57 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 04/38] Platform/Hisilicon/D06: Add M41T83RealTimeClockLib Ming Huang
2018-08-02 16:56 ` Leif Lindholm
2018-08-08 8:02 ` Ming
2018-08-08 9:12 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 05/38] Platform/Hisilicon/D06: Add binary file for D06 Ming Huang
2018-08-02 17:05 ` Leif Lindholm
2018-08-07 15:04 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 06/38] Hisilicon/D06: Add OemMiscLibD06 Ming Huang
2018-08-02 17:22 ` Leif Lindholm
2018-08-08 3:49 ` Ming
2018-08-08 9:43 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready Ming Huang
2018-08-02 17:36 ` Leif Lindholm
2018-08-08 9:02 ` Ming
2018-08-08 9:59 ` Leif Lindholm
2018-08-08 11:44 ` Ming
2018-08-08 12:53 ` Leif Lindholm
2018-08-10 1:44 ` Ming
2018-08-14 15:26 ` Leif Lindholm
2018-08-15 4:01 ` Ming
2018-08-15 13:12 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 08/38] Silicon/Hisilicon/Acpi: Unify HisiAcipPlatformDxe Ming Huang
2018-08-02 17:39 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 09/38] Hisilicon/D06: Add Debug Serial Port Init Driver Ming Huang
2018-08-02 18:10 ` Leif Lindholm
2018-08-08 7:37 ` Ming
2018-08-08 10:01 ` Leif Lindholm
2018-08-08 14:48 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 10/38] Hisilicon/D06: Add ACPI Tables for D06 Ming Huang
2018-08-02 18:13 ` Leif Lindholm
2018-08-02 18:24 ` Ard Biesheuvel
2018-07-24 7:08 ` [PATCH edk2-platforms v1 11/38] Hisilicon/D06: Add Hi1620OemConfigUiLib Ming Huang
2018-08-03 10:24 ` Leif Lindholm
2018-08-08 12:09 ` Ming
2018-08-11 6:35 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 12/38] Silicon/Hisilicon/D06: Stop watchdog Ming Huang
2018-08-03 10:28 ` Leif Lindholm
2018-08-08 9:49 ` Ming
2018-08-03 10:31 ` Ard Biesheuvel
2018-08-09 11:40 ` Ming
2018-08-09 11:53 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 13/38] Silicon/Hisilicon/Acpi: Move some macro to PlatformArch.h Ming Huang
2018-08-03 10:37 ` Leif Lindholm
2018-08-08 12:22 ` Ming
2018-08-08 12:57 ` Leif Lindholm
2018-07-24 7:08 ` [PATCH edk2-platforms v1 14/38] Silicon/Hisilicon/D06: Fix I2C enable fail issue for D06 Ming Huang
2018-08-03 10:40 ` Leif Lindholm
2018-08-08 14:33 ` Ming
2018-07-24 7:08 ` [PATCH edk2-platforms v1 15/38] Silicon/Hisilicon/I2C: Optimize I2C library Ming Huang
2018-08-03 13:24 ` Leif Lindholm [this message]
2018-08-08 14:41 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 16/38] Silicon/Hisilicon/D06: Add I2C delay for HNS auto config Ming Huang
2018-08-03 13:28 ` Leif Lindholm
2018-08-09 3:59 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 17/38] Silicon/Hisilicon/D06: Optimize HNS config CDR post time Ming Huang
2018-08-03 13:30 ` Leif Lindholm
2018-08-08 14:54 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 18/38] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" Ming Huang
2018-08-03 13:32 ` Leif Lindholm
2018-08-09 0:35 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 19/38] Hisilicon/Hi1620: Add ACPI PPTT table Ming Huang
2018-08-03 13:42 ` Leif Lindholm
2018-08-09 0:52 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 20/38] Platform/Hisilicon/D06: Enable ACPI PPTT Ming Huang
2018-08-03 13:43 ` Leif Lindholm
2018-07-24 7:09 ` [PATCH edk2-platforms v1 21/38] Silicon/Hisilicon/D0x: Move macro definition to PlatformArch.h Ming Huang
2018-08-03 13:44 ` Leif Lindholm
2018-07-24 7:09 ` [PATCH edk2-platforms v1 22/38] Platform/Hisilicon/D06: Add OemNicLib Ming Huang
2018-08-03 14:36 ` Leif Lindholm
2018-08-09 6:16 ` Ming
2018-08-09 10:19 ` Leif Lindholm
2018-08-09 14:41 ` Ming
2018-08-14 2:38 ` Ming
2018-08-14 15:48 ` Leif Lindholm
2018-08-15 11:08 ` Ming
2018-08-15 13:22 ` Leif Lindholm
2018-08-15 14:16 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 23/38] Hisilicon/D0X: Rename the global variable gDS3231RtcDevice Ming Huang
2018-08-03 15:20 ` Leif Lindholm
2018-08-09 6:22 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 24/38] Platform/Hisilicon/D06: Add OemNicConfig2P Driver Ming Huang
2018-08-03 15:23 ` Leif Lindholm
2018-08-09 6:24 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 25/38] Hisilicon/D0x: Update SMBIOS type9 info Ming Huang
2018-08-04 9:28 ` Leif Lindholm
2018-08-09 6:34 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 26/38] Silicon/Hisilicon/D0x: Move macro definition to PlatformArch.h Ming Huang
2018-08-04 9:34 ` Leif Lindholm
2018-08-09 6:37 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim Ming Huang
2018-08-04 9:59 ` Leif Lindholm
2018-08-09 7:07 ` Ming
2018-08-09 10:27 ` Leif Lindholm
2018-08-09 11:54 ` Ming
2018-08-14 2:31 ` Ming
2018-08-14 15:42 ` Leif Lindholm
2018-07-24 7:09 ` [PATCH edk2-platforms v1 28/38] Hisilicon/D0x: Unify FlashFvbDxe driver Ming Huang
2018-08-04 10:06 ` Leif Lindholm
2018-08-09 7:15 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 29/38] Platform/Hisilicon/D06: Add PciHostBridgeLib Ming Huang
2018-08-04 13:41 ` Leif Lindholm
2018-08-09 7:22 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 30/38] Hisilicon/D06: add apei driver Ming Huang
2018-08-04 14:47 ` Leif Lindholm
2018-08-10 2:46 ` Ming
2018-08-14 15:39 ` Leif Lindholm
2018-08-15 8:57 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 31/38] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h Ming Huang
2018-08-04 14:58 ` Leif Lindholm
2018-08-09 12:02 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 32/38] Platform/Hisilicon/D06: Add capsule upgrade support Ming Huang
2018-08-04 15:08 ` Leif Lindholm
2018-07-24 7:09 ` [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock Ming Huang
2018-08-04 15:14 ` Leif Lindholm
2018-08-09 12:15 ` Ming
2018-08-09 12:27 ` Leif Lindholm
2018-08-10 2:05 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 34/38] Silicon/Hisilicon/D06: Add I2C Bus Exception deal function Ming Huang
2018-08-04 15:18 ` Leif Lindholm
2018-08-10 2:19 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 35/38] Silicon/Hisilicon/Setup: Support SPCR table switch Ming Huang
2018-08-04 15:20 ` Leif Lindholm
2018-08-09 14:17 ` Ming
2018-08-09 14:44 ` Leif Lindholm
2018-08-09 15:40 ` Ming
2018-08-09 15:48 ` Leif Lindholm
2018-07-24 7:09 ` [PATCH edk2-platforms v1 36/38] Silicon/Hisilicon/setup: Support SMMU switch Ming Huang
2018-08-06 9:59 ` Leif Lindholm
2018-08-09 14:19 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 37/38] Hisilicon/D06: Add PciPlatformLib Ming Huang
2018-08-06 10:01 ` Leif Lindholm
2018-08-09 14:27 ` Ming
2018-07-24 7:09 ` [PATCH edk2-platforms v1 38/38] Platform/Hisilicon/D0x: Update version string to 18.08 Ming Huang
2018-08-06 10:03 ` Leif Lindholm
2018-08-09 14:29 ` Ming
2018-08-01 21:56 ` [PATCH edk2-platforms v1 00/38] Upload for D06 platform Leif Lindholm
2018-08-02 1:46 ` Ming
2018-08-02 3:17 ` 答复: " Guoheyi
2018-08-02 10:12 ` Leif Lindholm
2018-08-02 15:36 ` Graeme Gregory
2018-08-04 14:26 ` Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803132400.3hbh6gvibdq3qrup@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox