From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2774021A00AE6 for ; Fri, 3 Aug 2018 06:30:27 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h14-v6so5402604wrw.13 for ; Fri, 03 Aug 2018 06:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=InBqQeeepQUXrZYy7goIVSmISyvSqjm1NM/JIHlUeXc=; b=M4dEg8MdNjraBm3u0T/7GpMUAfRwBumA+QO4TdYOMf0eaLskGb9LMES1O3hDC/cgCF 2NBrX7TYqkvvpeFK+gn9k3Qf/AdisZh4aCDF6GOQyfZvvjd9i1SDIdaq79pEzK8rJu/d C0WTBs5UvGxmkgasQyslCoOt/yfJ4ZatVbhnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=InBqQeeepQUXrZYy7goIVSmISyvSqjm1NM/JIHlUeXc=; b=ijsvEJF/dWp9JzHHEHIi36yQ/FAknFRVKcH21VPDFsOHZrWn/SPHakMmMSvxh4wMA4 BEeF8GfysXi2MN7W7WUtTjy+2SAQ1P6WzT0+VAKwQc4/U9fRTLiF4/5pkQPFWb+tDoPs wBFVsh7e/IqyPIp3juO8M3mpURKpb5eJR+Hl3A1JCnGhc2cmiMoUpTKaEq1n3CXgHtcK ///6bCLqNiRwWBFVhdKvP0p+8QBHBRk5yBQtzUFyX97gSx8WKZxXHE0K2lEoHxISB87q wA/d3qIm7a7VwyLYUCmZSst1IGccqAmo1jbG+ikcO4Cz3WSxj2ktRGFoa6FX/LXnRe8X F/4Q== X-Gm-Message-State: AOUpUlEwTJIRhAIC5FSv/scX8GyPoMp4naCGXXvu039eHQwWfiXFBmSY 4amv3le8ioEVHeLTv8QP2Soz0Q== X-Google-Smtp-Source: AAOMgpflE6+cjCPz2IQgzzNVRpeh6eTufD5DTBsj3oALTNwDBvFK/wPQB29qTcAS62IxgmnLztyRLg== X-Received: by 2002:a5d:69ca:: with SMTP id s10-v6mr2506909wrw.77.1533303026597; Fri, 03 Aug 2018 06:30:26 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v124-v6sm6158595wma.18.2018.08.03.06.30.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Aug 2018 06:30:25 -0700 (PDT) Date: Fri, 3 Aug 2018 14:30:23 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, shaochangliang , Heyi Guo Message-ID: <20180803133023.nmz36sqnezlt5wql@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-18-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-18-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 17/38] Silicon/Hisilicon/D06: Optimize HNS config CDR post time X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 13:30:28 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 24, 2018 at 03:09:01PM +0800, Ming Huang wrote: > From: shaochangliang > > Use I2C 400KB speed for config CDR > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shaochangliang > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > index fa8c510f36..8d87336375 100644 > --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c > @@ -28,6 +28,9 @@ > #include "I2CLibInternal.h" > #include "I2CHw.h" > > +#define I2C_100KB_SPEED 0x1 > +#define I2C_400KB_SPEED 0x2 > + > VOID I2C_Delay(UINT32 ulCount) > { > MicroSecondDelay(ulCount); > @@ -149,7 +152,14 @@ I2CInit(UINT32 Socket, UINT32 Port, SPEED_MODE SpeedMode) > > I2C_REG_READ(Base + I2C_CON_OFFSET, I2cControlReg.Val32); > I2cControlReg.bits.master = 1; > - I2cControlReg.bits.spedd = 0x1; > + if(Normal == SpeedMode) > + { '{' on previous line. > + I2cControlReg.bits.spedd = I2C_100KB_SPEED; > + } > + else 'else' on previous line. > + { '{' on previous line. / Leif > + I2cControlReg.bits.spedd = I2C_400KB_SPEED; spedd? That looks as a typo in the struct definition. It should probably be Speed. Can you please provide a separate patch for that preceding this one? / Leif > + } > I2cControlReg.bits.restart_en = 1; > I2cControlReg.bits.slave_disable = 1; > I2C_REG_WRITE(Base + I2C_CON_OFFSET,I2cControlReg.Val32); > -- > 2.17.0 >