From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8934210D8508 for ; Fri, 3 Aug 2018 06:32:42 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h9-v6so5450629wro.3 for ; Fri, 03 Aug 2018 06:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=MjLEYZ1ddi8vD5fm6shL6TKUlmNLw5SUXrwVmTMxq74=; b=VWVQBjBkfv+WOG3kaNOj+2bhSGkCNYTvF//bgdf9nzpIoAlo2J1A7N/ArMFI8AI7aK PETMqL/yeY6jbnpCZ8Qlk5juSu7yjpEW0hUkijgQF+0koEV3P4gP+kMb9IS6LUXyLsNg qyLcZrLMLM9gWZH4KM9GvqMQ3u4waEs3/H9Ng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=MjLEYZ1ddi8vD5fm6shL6TKUlmNLw5SUXrwVmTMxq74=; b=N/X1qmYrwR5kj1OV9xHj/bWP10hga12vl1XzHtUyHspo+MRUmIedi72BuHCrb2uu7e IWvMCZPgmvG2Ye+LaTkVNMssIuM7eJdby9Om2RtQPJk4zbQLRgeBjah33fqXMJxf0GWF JFYxYP4ck3gxSKqMjNRBfANmmHfO15fK0AV70Xd/sP119o6CRYj1Pw+/uwyBuPYfiMW0 sOsHFzoHqbNN0ElkNihnDOIJNgaVqC1axVsEKsQw9IIUlMPmtutsE0YafeDECNhTLWM8 lCjHsRm0ZhIkRcn7h9sa3HKBQBEonATrEL/xwZfOKMlbUe2e7l7RXvfrgtEG5n8rxtjf EXCw== X-Gm-Message-State: AOUpUlGNeQxvnzoPQ+s4/eSL7U6917TE+tb+zW8qCOU8S5zxQcXdqeGe lTFCleBE7eduaypcFIAQWfvgXg== X-Google-Smtp-Source: AAOMgpeioRRe/Rpp3Jjs1WeM2JIy0zmaHWDWqem18foLkzRV5nsaXRKMsmhFU0aVVPXVg5kYJhbF+w== X-Received: by 2002:adf:94e2:: with SMTP id 89-v6mr2576776wrr.48.1533303161330; Fri, 03 Aug 2018 06:32:41 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a12-v6sm3304527wru.61.2018.08.03.06.32.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Aug 2018 06:32:40 -0700 (PDT) Date: Fri, 3 Aug 2018 14:32:38 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Yang XinYi , Heyi Guo Message-ID: <20180803133238.2m3fgnytxvgeviy2@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-19-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-19-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 18/38] Silicon/Hisilicon/Setup: Add Setup Item "EnableGOP" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 13:32:43 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Jul 24, 2018 at 03:09:02PM +0800, Ming Huang wrote: > From: Yang XinYi > > Add Setup Item "EnableGOP" for D06, This Item only takes > effect on SM750 What is SM750? Please add more detail to commit message. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yang XinYi > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr | 7 +++++++ > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni | 8 ++++---- > Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- > Silicon/Hisilicon/Include/Library/OemConfigData.h | 1 + > 4 files changed, 13 insertions(+), 5 deletions(-) > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > index 9e3ac73116..c0b6e294a6 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.hfr > @@ -38,4 +38,11 @@ form formid = MISC_CONFIG_FORM_ID, > option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > endoneof; > > + oneof varid = OEM_CONFIG_DATA.EnableGOP, > + prompt = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER), > + help = STRING_TOKEN(STR_ENABLE_GOP_FRAME_BUFFER_HELP), > + option text = STRING_TOKEN(STR_DISABLED), value = 0, flags = DEFAULT; > + option text = STRING_TOKEN(STR_ENABLED), value = 1, flags = 0; > + endoneof; > + > endform; > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > index 5ad1d1df30..0170c84ff6 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/MiscConfig.uni > @@ -30,7 +30,7 @@ > #language fr-FR "Support SPCR" > #string STR_ENABLE_SPCR_HELP #language en-US "Enable or Disable SPCR Table." > #language fr-FR "Activer ou désactiver la table SPCR." > -#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB" > - #language fr-FR "Support GOP FB" > -#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer." > - #language fr-FR "Activer ou désactiver Buffer de frame GOP." > +#string STR_ENABLE_GOP_FRAME_BUFFER #language en-US "Support GOP FB for SM750" > + #language fr-FR "Soutien GOP FB pour SM750" > +#string STR_ENABLE_GOP_FRAME_BUFFER_HELP #language en-US "Enable or Disable GOP frame buffer for SM750." > + #language fr-FR "Activer ou désactiver Buffer de frame GOP pour SM750." > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > index 586094dfbf..88051493cf 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c > @@ -311,7 +311,7 @@ OemConfigUiLibConstructor ( > Configuration.EnableSmmu = 1; > Configuration.EnableFdtTable = 0; > Configuration.EnableSpcr = 0; > - //Configuration.EnableGOP=0; > + Configuration.EnableGOP = 0; I _think_ I commented to delete that line on a previous patch. If not, please delete the commented out line from wherever it was introduced. / Leif > // > //Set the default value of the Ras option > // > diff --git a/Silicon/Hisilicon/Include/Library/OemConfigData.h b/Silicon/Hisilicon/Include/Library/OemConfigData.h > index 478821ae2c..e4d5917046 100644 > --- a/Silicon/Hisilicon/Include/Library/OemConfigData.h > +++ b/Silicon/Hisilicon/Include/Library/OemConfigData.h > @@ -61,6 +61,7 @@ typedef struct { > UINT8 EnableSmmu; > UINT8 EnableFdtTable; > UINT8 EnableSpcr; > + UINT8 EnableGOP; > /*RAS Config*/ > UINT8 EnRasSupport; > UINT8 EnPoison; > -- > 2.17.0 >