From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B3C2210D93C6 for ; Sat, 4 Aug 2018 08:14:37 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id u12-v6so8142970wrr.4 for ; Sat, 04 Aug 2018 08:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G+22sDtAFby982jisLMdGpXx3WgfNQiE4haX83AFrdY=; b=ZyIA7xyJ+plGiHAPm71dq9bj/ECL8nY3ex7gNB1s8+JhERHNtZoq9YUeHRjh0CjUCk 8p3USmhB+oiRA5Ut5tndes5Eyf8ZUNny2PaQcZwSFa8w7EWM25NI5cr4hgi3KkXhVmLS 6nx5FMTRGRDr3IaQulMfeA9yt0DB9uf97Vg5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G+22sDtAFby982jisLMdGpXx3WgfNQiE4haX83AFrdY=; b=BA8TW0PZXCB4yrYtDOzadiDzRTlOJPBerCMcgcIYhOWHSrIJqS0ES0LawKqU6a3vxH VaEqxJVUJKl1roHFUCP4H5C3/gzfTYAvtkPyF6AO7eBGeyu4JW4gsINjXf3pPQNz0qm4 u18lGd5c9EzlEvl/TsU6CVx9THeb3lHmPwusgcTTJ0z2ESHVDp3/xEPVMMm/6vuVQs4+ 5A/wY1Pm7Yf0IBiayIDkz+49zhdHk1AehMpAGzF/7l2fssvYi1JczslPLBipkIIyHoxW 7lqoslqAzxKP/59Y4j3nwBxhDOG49xIWF0lV/sSKkZXN+SKO/4fI8i77NEzty437iGYL 42Fw== X-Gm-Message-State: AOUpUlFaBMzHBHcuwE2x7O+DRFXizJwvatMwOUkkfqG3vz8s3J5SMPkN 0LzmpejGsPo8N97oybVkswUD1w== X-Google-Smtp-Source: AAOMgpdLpqJpSJh/+8JYp5xRpT2TNpK9YoNjzttH8H93zhR/HmqlFVI2R8TkGYAwgiShxx/3vAfL4g== X-Received: by 2002:a5d:648a:: with SMTP id r10-v6mr5414856wru.109.1533395675632; Sat, 04 Aug 2018 08:14:35 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j8-v6sm8001473wru.41.2018.08.04.08.14.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Aug 2018 08:14:34 -0700 (PDT) Date: Sat, 4 Aug 2018 16:14:32 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, ZhenYao , Heyi Guo Message-ID: <20180804151432.jc45us7rfyz6bytm@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-34-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-34-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2018 15:14:37 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: > From: ZhenYao > > When BIOS booting, the power consumption is too high, so need close > some clusters clock that don't work to reduce power consumption. On the one hand: should this not be handled in ARM-TF? What if (during development) we load a bad EDK2 image? > The implementation of functions is in edk2-non-osi. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: ZhenYao > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > index ec2b9a36e7..cc60e213de 100644 > --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > @@ -102,5 +102,8 @@ VOID PlatformEventBroadcastConfig(VOID); > UINTN GetDjtagRegBase(UINT32 NodeId); > VOID LlcCleanInvalidateAsm(VOID); > VOID PlatformMdioInit(VOID); > +VOID CloseClusterClock(UINTN CpuClusterBase); The opposite of Enable is Disable. So Could this be DisableClusterClock? > +VOID EnableClusterClock(UINTN CpuClusterBase); > +VOID CloseSktClock (UINT8 Skt); Disable? Also, Socket, not Skt. / Leif > > #endif > -- > 2.17.0 >