From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56AD521CAD998 for ; Mon, 6 Aug 2018 03:03:29 -0700 (PDT) Received: by mail-wm0-x241.google.com with SMTP id f21-v6so13190049wmc.5 for ; Mon, 06 Aug 2018 03:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ePV2kNdLgXTbbkd8Q6aLnc9J9uSCT+Sf9eISDqm5TNw=; b=YWlb79Jbt+3lQu38EPiUVsvZUWLN778iNSbAwQyz15YO5awP0swKI5tGXnGJO3HIgh h/nYaB7744Z8nNge+x84KyBoW+o8YeFRn3cnSrmpRYImaWxVl57+rymsJRDBTN3MLl99 SmQdPwoqgXlYYCuvZLiz24BzWGKrKL6OTpFlI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ePV2kNdLgXTbbkd8Q6aLnc9J9uSCT+Sf9eISDqm5TNw=; b=j1W7/k4iTOsNEGosfwqJOJkvSsnftFDMYts8WG+DaDjLwrFZje/vPe/aA7r+vdqwdn dAzWH2yt+HdWXeQsUhULQwKgEmKhhlhJ1orTZVvF2X61Ph+6bTeINk5IltFk56MtcDt4 fMBYH8RAS1tPCFkIuNG+QFJcw8q+YzyrGASmAZJa3LuK/oTNUISd9bwIThHr/ULV+mDV APiHhVi/JcjdpTRHcAhDfLS6tuDV1Q5N11Q1DjNeEg5ULM2iEPU3exzU2c8OXcrwjMF+ YazBrnljbPMiCkupAYZrc/UP5fJSfDZzGDMWDKztWbqnOe+VkC85DdwJwSiugTQO5VIs nsnA== X-Gm-Message-State: AOUpUlE+jK9XlSejmAuy0RsJCyBpxzIEDoizAl8E36Ot4iCsmBkYggeq ZPU0dO1bCLlaA3JnVnRieXMvVw== X-Google-Smtp-Source: AAOMgpd++4PGtEE3bAJi89Xk34PZciKmdg62ITCbZPEUASwj0Gmkn/ulrjLzDQuLLXC8n/7F4fqtgA== X-Received: by 2002:a1c:ae94:: with SMTP id x142-v6mr11957636wme.125.1533549807772; Mon, 06 Aug 2018 03:03:27 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x7-v6sm15417179wrr.95.2018.08.06.03.03.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 03:03:26 -0700 (PDT) Date: Mon, 6 Aug 2018 11:03:25 +0100 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org Message-ID: <20180806100325.iqfxp7towin2y5gn@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-39-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180724070922.63362-39-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 38/38] Platform/Hisilicon/D0x: Update version string to 18.08 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 10:03:29 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 24, 2018 at 03:09:22PM +0800, Ming Huang wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D03/D03.dsc | 2 +- > Platform/Hisilicon/D05/D05.dsc | 2 +- > Platform/Hisilicon/D06/D06.dsc | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index 38548a0f23..8ed9c37a31 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -174,7 +174,7 @@ > !ifdef $(FIRMWARE_VER) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !else > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D03" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D03" > !endif > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index f2bbf27639..d9c0978f01 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -192,7 +192,7 @@ > !ifdef $(FIRMWARE_VER) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !else > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D05" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D05" > !endif > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index 9a3128048e..4388812d44 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -166,12 +166,12 @@ > !ifdef $(FIRMWARE_VER) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !else > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D06 UEFI RC0 - B308 (V0.38)" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""Development build 18.08 for Hisilicon D06" I pointed this out before, but just to get it with the actual patch: there's an extra " in the line above that breaks the build when FIRMWARE_VER is not specified. Drop that and: Reviewed-by: Leif Lindholm > !endif > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > > - gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.38" > + gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.42" > > gHisiTokenSpaceGuid.PcdSystemProductName|L"D06" > gHisiTokenSpaceGuid.PcdSystemVersion|L"VER.A" > -- > 2.17.0 >