From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A7356210DA7A8 for ; Wed, 8 Aug 2018 01:44:21 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id e7-v6so1245867wrs.9 for ; Wed, 08 Aug 2018 01:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5osmVvoqnhuJCEFYKdU+tSZhvhIY0U6ivWcL0XTlpvc=; b=J2cBylchJDSyZoLMDACTAODa02nmu0v8yeWnKT7BbRNrqc4Z+4rBscf/XitPUszgZ1 N448C5KZsbwLjykp2cmdamGe01uM033XtN7KtQsN4KqZDamOkR5HarswulNpfTMo2D4+ f77Df4YH25JBLpBgjbjMp5HG/+E9HINRgna1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5osmVvoqnhuJCEFYKdU+tSZhvhIY0U6ivWcL0XTlpvc=; b=cROZYLnpPwsVXSEVs4OUKuQbTtu6hcZK6YcT7Cttz+7p9EZ02cMroLiBb8HLVHrybW BicuZw1joNRLctAW5WgxisEhuMdu+kWpNy1TI4HBrnzZBSJT40yo4xsE8QXucYQS4GI9 78iR+tXU8ruufrycdBz0vM/YTlBZOplAYCigHxXTRY//oroGarVIdg4krqCwHzOGJPdh zl6Za6e4iKSsPyoaHfkxv8gp7Fg8BKiTlNOjoz0r4AqP2G4pugxPKqWk4XHgnUkryPS1 FwvBFFhy92/0r8cYW9vegFTEB68fcDGmnO4scvVeo0ddMnGEZQN4NKr0fSxrDfi2szFK zu9w== X-Gm-Message-State: AOUpUlFSUK0VtbsULqzPlD6Uz1QVnnD+4L8U86kBatNSYlVcnn51wnk8 sJwcm78uQvss4LVKKyNJ162xAQ== X-Google-Smtp-Source: AA+uWPyodM4RVMt0ojnBe39HK9IRIDPLvxU0YhJCvmzxoNfV3qlh3rUaHFM3UNCdlucrIGbmKZtmgg== X-Received: by 2002:adf:ea0a:: with SMTP id q10-v6mr1260204wrm.224.1533717860231; Wed, 08 Aug 2018 01:44:20 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t5-v6sm3711156wrm.80.2018.08.08.01.44.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 01:44:19 -0700 (PDT) Date: Wed, 8 Aug 2018 09:44:17 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Ming Huang Message-ID: <20180808084417.wlpts3itcuumvgsd@bivouac.eciton.net> References: <20180807205112.2008-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] Silicon/Hisilicon: add PlatformBootManagerUnableToBoot() to PlatformBm X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 08:44:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 07, 2018 at 10:52:59PM +0200, Ard Biesheuvel wrote: > On 7 August 2018 at 22:51, Leif Lindholm wrote: > > edk2 commit 1010873becc5, > > ("MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()") broke the > > d0x build, since they use their own PlatformBootManagerLib, which did not > > include this function. > > > > Implement a trivial one, that just returns. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Thanks, pushed as d346a222df. / Leif > > --- > > > > NOTE: The upstream build is currently broken. This failure needs to be > > addressed before d02 deletion and d03 fix can go in. > > > > Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c b/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > > index 7dd5ba615c..aa6db929ca 100644 > > --- a/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > > +++ b/Silicon/Hisilicon/Library/PlatformBootManagerLib/PlatformBm.c > > @@ -641,3 +641,19 @@ PlatformBootManagerWaitCallback ( > > 0 > > ); > > } > > + > > +/** > > + The function is called when no boot option could be launched, > > + including platform recovery options and options pointing to applications > > + built into firmware volumes. > > + > > + If this function returns, BDS attempts to enter an infinite loop. > > +**/ > > +VOID > > +EFIAPI > > +PlatformBootManagerUnableToBoot ( > > + VOID > > + ) > > +{ > > + return; > > +} > > -- > > 2.11.0 > >