From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B4FB3210E0FAB for ; Wed, 8 Aug 2018 01:47:35 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 01:47:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="252946684" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2018 01:47:34 -0700 From: shenglei To: edk2-devel@lists.01.org Cc: Star Zeng , Eric Dong Date: Wed, 8 Aug 2018 16:46:55 +0800 Message-Id: <20180808084712.34696-10-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> Subject: [PATCH 09/26] MdeModulePkg XhciDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 08:47:35 -0000 The functions that are never called have been removed. They are XhcReadDoorBellReg and XhcWriteOpReg16. https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Cc: Star Zeng Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 66 -------------------------- MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h | 28 ----------- 2 files changed, 94 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c index 4d5937de53..5f0736a516 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c @@ -158,75 +158,9 @@ XhcWriteOpReg ( } } -/** - Write the data to the 2-bytes width XHCI operational register. - @param Xhc The XHCI Instance. - @param Offset The offset of the 2-bytes width operational register. - @param Data The data to write. -**/ -VOID -XhcWriteOpReg16 ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset, - IN UINT16 Data - ) -{ - EFI_STATUS Status; - - ASSERT (Xhc->CapLength != 0); - - Status = Xhc->PciIo->Mem.Write ( - Xhc->PciIo, - EfiPciIoWidthUint16, - XHC_BAR_INDEX, - Xhc->CapLength + Offset, - 1, - &Data - ); - - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XhcWriteOpReg16: Pci Io Write error: %r at %d\n", Status, Offset)); - } -} - -/** - Read XHCI door bell register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the door bell register. - @return The register content read - -**/ -UINT32 -XhcReadDoorBellReg ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset - ) -{ - UINT32 Data; - EFI_STATUS Status; - - ASSERT (Xhc->DBOff != 0); - - Status = Xhc->PciIo->Mem.Read ( - Xhc->PciIo, - EfiPciIoWidthUint32, - XHC_BAR_INDEX, - Xhc->DBOff + Offset, - 1, - &Data - ); - - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XhcReadDoorBellReg: Pci Io Read error - %r at %d\n", Status, Offset)); - Data = 0xFFFFFFFF; - } - - return Data; -} /** Write the data to the XHCI door bell register. diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h index 838a44628c..20e7ac0e8f 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h @@ -286,20 +286,6 @@ XhcWriteOpReg ( IN UINT32 Data ); -/** - Write the data to the 2-bytes width XHCI operational register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the 2-bytes width operational register. - @param Data The data to write. - -**/ -VOID -XhcWriteOpReg16 ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset, - IN UINT16 Data - ); /** Read XHCI runtime register. @@ -331,20 +317,6 @@ XhcWriteRuntimeReg ( IN UINT32 Data ); -/** - Read XHCI door bell register. - - @param Xhc The XHCI Instance. - @param Offset The offset of the door bell register. - - @return The register content read - -**/ -UINT32 -XhcReadDoorBellReg ( - IN USB_XHCI_INSTANCE *Xhc, - IN UINT32 Offset - ); /** Write the data to the XHCI door bell register. -- 2.18.0.windows.1