public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: shenglei <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH 13/26] MdeModulePkg UsbBotPei: Remove redundant functions
Date: Wed,  8 Aug 2018 16:46:59 +0800	[thread overview]
Message-ID: <20180808084712.34696-14-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com>

The functions that are never called have been removed.
They are PeiUsbSetConfiguration,PeiUsbSetDeviceAddress,
IsPortConnect,IsPortConnectChange,IsPortLowSpeedDeviceAttached
and PeiUsbGetDescriptor.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 190 ---------------------
 MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h |  98 -----------
 2 files changed, 288 deletions(-)

diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
index 4f20c71144..cd765c40c5 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c
@@ -17,92 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include "UsbPeim.h"
 #include "PeiUsbLib.h"
 
-/**
-  Get a given usb descriptor.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-  @param  Value              Request Value.
-  @param  Index              Request Index.
-  @param  DescriptorLength   Request descriptor Length.
-  @param  Descriptor         Request descriptor.
-
-
-  @retval EFI_SUCCESS        Usb descriptor is obtained successfully.
-  @retval EFI_DEVICE_ERROR   Cannot get the usb descriptor due to a hardware error.
-  @retval Others             Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbGetDescriptor (
-  IN  EFI_PEI_SERVICES         **PeiServices,
-  IN  PEI_USB_IO_PPI           *UsbIoPpi,
-  IN  UINT16                   Value,
-  IN  UINT16                   Index,
-  IN  UINT16                   DescriptorLength,
-  OUT VOID                     *Descriptor
-  )
-{
-  EFI_USB_DEVICE_REQUEST  DevReq;
-
-  ASSERT (UsbIoPpi != NULL);
-
-  DevReq.RequestType  = USB_DEV_GET_DESCRIPTOR_REQ_TYPE;
-  DevReq.Request      = USB_DEV_GET_DESCRIPTOR;
-  DevReq.Value        = Value;
-  DevReq.Index        = Index;
-  DevReq.Length       = DescriptorLength;
-
-  return UsbIoPpi->UsbControlTransfer (
-                     PeiServices,
-                     UsbIoPpi,
-                     &DevReq,
-                     EfiUsbDataIn,
-                     PcdGet32 (PcdUsbTransferTimeoutValue),
-                     Descriptor,
-                     DescriptorLength
-                     );
-}
-
-/**
-  Set a usb device with a specified address.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-  @param  AddressValue       The address to assign.
-
-  @retval EFI_SUCCESS        Usb device address is set successfully.
-  @retval EFI_DEVICE_ERROR   Cannot set the usb address due to a hardware error.
-  @retval Others             Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetDeviceAddress (
-  IN EFI_PEI_SERVICES         **PeiServices,
-  IN PEI_USB_IO_PPI           *UsbIoPpi,
-  IN UINT16                   AddressValue
-  )
-{
-  EFI_USB_DEVICE_REQUEST  DevReq;
-
-  ASSERT (UsbIoPpi != NULL);
-
-  DevReq.RequestType  = USB_DEV_SET_ADDRESS_REQ_TYPE;
-  DevReq.Request      = USB_DEV_SET_ADDRESS;
-  DevReq.Value        = AddressValue;
-  DevReq.Index        = 0;
-  DevReq.Length       = 0;
-
-  return UsbIoPpi->UsbControlTransfer (
-                     PeiServices,
-                     UsbIoPpi,
-                     &DevReq,
-                     EfiUsbNoData,
-                     PcdGet32 (PcdUsbTransferTimeoutValue),
-                     NULL,
-                     0
-                     );
-}
 
 /**
   Clear a given usb feature.
@@ -161,40 +75,6 @@ PeiUsbClearDeviceFeature (
                      );
 }
 
-/**
-  Configure a usb device to Configuration 1.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-
-  @retval EFI_SUCCESS       Usb device is set to use Configuration 1 successfully.
-  @retval EFI_DEVICE_ERROR  Cannot set the usb device due to a hardware error.
-  @retval Others            Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetConfiguration (
-  IN EFI_PEI_SERVICES         **PeiServices,
-  IN PEI_USB_IO_PPI           *UsbIoPpi
-  )
-{
-  EFI_USB_DEVICE_REQUEST  DevReq;
-  ZeroMem (&DevReq, sizeof (EFI_USB_DEVICE_REQUEST));
-
-  DevReq.RequestType  = USB_DEV_SET_CONFIGURATION_REQ_TYPE;
-  DevReq.Request      = USB_DEV_SET_CONFIGURATION;
-  DevReq.Value        = 1;
-
-  return UsbIoPpi->UsbControlTransfer (
-                     PeiServices,
-                     UsbIoPpi,
-                     &DevReq,
-                     EfiUsbNoData,
-                     PcdGet32 (PcdUsbTransferTimeoutValue),
-                     NULL,
-                     0
-                     );
-}
 
 /**
   Clear Endpoint Halt.
@@ -258,74 +138,4 @@ PeiUsbClearEndpointHalt (
   return Status;
 }
 
-/**
-  Judge if the port is connected with a usb device or not.
-
-  @param  PortStatus  The usb port status gotten.
 
-  @retval TRUE        A usb device is connected with the port.
-  @retval FALSE       No usb device is connected with the port.
-
-**/
-BOOLEAN
-IsPortConnect (
-  IN UINT16  PortStatus
-  )
-{
-  //
-  // return the bit 0 value of PortStatus
-  //
-  if ((PortStatus & USB_PORT_STAT_CONNECTION) != 0) {
-    return TRUE;
-  } else {
-    return FALSE;
-  }
-}
-
-/**
-  Judge if the port is connected with a low-speed usb device or not.
-
-  @param  PortStatus  The usb port status gotten.
-
-  @retval TRUE        A low-speed usb device is connected with the port.
-  @retval FALSE       No low-speed usb device is connected with the port.
-
-**/
-BOOLEAN
-IsPortLowSpeedDeviceAttached (
-  IN UINT16  PortStatus
-  )
-{
-  //
-  // return the bit 9 value of PortStatus
-  //
-  if ((PortStatus & USB_PORT_STAT_LOW_SPEED) != 0) {
-    return TRUE;
-  } else {
-    return FALSE;
-  }
-}
-
-/**
-  Judge if the port is in "connection change" status or not.
-
-  @param  PortChangeStatus  The usb port change status gotten.
-
-  @retval TRUE              The port is in "connection change" status.
-  @retval FALSE             The port is NOT in "connection change" status.
-
-**/
-BOOLEAN
-IsPortConnectChange (
-  IN UINT16  PortChangeStatus
-  )
-{
-  //
-  // return the bit 0 value of PortChangeStatus
-  //
-  if ((PortChangeStatus & USB_PORT_STAT_C_CONNECTION) != 0) {
-    return TRUE;
-  } else {
-    return FALSE;
-  }
-}
diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
index 6d39b764eb..a160146cae 100644
--- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
+++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h
@@ -100,50 +100,6 @@ typedef enum {
   EfiUsbEndpoint
 } EFI_USB_RECIPIENT;
 
-/**
-  Get a given usb descriptor.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-  @param  Value              Request Value.
-  @param  Index              Request Index.
-  @param  DescriptorLength   Request descriptor Length.
-  @param  Descriptor         Request descriptor.
-
-
-  @retval EFI_SUCCESS       Usb descriptor is obtained successfully.
-  @retval EFI_DEVICE_ERROR  Cannot get the usb descriptor due to a hardware error.
-  @retval Others            Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbGetDescriptor (
-  IN  EFI_PEI_SERVICES         **PeiServices,
-  IN  PEI_USB_IO_PPI           *UsbIoPpi,
-  IN  UINT16                   Value,
-  IN  UINT16                   Index,
-  IN  UINT16                   DescriptorLength,
-  OUT VOID                     *Descriptor
-  );
-
-/**
-  Set a usb device with a specified address.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-  @param  AddressValue       The address to assign.
-
-  @retval EFI_SUCCESS        Usb device address is set successfully.
-  @retval EFI_DEVICE_ERROR   Cannot set the usb address due to a hardware error.
-  @retval Others             Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetDeviceAddress (
-  IN EFI_PEI_SERVICES         **PeiServices,
-  IN PEI_USB_IO_PPI           *UsbIoPpi,
-  IN UINT16                   AddressValue
-  );
 
 /**
   Clear a given usb feature.
@@ -168,22 +124,6 @@ PeiUsbClearDeviceFeature (
   IN UINT16                   Target
   );
 
-/**
-  Configure a usb device to Configuration 1.
-
-  @param  PeiServices        General-purpose services that are available to every PEIM.
-  @param  UsbIoPpi           Indicates the PEI_USB_IO_PPI instance.
-
-  @retval EFI_SUCCESS        Usb device is set to use Configuration 1 successfully.
-  @retval EFI_DEVICE_ERROR   Cannot set the usb device due to a hardware error.
-  @retval Others             Other failure occurs.
-
-**/
-EFI_STATUS
-PeiUsbSetConfiguration (
-  IN EFI_PEI_SERVICES         **PeiServices,
-  IN PEI_USB_IO_PPI           *UsbIoPpi
-  );
 
 /**
   Clear Endpoint Halt.
@@ -204,45 +144,7 @@ PeiUsbClearEndpointHalt (
   IN UINT8                    EndpointAddress
   );
 
-/**
-  Judge if the port is connected with a usb device or not.
-
-  @param  PortStatus  The usb port status gotten.
-
-  @retval TRUE        A usb device is connected with the port.
-  @retval FALSE       No usb device is connected with the port.
-
-**/
-BOOLEAN
-IsPortConnect (
-  IN UINT16  PortStatus
-  );
-
-/**
-  Judge if the port is connected with a low-speed usb device or not.
-
-  @param  PortStatus  The usb port status gotten.
 
-  @retval TRUE        A low-speed usb device is connected with the port.
-  @retval FALSE       No low-speed usb device is connected with the port.
 
-**/
-BOOLEAN
-IsPortLowSpeedDeviceAttached (
-  IN UINT16  PortStatus
-  );
 
-/**
-  Judge if the port is in "connection change" status or not.
-
-  @param  PortChangeStatus  The usb port change status gotten.
-
-  @retval TRUE              The port is in "connection change" status.
-  @retval FALSE             The port is NOT in "connection change" status.
-
-**/
-BOOLEAN
-IsPortConnectChange (
-  IN UINT16  PortChangeStatus
-  );
 #endif
-- 
2.18.0.windows.1



  parent reply	other threads:[~2018-08-08  8:47 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  8:46 [PATCH 00/26] MdeModulePkg Remove redundant functions shenglei
2018-08-08  8:46 ` [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function shenglei
2018-08-09 10:10   ` Zeng, Star
2018-08-10  9:13     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 02/26] MdeModulePkg UiApp: Remove redundant functions shenglei
2018-08-08 18:06   ` Laszlo Ersek
2018-08-09  3:25     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 03/26] MdeModulePkg AtaAtapiPassThru: " shenglei
2018-08-08 18:11   ` Laszlo Ersek
2018-08-09 10:15     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 04/26] MdeModulePkg EhciDxe: " shenglei
2018-08-08 18:08   ` Laszlo Ersek
2018-08-09  3:14   ` Ni, Ruiyu
2018-08-09 10:18   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 05/26] MdeModulePkg NvmExpressDxe: " shenglei
2018-08-09 10:19   ` Zeng, Star
2018-08-09 13:33   ` Laszlo Ersek
2018-08-10  2:45   ` Wu, Hao A
2018-08-08  8:46 ` [PATCH 06/26] MdeModulePkg PciBusDxe: " shenglei
2018-08-09  3:09   ` Ni, Ruiyu
2018-08-09 13:35   ` Laszlo Ersek
2018-08-10  8:54   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 07/26] MdeModulePkg SdMmcPciHcDxe: " shenglei
2018-08-08  8:46 ` [PATCH 08/26] MdeModulePkg UhciPei: " shenglei
2018-08-09  3:10   ` Ni, Ruiyu
2018-08-10  8:57   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 09/26] MdeModulePkg XhciDxe: " shenglei
2018-08-09  3:09   ` Ni, Ruiyu
2018-08-09 13:47   ` Laszlo Ersek
2018-08-10  9:01   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 10/26] MdeModulePkg XhciPei: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-10  9:01   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 11/26] MdeModulePkg UfsBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:04     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 12/26] MdeModulePkg UfsPassThruDxe: " shenglei
2018-08-10  2:45   ` Wu, Hao A
2018-08-10  9:05   ` Zeng, Star
2018-08-08  8:46 ` shenglei [this message]
2018-08-10  9:08   ` [PATCH 13/26] MdeModulePkg UsbBotPei: " Zeng, Star
2018-08-08  8:47 ` [PATCH 14/26] MdeModulePkg UsbBusDxe: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09 13:52   ` Laszlo Ersek
2018-08-10  9:09   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 15/26] MdeModulePkg UsbBusPei: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-10  9:08   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 16/26] MdeModulePkg Core/Dxe: " shenglei
2018-08-09  3:10   ` Ni, Ruiyu
2018-08-09  3:43     ` Wang, Jian J
2018-08-09 13:56   ` Laszlo Ersek
2018-08-10  9:10   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 17/26] MdeModulePkg PiSmmCore: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09  3:44     ` Wang, Jian J
2018-08-09 14:07   ` Laszlo Ersek
2018-08-10  9:12   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09 14:10   ` Laszlo Ersek
2018-08-10  9:15   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 19/26] MdeModulePkg EmmcBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:16     ` Zeng, Star
2018-08-08  8:47 ` [PATCH 20/26] MdeModulePkg SdBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:16     ` Zeng, Star
2018-08-08  8:47 ` [PATCH 21/26] MdeModulePkg TerminalDxe: " shenglei
2018-08-09  3:13   ` Ni, Ruiyu
2018-08-09 10:25   ` Zeng, Star
2018-08-10  9:14     ` Zeng, Star
2018-08-09 14:12   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: " shenglei
2018-08-09 10:23   ` Zeng, Star
2018-08-10  9:14     ` Zeng, Star
2018-08-09 14:15   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 23/26] MdeModulePkg Ip4Dxe: " shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:16   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 24/26] MdeModulePkg IScsiDxe: " shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:18   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 25/26] MdeModulePkg Tcp4Dxe: Remove redundant functions shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:21   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 26/26] MdeModulePkg SetupBrowserDxe: Remove a redundant function shenglei
2018-08-09 10:22   ` Zeng, Star
2018-08-09 14:26   ` Laszlo Ersek
2018-08-08 14:55 ` [PATCH 00/26] MdeModulePkg Remove redundant functions Leif Lindholm
2018-08-08 16:05   ` Carsey, Jaben
2018-08-08 17:21     ` Laszlo Ersek
2018-08-09  3:44       ` Zeng, Star
2018-08-09  3:33   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808084712.34696-14-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox