From: shenglei <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH 04/26] MdeModulePkg EhciDxe: Remove redundant functions
Date: Wed, 8 Aug 2018 16:46:50 +0800 [thread overview]
Message-ID: <20180808084712.34696-5-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com>
The functions that are never called have been removed.
They are EhcDumpRegs,EhcDisableAsyncSchd and EhcDisablePeriodSchd
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 ---------------
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 ------
MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 ------------------------
3 files changed, 82 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
index 76368b4748..71755d421b 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c
@@ -228,31 +228,4 @@ EhcDumpBuf (
DEBUG ((EFI_D_VERBOSE, "\n"));
}
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- )
-{
- UINT8 Index;
-
- DEBUG ((EFI_D_VERBOSE, " EHC_CAPLENGTH_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_CAPLENGTH_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCSPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCSPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_HCCPARAMS_OFFSET = 0x%08x\n", EhcReadCapRegister (Ehc, EHC_HCCPARAMS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBCMD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBCMD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBSTS_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBSTS_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_USBINTR_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_USBINTR_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRINDEX_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRINDEX_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CTRLDSSEG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CTRLDSSEG_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_FRAME_BASE_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_FRAME_BASE_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_ASYNC_HEAD_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_ASYNC_HEAD_OFFSET)));
- DEBUG ((EFI_D_VERBOSE, " EHC_CONFIG_FLAG_OFFSET = 0x%08x\n", EhcReadOpReg (Ehc, EHC_CONFIG_FLAG_OFFSET)));
- for (Index = 0; Index < (UINT8) (Ehc->HcStructParams & HCSP_NPORTS); Index++) {
- DEBUG ((EFI_D_VERBOSE, " EHC_PORT_STAT_OFFSET(%d) = 0x%08x\n", Index, EhcReadOpReg (Ehc, EHC_PORT_STAT_OFFSET + (4 * Index))));
- }
-}
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
index bc84bb7864..a64b0551a0 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h
@@ -61,15 +61,4 @@ EhcDumpBuf (
);
-/**
- Dump the EHCI status registers.
-
- @param Ehc USB EHCI Host Controller instance
-
-**/
-VOID
-EhcDumpRegs (
- IN USB2_HC_DEV *Ehc
- );
-
#endif
diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
index 34836eccf5..59752d1bdc 100644
--- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
+++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c
@@ -372,29 +372,7 @@ EhcEnablePeriodSchd (
}
-/**
- Disable periodic schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS Periodic schedule is disabled.
- @retval EFI_DEVICE_ERROR Fail to disable periodic schedule.
-
-**/
-EFI_STATUS
-EhcDisablePeriodSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_PERIOD);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_PERIOD_ENABLED, FALSE, Timeout);
- return Status;
-}
@@ -424,29 +402,7 @@ EhcEnableAsyncSchd (
-/**
- Disable asynchrounous schedule.
- @param Ehc The EHCI device.
- @param Timeout Time to wait before abort (in millisecond, ms).
-
- @retval EFI_SUCCESS The asynchronous schedule is disabled.
- @return Others Failed to disable the asynchronous schedule.
-
-**/
-EFI_STATUS
-EhcDisableAsyncSchd (
- IN USB2_HC_DEV *Ehc,
- IN UINT32 Timeout
- )
-{
- EFI_STATUS Status;
-
- EhcClearOpRegBit (Ehc, EHC_USBCMD_OFFSET, USBCMD_ENABLE_ASYNC);
-
- Status = EhcWaitOpRegBit (Ehc, EHC_USBSTS_OFFSET, USBSTS_ASYNC_ENABLED, FALSE, Timeout);
- return Status;
-}
--
2.18.0.windows.1
next prev parent reply other threads:[~2018-08-08 8:47 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 8:46 [PATCH 00/26] MdeModulePkg Remove redundant functions shenglei
2018-08-08 8:46 ` [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function shenglei
2018-08-09 10:10 ` Zeng, Star
2018-08-10 9:13 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 02/26] MdeModulePkg UiApp: Remove redundant functions shenglei
2018-08-08 18:06 ` Laszlo Ersek
2018-08-09 3:25 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 03/26] MdeModulePkg AtaAtapiPassThru: " shenglei
2018-08-08 18:11 ` Laszlo Ersek
2018-08-09 10:15 ` Zeng, Star
2018-08-08 8:46 ` shenglei [this message]
2018-08-08 18:08 ` [PATCH 04/26] MdeModulePkg EhciDxe: " Laszlo Ersek
2018-08-09 3:14 ` Ni, Ruiyu
2018-08-09 10:18 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 05/26] MdeModulePkg NvmExpressDxe: " shenglei
2018-08-09 10:19 ` Zeng, Star
2018-08-09 13:33 ` Laszlo Ersek
2018-08-10 2:45 ` Wu, Hao A
2018-08-08 8:46 ` [PATCH 06/26] MdeModulePkg PciBusDxe: " shenglei
2018-08-09 3:09 ` Ni, Ruiyu
2018-08-09 13:35 ` Laszlo Ersek
2018-08-10 8:54 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 07/26] MdeModulePkg SdMmcPciHcDxe: " shenglei
2018-08-08 8:46 ` [PATCH 08/26] MdeModulePkg UhciPei: " shenglei
2018-08-09 3:10 ` Ni, Ruiyu
2018-08-10 8:57 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 09/26] MdeModulePkg XhciDxe: " shenglei
2018-08-09 3:09 ` Ni, Ruiyu
2018-08-09 13:47 ` Laszlo Ersek
2018-08-10 9:01 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 10/26] MdeModulePkg XhciPei: " shenglei
2018-08-09 3:12 ` Ni, Ruiyu
2018-08-10 9:01 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 11/26] MdeModulePkg UfsBlockIoPei: " shenglei
2018-08-10 2:57 ` Wu, Hao A
2018-08-10 9:04 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 12/26] MdeModulePkg UfsPassThruDxe: " shenglei
2018-08-10 2:45 ` Wu, Hao A
2018-08-10 9:05 ` Zeng, Star
2018-08-08 8:46 ` [PATCH 13/26] MdeModulePkg UsbBotPei: " shenglei
2018-08-10 9:08 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 14/26] MdeModulePkg UsbBusDxe: " shenglei
2018-08-09 3:12 ` Ni, Ruiyu
2018-08-09 13:52 ` Laszlo Ersek
2018-08-10 9:09 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 15/26] MdeModulePkg UsbBusPei: " shenglei
2018-08-09 3:12 ` Ni, Ruiyu
2018-08-10 9:08 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 16/26] MdeModulePkg Core/Dxe: " shenglei
2018-08-09 3:10 ` Ni, Ruiyu
2018-08-09 3:43 ` Wang, Jian J
2018-08-09 13:56 ` Laszlo Ersek
2018-08-10 9:10 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 17/26] MdeModulePkg PiSmmCore: " shenglei
2018-08-09 3:12 ` Ni, Ruiyu
2018-08-09 3:44 ` Wang, Jian J
2018-08-09 14:07 ` Laszlo Ersek
2018-08-10 9:12 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function shenglei
2018-08-09 3:12 ` Ni, Ruiyu
2018-08-09 14:10 ` Laszlo Ersek
2018-08-10 9:15 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 19/26] MdeModulePkg EmmcBlockIoPei: " shenglei
2018-08-10 2:57 ` Wu, Hao A
2018-08-10 9:16 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 20/26] MdeModulePkg SdBlockIoPei: " shenglei
2018-08-10 2:57 ` Wu, Hao A
2018-08-10 9:16 ` Zeng, Star
2018-08-08 8:47 ` [PATCH 21/26] MdeModulePkg TerminalDxe: " shenglei
2018-08-09 3:13 ` Ni, Ruiyu
2018-08-09 10:25 ` Zeng, Star
2018-08-10 9:14 ` Zeng, Star
2018-08-09 14:12 ` Laszlo Ersek
2018-08-08 8:47 ` [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: " shenglei
2018-08-09 10:23 ` Zeng, Star
2018-08-10 9:14 ` Zeng, Star
2018-08-09 14:15 ` Laszlo Ersek
2018-08-08 8:47 ` [PATCH 23/26] MdeModulePkg Ip4Dxe: " shenglei
2018-08-09 10:21 ` Zeng, Star
2018-08-09 14:16 ` Laszlo Ersek
2018-08-08 8:47 ` [PATCH 24/26] MdeModulePkg IScsiDxe: " shenglei
2018-08-09 10:21 ` Zeng, Star
2018-08-09 14:18 ` Laszlo Ersek
2018-08-08 8:47 ` [PATCH 25/26] MdeModulePkg Tcp4Dxe: Remove redundant functions shenglei
2018-08-09 10:21 ` Zeng, Star
2018-08-09 14:21 ` Laszlo Ersek
2018-08-08 8:47 ` [PATCH 26/26] MdeModulePkg SetupBrowserDxe: Remove a redundant function shenglei
2018-08-09 10:22 ` Zeng, Star
2018-08-09 14:26 ` Laszlo Ersek
2018-08-08 14:55 ` [PATCH 00/26] MdeModulePkg Remove redundant functions Leif Lindholm
2018-08-08 16:05 ` Carsey, Jaben
2018-08-08 17:21 ` Laszlo Ersek
2018-08-09 3:44 ` Zeng, Star
2018-08-09 3:33 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808084712.34696-5-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox