public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: shenglei <shenglei.zhang@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions
Date: Wed,  8 Aug 2018 16:46:52 +0800	[thread overview]
Message-ID: <20180808084712.34696-7-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com>

The functions that are never called have been removed.
They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
 .../Bus/Pci/PciBusDxe/PciDeviceSupport.c      | 80 -------------------
 .../Bus/Pci/PciBusDxe/PciDeviceSupport.h      | 17 ----
 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c        | 41 ----------
 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h        | 21 -----
 4 files changed, 159 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c
index 48cf57a24f..f7039da992 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c
@@ -1061,85 +1061,5 @@ ActiveVGADeviceOnTheRootBridge (
 }
 
 
-/**
-  Get HPC PCI address according to its device path.
-
-  @param RootBridge           Root bridege Io instance.
-  @param RemainingDevicePath  Given searching device path.
-  @param PciAddress           Buffer holding searched result.
-
-  @retval EFI_SUCCESS         PCI address was stored in PciAddress
-  @retval EFI_NOT_FOUND       Can not find the specific device path.
-
-**/
-EFI_STATUS
-GetHpcPciAddressFromRootBridge (
-  IN  PCI_IO_DEVICE                    *RootBridge,
-  IN  EFI_DEVICE_PATH_PROTOCOL         *RemainingDevicePath,
-  OUT UINT64                           *PciAddress
-  )
-{
-  EFI_DEV_PATH_PTR          Node;
-  PCI_IO_DEVICE             *Temp;
-  EFI_DEVICE_PATH_PROTOCOL  *CurrentDevicePath;
-  LIST_ENTRY                *CurrentLink;
-  BOOLEAN                   MisMatch;
-
-  MisMatch          = FALSE;
-
-  CurrentDevicePath = RemainingDevicePath;
-  Node.DevPath      = CurrentDevicePath;
-  Temp              = NULL;
-
-  while (!IsDevicePathEnd (CurrentDevicePath)) {
-
-    CurrentLink   = RootBridge->ChildList.ForwardLink;
-    Node.DevPath  = CurrentDevicePath;
-
-    while (CurrentLink != NULL && CurrentLink != &RootBridge->ChildList) {
-      Temp = PCI_IO_DEVICE_FROM_LINK (CurrentLink);
-
-      if (Node.Pci->Device   == Temp->DeviceNumber &&
-          Node.Pci->Function == Temp->FunctionNumber) {
-        RootBridge = Temp;
-        break;
-      }
-
-      CurrentLink = CurrentLink->ForwardLink;
-    }
-
-    //
-    // Check if we find the bridge
-    //
-    if (CurrentLink == &RootBridge->ChildList) {
-
-      MisMatch = TRUE;
-      break;
-
-    }
-
-    CurrentDevicePath = NextDevicePathNode (CurrentDevicePath);
-  }
-
-  if (MisMatch) {
-
-    CurrentDevicePath = NextDevicePathNode (CurrentDevicePath);
-
-    if (IsDevicePathEnd (CurrentDevicePath)) {
-      *PciAddress = EFI_PCI_ADDRESS (RootBridge->BusNumber, Node.Pci->Device, Node.Pci->Function, 0);
-      return EFI_SUCCESS;
-    }
-
-    return EFI_NOT_FOUND;
-  }
 
-  if (Temp != NULL) {
-    *PciAddress = EFI_PCI_ADDRESS (Temp->BusNumber, Temp->DeviceNumber, Temp->FunctionNumber, 0);
-  } else {
-    return EFI_NOT_FOUND;
-  }
-
-  return EFI_SUCCESS;
-
-}
 
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h
index 1a01e72b1e..c282381f85 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h
@@ -255,23 +255,6 @@ ActiveVGADeviceOnTheRootBridge (
   IN PCI_IO_DEVICE        *RootBridge
   );
 
-/**
-  Get HPC PCI address according to its device path.
-
-  @param RootBridge           Root bridege Io instance.
-  @param RemainingDevicePath  Given searching device path.
-  @param PciAddress           Buffer holding searched result.
-
-  @retval EFI_SUCCESS         PCI address was stored in PciAddress.
-  @retval EFI_NOT_FOUND       Can not find the specific device path.
-
-**/
-EFI_STATUS
-GetHpcPciAddressFromRootBridge (
-  IN  PCI_IO_DEVICE                    *RootBridge,
-  IN  EFI_DEVICE_PATH_PROTOCOL         *RemainingDevicePath,
-  OUT UINT64                           *PciAddress
-  );
 
 /**
   Destroy a pci device node.
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
index 87b0b9884a..291578c63c 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
@@ -2061,47 +2061,6 @@ PciIoSetBarAttributes (
   return EFI_SUCCESS;
 }
 
-/**
-  Program parent bridge's attribute recurrently.
-
-  @param PciIoDevice  Child Pci device instance
-  @param Operation    The operation to perform on the attributes for this PCI controller.
-  @param Attributes   The mask of attributes that are used for Set, Enable, and Disable
-                      operations.
-
-  @retval EFI_SUCCESS           The operation on the PCI controller's attributes was completed.
-  @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
-  @retval EFI_UNSUPPORTED       one or more of the bits set in
-                                Attributes are not supported by this PCI controller or one of
-                                its parent bridges when Operation is Set, Enable or Disable.
-
-**/
-EFI_STATUS
-UpStreamBridgesAttributes (
-  IN PCI_IO_DEVICE                            *PciIoDevice,
-  IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION  Operation,
-  IN UINT64                                   Attributes
-  )
-{
-  PCI_IO_DEVICE       *Parent;
-  EFI_PCI_IO_PROTOCOL *PciIo;
-
-  Parent = PciIoDevice->Parent;
-
-  while (Parent != NULL && IS_PCI_BRIDGE (&Parent->Pci)) {
-
-    //
-    // Get the PciIo Protocol
-    //
-    PciIo = &Parent->PciIo;
-
-    PciIo->Attributes (PciIo, Operation, Attributes, NULL);
-
-    Parent = Parent->Parent;
-  }
-
-  return EFI_SUCCESS;
-}
 
 /**
   Test whether two Pci devices has same parent bridge.
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
index b7e38ded3f..69e7c32881 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
@@ -646,27 +646,6 @@ PciIoSetBarAttributes (
   IN OUT UINT64                       *Length
   );
 
-/**
-  Program parent bridge's attribute recurrently.
-
-  @param PciIoDevice  Child Pci device instance
-  @param Operation    The operation to perform on the attributes for this PCI controller.
-  @param Attributes   The mask of attributes that are used for Set, Enable, and Disable
-                      operations.
-
-  @retval EFI_SUCCESS           The operation on the PCI controller's attributes was completed.
-  @retval EFI_INVALID_PARAMETER One or more parameters are invalid.
-  @retval EFI_UNSUPPORTED       one or more of the bits set in
-                                Attributes are not supported by this PCI controller or one of
-                                its parent bridges when Operation is Set, Enable or Disable.
-
-**/
-EFI_STATUS
-UpStreamBridgesAttributes (
-  IN PCI_IO_DEVICE                            *PciIoDevice,
-  IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION  Operation,
-  IN UINT64                                   Attributes
-  );
 
 /**
   Test whether two Pci devices has same parent bridge.
-- 
2.18.0.windows.1



  parent reply	other threads:[~2018-08-08  8:47 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  8:46 [PATCH 00/26] MdeModulePkg Remove redundant functions shenglei
2018-08-08  8:46 ` [PATCH 01/26] MdeModulePkg CapsuleApp: Remove a redundant function shenglei
2018-08-09 10:10   ` Zeng, Star
2018-08-10  9:13     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 02/26] MdeModulePkg UiApp: Remove redundant functions shenglei
2018-08-08 18:06   ` Laszlo Ersek
2018-08-09  3:25     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 03/26] MdeModulePkg AtaAtapiPassThru: " shenglei
2018-08-08 18:11   ` Laszlo Ersek
2018-08-09 10:15     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 04/26] MdeModulePkg EhciDxe: " shenglei
2018-08-08 18:08   ` Laszlo Ersek
2018-08-09  3:14   ` Ni, Ruiyu
2018-08-09 10:18   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 05/26] MdeModulePkg NvmExpressDxe: " shenglei
2018-08-09 10:19   ` Zeng, Star
2018-08-09 13:33   ` Laszlo Ersek
2018-08-10  2:45   ` Wu, Hao A
2018-08-08  8:46 ` shenglei [this message]
2018-08-09  3:09   ` [PATCH 06/26] MdeModulePkg PciBusDxe: " Ni, Ruiyu
2018-08-09 13:35   ` Laszlo Ersek
2018-08-10  8:54   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 07/26] MdeModulePkg SdMmcPciHcDxe: " shenglei
2018-08-08  8:46 ` [PATCH 08/26] MdeModulePkg UhciPei: " shenglei
2018-08-09  3:10   ` Ni, Ruiyu
2018-08-10  8:57   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 09/26] MdeModulePkg XhciDxe: " shenglei
2018-08-09  3:09   ` Ni, Ruiyu
2018-08-09 13:47   ` Laszlo Ersek
2018-08-10  9:01   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 10/26] MdeModulePkg XhciPei: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-10  9:01   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 11/26] MdeModulePkg UfsBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:04     ` Zeng, Star
2018-08-08  8:46 ` [PATCH 12/26] MdeModulePkg UfsPassThruDxe: " shenglei
2018-08-10  2:45   ` Wu, Hao A
2018-08-10  9:05   ` Zeng, Star
2018-08-08  8:46 ` [PATCH 13/26] MdeModulePkg UsbBotPei: " shenglei
2018-08-10  9:08   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 14/26] MdeModulePkg UsbBusDxe: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09 13:52   ` Laszlo Ersek
2018-08-10  9:09   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 15/26] MdeModulePkg UsbBusPei: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-10  9:08   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 16/26] MdeModulePkg Core/Dxe: " shenglei
2018-08-09  3:10   ` Ni, Ruiyu
2018-08-09  3:43     ` Wang, Jian J
2018-08-09 13:56   ` Laszlo Ersek
2018-08-10  9:10   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 17/26] MdeModulePkg PiSmmCore: " shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09  3:44     ` Wang, Jian J
2018-08-09 14:07   ` Laszlo Ersek
2018-08-10  9:12   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function shenglei
2018-08-09  3:12   ` Ni, Ruiyu
2018-08-09 14:10   ` Laszlo Ersek
2018-08-10  9:15   ` Zeng, Star
2018-08-08  8:47 ` [PATCH 19/26] MdeModulePkg EmmcBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:16     ` Zeng, Star
2018-08-08  8:47 ` [PATCH 20/26] MdeModulePkg SdBlockIoPei: " shenglei
2018-08-10  2:57   ` Wu, Hao A
2018-08-10  9:16     ` Zeng, Star
2018-08-08  8:47 ` [PATCH 21/26] MdeModulePkg TerminalDxe: " shenglei
2018-08-09  3:13   ` Ni, Ruiyu
2018-08-09 10:25   ` Zeng, Star
2018-08-10  9:14     ` Zeng, Star
2018-08-09 14:12   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 22/26] MdeModulePkg HiiDatabaseDxe: " shenglei
2018-08-09 10:23   ` Zeng, Star
2018-08-10  9:14     ` Zeng, Star
2018-08-09 14:15   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 23/26] MdeModulePkg Ip4Dxe: " shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:16   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 24/26] MdeModulePkg IScsiDxe: " shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:18   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 25/26] MdeModulePkg Tcp4Dxe: Remove redundant functions shenglei
2018-08-09 10:21   ` Zeng, Star
2018-08-09 14:21   ` Laszlo Ersek
2018-08-08  8:47 ` [PATCH 26/26] MdeModulePkg SetupBrowserDxe: Remove a redundant function shenglei
2018-08-09 10:22   ` Zeng, Star
2018-08-09 14:26   ` Laszlo Ersek
2018-08-08 14:55 ` [PATCH 00/26] MdeModulePkg Remove redundant functions Leif Lindholm
2018-08-08 16:05   ` Carsey, Jaben
2018-08-08 17:21     ` Laszlo Ersek
2018-08-09  3:44       ` Zeng, Star
2018-08-09  3:33   ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808084712.34696-7-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox