From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ming Huang <ming.huang@linaro.org>
Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org,
graeme.gregory@linaro.org, ard.biesheuvel@linaro.org,
guoheyi@huawei.com, wanghuiqiang@huawei.com,
huangming23@huawei.com, zhangjinsong2@huawei.com,
huangdaode@hisilicon.com, john.garry@huawei.com,
xinliang.liu@linaro.org
Subject: Re: [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge
Date: Wed, 8 Aug 2018 09:59:30 +0100 [thread overview]
Message-ID: <20180808085930.i2dk7kqwrfbgjmrd@bivouac.eciton.net> (raw)
In-Reply-To: <20180805023855.10732-1-ming.huang@linaro.org>
On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1. Remove D02 platform;
> 2. Fix a D03 issue about switch generic PciHostBridge;
>
> Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rm-D02
>
> Ming Huang (2):
> Hisilicon/D02: Remove D02 platform
> Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue
>
> Platform/Hisilicon/D02/Pv660D02.dec | 44 --
> Platform/Hisilicon/D02/Pv660D02.dsc | 425 ------------------
> Platform/Hisilicon/D03/D03.dsc | 4 +-
> Platform/Hisilicon/D02/Pv660D02.fdf | 321 -------------
> .../D02/EarlyConfigPeim/EarlyConfigPeim.inf | 53 ---
> .../D02/FdtUpdateLibD02/FdtUpdateLib.inf | 43 --
> .../Library/OemMiscLibD02/OemMiscLibD02.inf | 45 --
> .../Library/PlatformPciLib/PlatformPciLib.inf | 182 --------
> .../D02/OemNicConfigD02/OemNicConfigD02.inf | 50 ---
> .../Hisilicon/D02/Include/Library/CpldD02.h | 34 --
> .../D02/OemNicConfigD02/OemNicConfig.h | 31 --
> .../D02/EarlyConfigPeim/EarlyConfigPeim.c | 94 ----
> .../D02/FdtUpdateLibD02/FdtUpdateLib.c | 341 --------------
> .../Library/OemMiscLibD02/BoardFeatureD02.c | 105 -----
> .../D02/Library/OemMiscLibD02/OemMiscLibD02.c | 77 ----
> .../Library/PlatformPciLib/PlatformPciLib.c | 147 ------
> .../D02/OemNicConfigD02/OemNicConfigD02.c | 173 -------
> .../Drivers/AcpiPlatformDxe/EthMac.c | 4 +-
> .../OemMiscLibD02/BoardFeatureD02Strings.uni | Bin 1796 -> 0 bytes
I see you've added the orderfile - excellent!
In future, please follow the --stat and --stat-grap-width of the
instructions from
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
as well please :)
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as d346a222df..478282ea28.
NOTE: I changed the order of the patches so that the one that fixed a
problem in a remaining platform comes first.
/
Leif
> 19 files changed, 3 insertions(+), 2170 deletions(-)
> delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dec
> delete mode 100644 Platform/Hisilicon/D02/Pv660D02.dsc
> delete mode 100644 Platform/Hisilicon/D02/Pv660D02.fdf
> delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.inf
> delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.inf
> delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.inf
> delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.inf
> delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.inf
> delete mode 100644 Platform/Hisilicon/D02/Include/Library/CpldD02.h
> delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfig.h
> delete mode 100644 Platform/Hisilicon/D02/EarlyConfigPeim/EarlyConfigPeim.c
> delete mode 100644 Platform/Hisilicon/D02/FdtUpdateLibD02/FdtUpdateLib.c
> delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02.c
> delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/OemMiscLibD02.c
> delete mode 100644 Platform/Hisilicon/D02/Library/PlatformPciLib/PlatformPciLib.c
> delete mode 100644 Platform/Hisilicon/D02/OemNicConfigD02/OemNicConfigD02.c
> delete mode 100644 Platform/Hisilicon/D02/Library/OemMiscLibD02/BoardFeatureD02Strings.uni
>
> --
> 2.17.0
>
prev parent reply other threads:[~2018-08-08 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 2:38 [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge Ming Huang
2018-08-05 2:38 ` [PATCH edk2-platforms v1 1/2] Hisilicon/D02: Remove D02 platform Ming Huang
2018-08-05 2:38 ` [PATCH edk2-platforms v1 2/2] Platform/Hisilicon/D03: Fix PlatformPciLib path wrong issue Ming Huang
2018-08-06 10:57 ` [PATCH edk2-platforms v1 0/2] Modify following Switch generic PciHostBridge Leif Lindholm
2018-08-07 15:31 ` Ming
2018-08-08 8:59 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808085930.i2dk7kqwrfbgjmrd@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox