From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 19BF5210DF774 for ; Wed, 8 Aug 2018 03:01:20 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id h4-v6so959910edi.6 for ; Wed, 08 Aug 2018 03:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=iL3Nv09qomfU8Whe1WuzuV290ATmNyWo3HFtk3FIWck=; b=awrk/XG1njB5F+wkELjjw65+0ofJQs2CR+VB0Xv7DjxwMlrs9+3vM+aWFKeihU5PNL PQlWnMBAQPmtzv7C+2yevurqdBbgFhKcoXdWUHspMrpzCJJyIZkYeORKSR4ja42RS4rK vjKrdHfueHUl/V7Zdxf5TfOoK3/vGyKaSANDg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=iL3Nv09qomfU8Whe1WuzuV290ATmNyWo3HFtk3FIWck=; b=LTVZYdhfTFXFsKiFCkyRGukTKb+NPCYPUTj6rP2jYRguN5rf57ReD6KmdkXnYJNoPn L8svQSzzYCYKWrREEOQtX0A7RBGzQSxOW0nEseO9JRgv8sEJmvTKja2Kr9IZBj+tgnz9 obGrr1hVnVh0W606dwb48LSZgJgv2gGcsOS1aNPW2nzx7/5kPYnq/50DyeZGXujEaPRF UwsSWj79aMrlheylmqkuR3my/uL/7vPH9FDcLloDJyjBrRBPs/DtXuekdsbrFN5SQbit lc6WkygdlNbrDQjrEApwYKcg2reu9+aVuV6bW/FjvHGVUqcoffliRWEnOZJng+hzxlyu icog== X-Gm-Message-State: AOUpUlG6ZN2j/xxeZAQAKtdAWHpYW4S2AOyFVA1tkJcv6Ui6pZ4pMw4s 3kaI/AIET4UPDvKxPlAztrA9dg== X-Google-Smtp-Source: AA+uWPwgmJ5BjjXZo0ew7UN4DUqlWFWsAHbwNfRihwe1VnbeWOrw8Ad9i10R80akozIu+tISWmufVQ== X-Received: by 2002:a50:8561:: with SMTP id 88-v6mr2377651edr.181.1533722477647; Wed, 08 Aug 2018 03:01:17 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q26-v6sm1997574eda.35.2018.08.08.03.01.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 03:01:16 -0700 (PDT) Date: Wed, 8 Aug 2018 11:01:14 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Yan Zhang , Heyi Guo Message-ID: <20180808100114.z32c5vupmhaopkfc@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-10-ming.huang@linaro.org> <20180802181003.3lxlcbb6kya2vppa@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 09/38] Hisilicon/D06: Add Debug Serial Port Init Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 10:01:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Aug 08, 2018 at 03:37:23PM +0800, Ming wrote: > > > 在 8/3/2018 2:10 AM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:53PM +0800, Ming Huang wrote: > >> From: Yan Zhang > >> > >> Debug serial port init driver is added to initilize debug > >> serial port. > > > > What is special about this platform that makes it require a separate > > initialization function for the PL011? > > > > We have two physical PL011 serial ports on the board, one for serial port > console (described by ACPI SPCR) and the other for standard debug port > (described by ACPI DBG2). This driver is to initialize the debug UART, > not the serial console. OK, that makes sense, but was not clear from the commit message. Can you add a note about what sort of debug this is used for? (Is it just the DEBUG printouts, is it a serial debugger connection, ...) / Leif > Ming > > > / > > Leif > > > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Yan Zhang > >> Signed-off-by: Ming Huang > >> Signed-off-by: Heyi Guo > >> --- > >> Platform/Hisilicon/D06/D06.dsc | 1 + > >> Platform/Hisilicon/D06/D06.fdf | 1 + > >> Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.c | 64 ++++++++++++++++++++ > >> Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf | 48 +++++++++++++++ > >> 4 files changed, 114 insertions(+) > >> > >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > >> index f4dfef1087..3f6f1ff20d 100644 > >> --- a/Platform/Hisilicon/D06/D06.dsc > >> +++ b/Platform/Hisilicon/D06/D06.dsc > >> @@ -426,6 +426,7 @@ > >> # Memory test > >> # > >> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf > >> + Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf > >> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > >> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > >> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > >> diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf > >> index 2730eb42a9..bc016a32ae 100644 > >> --- a/Platform/Hisilicon/D06/D06.fdf > >> +++ b/Platform/Hisilicon/D06/D06.fdf > >> @@ -303,6 +303,7 @@ READ_LOCK_STATUS = TRUE > >> INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > >> INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > >> > >> + INF Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf > >> INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > >> # > >> # Build Shell from latest source code instead of prebuilt binary > >> diff --git a/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.c b/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.c > >> new file mode 100644 > >> index 0000000000..b7233eed21 > >> --- /dev/null > >> +++ b/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.c > >> @@ -0,0 +1,64 @@ > >> +/** @file > >> + > >> + Copyright (c) 2016 - 2018, Hisilicon Limited. All rights reserved. > >> + Copyright (c) 2016 - 2018, Linaro Limited. All rights reserved. > >> + > >> + This program and the accompanying materials > >> + are licensed and made available under the terms and conditions of the BSD License > >> + which accompanies this distribution. The full text of the license may be found at > >> + http://opensource.org/licenses/bsd-license.php > >> + > >> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> + > >> +**/ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +RETURN_STATUS > >> +EFIAPI > >> +DebugSerialPortInitialize ( > >> + VOID > >> + ) > >> +{ > >> + UINT64 BaudRate; > >> + UINT32 ReceiveFifoDepth; > >> + EFI_PARITY_TYPE Parity; > >> + UINT8 DataBits; > >> + EFI_STOP_BITS_TYPE StopBits; > >> + > >> + BaudRate = FixedPcdGet64 (PcdUartDefaultBaudRate); > >> + ReceiveFifoDepth = 0; // Use default FIFO depth > >> + Parity = (EFI_PARITY_TYPE)FixedPcdGet8 (PcdUartDefaultParity); > >> + DataBits = FixedPcdGet8 (PcdUartDefaultDataBits); > >> + StopBits = (EFI_STOP_BITS_TYPE) FixedPcdGet8 (PcdUartDefaultStopBits); > >> + return PL011UartInitializePort ( > >> + (UINTN)FixedPcdGet64 (PcdSerialDbgRegisterBase), > >> + FixedPcdGet32 (PL011UartClkInHz), > >> + &BaudRate, > >> + &ReceiveFifoDepth, > >> + &Parity, > >> + &DataBits, > >> + &StopBits > >> + ); > >> +} > >> + > >> +EFI_STATUS > >> +SerialPortEntry ( > >> + IN EFI_HANDLE ImageHandle, > >> + IN EFI_SYSTEM_TABLE *SystemTable > >> + ) > >> +{ > >> + EFI_STATUS Status; > >> + Status = DebugSerialPortInitialize (); > >> + if (EFI_ERROR (Status)) { > >> + DEBUG ((DEBUG_ERROR, "CPU1 TB serial port init ERROR: %r\n", Status)); > >> + } > >> + return EFI_SUCCESS; > >> +} > >> + > >> diff --git a/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf b/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf > >> new file mode 100644 > >> index 0000000000..8c91bdf0f4 > >> --- /dev/null > >> +++ b/Silicon/Hisilicon/Hi1620/Drivers/Pl011DebugSerialPortInitDxe/Pl011DebugSerialPortInitDxe.inf > >> @@ -0,0 +1,48 @@ > >> +#/** @file > >> +# > >> +# Copyright (c) 2016 - 2018, Hisilicon Limited. All rights reserved. > >> +# Copyright (c) 2016 - 2018, Linaro Limited. All rights reserved. > >> +# > >> +# This program and the accompanying materials > >> +# are licensed and made available under the terms and conditions of the BSD License > >> +# which accompanies this distribution. The full text of the license may be found at > >> +# http://opensource.org/licenses/bsd-license.php > >> +# > >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> +# > >> +#**/ > >> + > >> +[Defines] > >> + INF_VERSION = 0x0001001A > >> + BASE_NAME = Pl011DebugSerialPortInitDxe > >> + FILE_GUID = 16D53E86-7EA4-47bd-861F-511EA9B8ABE0 > >> + MODULE_TYPE = DXE_DRIVER > >> + VERSION_STRING = 1.0 > >> + ENTRY_POINT = SerialPortEntry > >> + > >> +[Sources.common] > >> + Pl011DebugSerialPortInitDxe.c > >> + > >> + > >> +[Packages] > >> + ArmPlatformPkg/ArmPlatformPkg.dec > >> + MdeModulePkg/MdeModulePkg.dec > >> + MdePkg/MdePkg.dec > >> + Silicon/Hisilicon/HisiPkg.dec > >> + > >> +[LibraryClasses] > >> + BaseLib > >> + UefiDriverEntryPoint > >> + > >> +[Pcd] > >> + gArmPlatformTokenSpaceGuid.PL011UartClkInHz > >> + gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase > >> + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate > >> + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits > >> + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity > >> + gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits > >> + > >> +[Depex] > >> + TRUE > >> + > >> -- > >> 2.17.0 > >>