From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E6C0E210DF765 for ; Wed, 8 Aug 2018 05:57:11 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id o18-v6so2696047wmc.0 for ; Wed, 08 Aug 2018 05:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XqhkD5FzcCzHqGLYO/S12FRA1xCDb20OBcpyc4kEuQI=; b=IudttncHBpTXRNsdp8G8sagUb4kR6hQJEQSFsKKVXIDU0zFemZgVCsbAV5dIWGZuqE JTEIrXbT3DcqnQpK+MzmAXDz3zlh427I/dVZcxORoemKZSYDGFt/BAmlIEmtvd6hNpa6 n5OZRd2quBuAF2K3+ud6c96KAHt7FXBkW71P0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XqhkD5FzcCzHqGLYO/S12FRA1xCDb20OBcpyc4kEuQI=; b=e8R/Ei2C4eZi+pD93q4ThJPp/IqeA6D/Q4zksT4x29m51HbhZ0Ta4iV8v6WFk78zDX 2ochOUThWsIKOW0mycV4gVCWU1EzeLshjTKLesHcuTL9pCbfS7ozs+sVVuqDW96tahhP 1iA3BEnVDQVTaVBouCUnn1mV46YacK78PuxNX0XY1+l0rUt48RC8q+WYbgdt2ruV5rb3 yVLoc31JdjGcJOdTC8Qy4/ED2RRN5HoMQ4Py2qqJ2GHME5ojhrnAhemW7GqhZAEZ/PyC ZU2RmoKW6HYrtJ8xcXnYZxUF5Xl6VozwSSQQUdDHFYAoMtH5MRVDE0XtWIeTSsgEtt22 rQtw== X-Gm-Message-State: AOUpUlG4XFaI4rDb84qw1hVrFh+AkWNb6AWVJ+KuUsvj0VzZAJRV+Y1F hswbj8CefVtDVn59Wz6E44XfvQ== X-Google-Smtp-Source: AA+uWPyBZmsDBE/ZuGS89hupmSCDHAYeyE0yziaC1PhXX8jE03dyPSTYhmJFRKmd0tQVNuuYIUvqgw== X-Received: by 2002:a1c:ec9d:: with SMTP id h29-v6mr1894150wmi.94.1533733030397; Wed, 08 Aug 2018 05:57:10 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n12-v6sm2801726wrm.62.2018.08.08.05.57.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 05:57:09 -0700 (PDT) Date: Wed, 8 Aug 2018 13:57:07 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Sun Yuanchen , Heyi Guo Message-ID: <20180808125707.v5fesm5cwf75u27f@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-14-ming.huang@linaro.org> <20180803103715.ep6dquwyzx5xytqm@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 13/38] Silicon/Hisilicon/Acpi: Move some macro to PlatformArch.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 12:57:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Aug 08, 2018 at 08:22:27PM +0800, Ming wrote: > 在 8/3/2018 6:37 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:08:57PM +0800, Ming Huang wrote: > >> From: Sun Yuanchen > >> > >> ARM_ACPI_HEADER is used by a unify module in other Pkg, > > > > What other Pkg? > > HwPkg Then please say so in the commit message. > >> so move some macro to PlatformArch.h for unify D0x. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Sun Yuanchen > >> Signed-off-by: Ming Huang > >> Signed-off-by: Heyi Guo > > > > On the whole, I think this should be implemented for 1610/1616 > > separately, and then introduced in the first version of the 1620 > > header. > > do it in v2. Thanks. > >> diff --git a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h > >> index f2e931f30b..03e96cfd31 100644 > >> --- a/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h > >> +++ b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h > >> @@ -37,5 +37,29 @@ > >> > >> #define S1_BASE 0x40000000000 > >> > >> + > >> +// > >> +// ACPI table information used to initialize tables. > >> +// > >> +#define EFI_ACPI_ARM_OEM_ID 'H','I','S','I',' ',' ' // OEMID 6 bytes long > >> +#define EFI_ACPI_ARM_OEM_TABLE_ID SIGNATURE_64 ('H','I','P','0','6',' ',' ',' ') // OEM table id 8 bytes long > >> +#define EFI_ACPI_ARM_OEM_REVISION 0x00000000 > >> +#define EFI_ACPI_ARM_CREATOR_ID SIGNATURE_32 ('I','N','T','L') > > > > I realise this is just moving, but ... why are we claiming that Intel > > is the creator of these tables? > > I don't know the reason. I think this is a history mistake. Agreed. On the reviewer side also :) > CREATEOR_ID should be change to 'HISI' for 1620? Yes please, I think that would make more sense. It may be worth changing for 1610/1616 as well, but you need to discuss that internally. The code has had that value this long, so no need to resolve for the Linaro 18.08 release. / Leif