From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::232; helo=mail-wm0-x232.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9C53210E1294 for ; Wed, 8 Aug 2018 07:55:04 -0700 (PDT) Received: by mail-wm0-x232.google.com with SMTP id w24-v6so3082922wmc.1 for ; Wed, 08 Aug 2018 07:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sFIVSVDLHownQB4uFaHWFbnC7jjLUKEKnXnsA1anSNo=; b=OQl8XO85KWkR/peMcRP0TRFUKXGPH1iQa+wcP8IeKS/1YOLu8WoZSGu+r+sWGllrC6 Qj4MLmC3e/yEKue7wCisAeB7RoW/OiH3DDQ5UIwZSZhBmZJQWfAFWgmRTLF457aYqUS7 Gz2ixlc/2jEy2EB8eLRTEGsqMFhy9BswsK6vc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sFIVSVDLHownQB4uFaHWFbnC7jjLUKEKnXnsA1anSNo=; b=hybAkOdAAmBtt/6tpIhljXEvM7wHys5CgDc0msKyfn5a/WKnzMYcVPbfB5DB0ywQ6k 39+ipDisJkKF0FcR2CtzKGPKU4Qhcli/VlOqfVkvpGR9y5eE+oVCcXOWJNFrWc+5ohHB BfOJ37KOK+9AV9C2YGv3qdZtGd0kYdiKctXciro6PxdFz3DMEmcYVuWDaLC1Abq+DTSF FBkVFUNJjDUb6HW86ktl2+qGjfCikyQU/6CPWbaNXY/LouVpxyNSVxKQMWl2tNvpkC+z b64+jArSytKQTgutVllQtRDMb1nADPyOtFNbXVhTKaeWUKZyeNTXtbdsL33tMwF5JeUN gpzQ== X-Gm-Message-State: AOUpUlF39yywxBs5bIPFCOfL1fWY80iMvnId9Aw7aEqS04Bqc6Q7shb9 y/k4G07NHUYdhib56aEaXCHXJQ== X-Google-Smtp-Source: AA+uWPzUyyDdg51OB2qzdOh83JV5/+Bknl3JYwsTcnjOkfaMIh5PESVvfG1Q5dmRZTb9c20fUIrqmA== X-Received: by 2002:a1c:357:: with SMTP id 84-v6mr2076026wmd.8.1533740102871; Wed, 08 Aug 2018 07:55:02 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r140-v6sm11923609wmd.7.2018.08.08.07.55.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Aug 2018 07:55:01 -0700 (PDT) Date: Wed, 8 Aug 2018 15:55:00 +0100 From: Leif Lindholm To: shenglei Cc: edk2-devel@lists.01.org, Eric Dong , Star Zeng Message-ID: <20180808145500.sh4dt3rwwdgcern6@bivouac.eciton.net> References: <20180808084712.34696-1-shenglei.zhang@intel.com> MIME-Version: 1.0 In-Reply-To: <20180808084712.34696-1-shenglei.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 00/26] MdeModulePkg Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 14:55:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Eric, Star, On Wed, Aug 08, 2018 at 04:46:46PM +0800, shenglei wrote: > A lot of redundant functions which are never calld have been removed.I manually > search these fuctions in source files to make sure that they are not used elsewhere. > Also the MdeModulePkg was built to ensure that. I have no objection to this set, but it is quite invasive. So can we please ensure it does not get pushed until after the 201808 stable tag has been made? (Mike has just announced the quiet period.) Best Regards, Leif > shenglei (26): > MdeModulePkg CapsuleApp: Remove a redundant function > MdeModulePkg UiApp: Remove redundant functions > MdeModulePkg AtaAtapiPassThru: Remove redundant functions > MdeModulePkg EhciDxe: Remove redundant functions > MdeModulePkg NvmExpressDxe: Remove redundant functions > MdeModulePkg PciBusDxe: Remove redundant functions > MdeModulePkg SdMmcPciHcDxe: Remove redundant functions > MdeModulePkg UhciPei: Remove redundant functions > MdeModulePkg XhciDxe: Remove redundant functions > MdeModulePkg XhciPei: Remove redundant functions > MdeModulePkg UfsBlockIoPei: Remove redundant functions > MdeModulePkg UfsPassThruDxe: Remove redundant functions > MdeModulePkg UsbBotPei: Remove redundant functions > MdeModulePkg UsbBusDxe: Remove redundant functions > MdeModulePkg UsbBusPei: Remove redundant functions > MdeModulePkg Core/Dxe: Remove redundant functions > MdeModulePkg PiSmmCore: Remove redundant functions > MdeModulePkg Ps2KeyboardDxe: Remove a redundant function > MdeModulePkg EmmcBlockIoPei: Remove a redundant function > MdeModulePkg SdBlockIoPei: Remove a redundant function > MdeModulePkg TerminalDxe: Remove a redundant function > MdeModulePkg HiiDatabaseDxe: Remove a redundant function > MdeModulePkg Ip4Dxe: Remove a redundant function > MdeModulePkg IScsiDxe: Remove a redundant function > MdeModulePkg Tcp4Dxe: Remove redundant functions > MdeModulePkg SetupBrowserDxe: Remove a redundant function > > .../Application/CapsuleApp/CapsuleDump.c | 31 --- > MdeModulePkg/Application/UiApp/FrontPage.c | 40 --- > MdeModulePkg/Application/UiApp/Ui.h | 30 -- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 104 ------- > .../Bus/Ata/AtaAtapiPassThru/IdeMode.c | 257 ------------------ > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 26 -- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 12 - > MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 27 -- > MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.h | 11 - > MdeModulePkg/Bus/Pci/EhciDxe/EhciReg.c | 44 --- > .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 110 -------- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------ > .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 -- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 -- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 107 -------- > MdeModulePkg/Bus/Pci/UhciPei/DmaMem.c | 22 -- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 125 --------- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.h | 78 ------ > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 66 ----- > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.h | 28 -- > MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 24 -- > MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 22 -- > MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h | 14 - > .../Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 24 -- > MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 24 -- > .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 101 ------- > MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 24 -- > MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 180 ------------ > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 49 ---- > MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.c | 190 ------------- > MdeModulePkg/Bus/Usb/UsbBotPei/PeiUsbLib.h | 98 ------- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbHub.c | 68 ----- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 146 ---------- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 114 -------- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c | 39 --- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 18 -- > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 77 ------ > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 35 --- > MdeModulePkg/Core/Dxe/DxeMain.h | 13 - > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 22 -- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 78 ------ > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 166 ----------- > .../Core/PiSmmCore/MemoryAttributesTable.c | 131 --------- > MdeModulePkg/Core/PiSmmCore/Page.c | 121 --------- > .../Universal/Console/TerminalDxe/Terminal.h | 12 - > .../Console/TerminalDxe/TerminalConIn.c | 25 -- > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 47 ---- > .../Universal/Network/IScsiDxe/IScsiProto.c | 31 --- > .../Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 16 -- > .../Universal/Network/Tcp4Dxe/SockImpl.c | 35 --- > .../Universal/Network/Tcp4Dxe/SockInterface.c | 41 --- > .../Universal/Network/Tcp4Dxe/Socket.h | 32 --- > .../Universal/Network/Tcp4Dxe/Tcp4Option.c | 28 -- > .../Universal/Network/Tcp4Dxe/Tcp4Option.h | 15 - > .../Universal/SetupBrowserDxe/IfrParse.c | 33 --- > 56 files changed, 3370 deletions(-) > > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel