From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD659210E3DCE for ; Thu, 9 Aug 2018 05:27:42 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id y2-v6so23820wma.1 for ; Thu, 09 Aug 2018 05:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3TMuqu4OKQo1NkOXRI863u0DPCWvbBuZDLGWRUqMZwY=; b=kZZWo5nmTk67t9p39EgS7casHWkQf9soujxXUKCXi+rL9p5otNpSNtXruAchJnHQ9H TUtt1VoYntBVvvlixn6Et1er802Z38XL548nFWx67px3A9tTMhS7SuM9O9mQ639UmePW O0rzxdnRNVr0KkySiGXVjUYzG4JrC1JuK5WfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3TMuqu4OKQo1NkOXRI863u0DPCWvbBuZDLGWRUqMZwY=; b=Deqju+VpsGLp7PrNmCXJxlvoSyoh677K4HadTD8v460cnEuuz2YLqplrkW16UFwnb2 lf4asp1U/5HS8HaaqzkIjJ+mIU0t5D5KfIy2WXRHyw5g/0oEMhionfhy2zxbG9V9bZ91 2kqmiRi83XQg9SN2V1/0p1W+tQ8lXqkA5ziE3t8E6TbhkwQ9DBaPBj0qGA/r0UQApKVA /phJZ6KlYjgvu0v8oP4VUwQJ8D6fMXdQ7NO/tPjL0IU1XUfn3QuFPq9YRTOvv3C3fZpj qjODZWSlMRn2Hxc1sA+bzSqI4Z6jP6tBj+fLXHKe3nvMvVNPI8mLg3hXVy/xQ4j5itVG ch5Q== X-Gm-Message-State: AOUpUlHXbGLcNU232k12EjnnjGRwPLWfkWRzGSR7L8sy5bGn7XB8a2WI MDj+RrTId2FRsgF1vAHycDd8/Q== X-Google-Smtp-Source: AA+uWPzviNqbYsLJBhG+ZGW4rh9GxsNnmERuEGeEQM86Bcd9h9wC5yqQAqgnUCxVyBjCRs/5Hc7NLw== X-Received: by 2002:a1c:9d0b:: with SMTP id g11-v6mr1524925wme.78.1533817661045; Thu, 09 Aug 2018 05:27:41 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h17-v6sm5410225wrq.73.2018.08.09.05.27.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Aug 2018 05:27:39 -0700 (PDT) Date: Thu, 9 Aug 2018 13:27:38 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, ZhenYao , Heyi Guo Message-ID: <20180809122738.wsqfwf7aeq3vql5g@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-34-ming.huang@linaro.org> <20180804151432.jc45us7rfyz6bytm@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 33/38] Silicon/Hisilicon/D06: Modify for close slave core clock. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 12:27:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Aug 09, 2018 at 08:15:27PM +0800, Ming wrote: > 在 8/4/2018 11:14 PM, Leif Lindholm 写道: > > On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote: > >> From: ZhenYao > >> > >> When BIOS booting, the power consumption is too high, so need close > >> some clusters clock that don't work to reduce power consumption. > > > > On the one hand: should this not be handled in ARM-TF? > > This can no be handled in TF and should be handled in Sec phase. OK. Well, as long as it's in Sec phase, I guess it doesn't make too much difference. > > What if (during development) we load a bad EDK2 image? > > Sorry, I don't understand really. What happens to the system if the EDK2 image crashes before we get here? Will it overheat and damage the silicon? Or is it purely a power consumption issue to avoid blowing the fuses in the data centre when you power on a whole rack at once? / Leif > >> The implementation of functions is in edk2-non-osi. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: ZhenYao > >> Signed-off-by: Ming Huang > >> Signed-off-by: Heyi Guo > >> --- > >> Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > >> index ec2b9a36e7..cc60e213de 100644 > >> --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > >> +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h > >> @@ -102,5 +102,8 @@ VOID PlatformEventBroadcastConfig(VOID); > >> UINTN GetDjtagRegBase(UINT32 NodeId); > >> VOID LlcCleanInvalidateAsm(VOID); > >> VOID PlatformMdioInit(VOID); > >> +VOID CloseClusterClock(UINTN CpuClusterBase); > > > > The opposite of Enable is Disable. So Could this be DisableClusterClock? > > Yes, this name is better. > > > > >> +VOID EnableClusterClock(UINTN CpuClusterBase); > >> +VOID CloseSktClock (UINT8 Skt); > > > > Disable? > > Also, Socket, not Skt. > > OK, modify it in v2. > > > > > / > > Leif > > > >> > >> #endif > >> -- > >> 2.17.0 > >>