* [PATCH] MdeModulePkg: Remove some comments
@ 2018-08-10 6:30 shenglei
2018-08-10 8:49 ` Zeng, Star
0 siblings, 1 reply; 2+ messages in thread
From: shenglei @ 2018-08-10 6:30 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Eric Dong
Some comments including the redundant functions removed
before have been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 --
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 --
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 2 --
3 files changed, 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
index 217736c1a6..a55a34a3dc 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
@@ -281,8 +281,6 @@ EmmcPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // EmmcPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
EmmcPeimFreeMemBlock (Pool, Block);
diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
index 0c3a424e3b..03b7963716 100644
--- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
+++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
@@ -281,8 +281,6 @@ SdPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // SdPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
SdPeimFreeMemBlock (Pool, Block);
diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
index d334faa0bb..6c0b271e68 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
@@ -281,8 +281,6 @@ UfsPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // UfsPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
UfsPeimFreeMemBlock (Pool, Block);
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MdeModulePkg: Remove some comments
2018-08-10 6:30 [PATCH] MdeModulePkg: Remove some comments shenglei
@ 2018-08-10 8:49 ` Zeng, Star
0 siblings, 0 replies; 2+ messages in thread
From: Zeng, Star @ 2018-08-10 8:49 UTC (permalink / raw)
To: Zhang, Shenglei, edk2-devel@lists.01.org; +Cc: Dong, Eric, Zeng, Star
I suggest merging this patch to thread https://lists.01.org/pipermail/edk2-devel/2018-August/028167.html.
Thanks,
Star
-----Original Message-----
From: Zhang, Shenglei
Sent: Friday, August 10, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH] MdeModulePkg: Remove some comments
Some comments including the redundant functions removed before have been removed.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c | 2 --
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c | 2 --
MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c | 2 --
3 files changed, 6 deletions(-)
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
index 217736c1a6..a55a34a3dc 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHcMem.c
@@ -281,8 +281,6 @@ EmmcPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // EmmcPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
EmmcPeimFreeMemBlock (Pool, Block); diff --git a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
index 0c3a424e3b..03b7963716 100644
--- a/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
+++ b/MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHcMem.c
@@ -281,8 +281,6 @@ SdPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // SdPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
SdPeimFreeMemBlock (Pool, Block);
diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
index d334faa0bb..6c0b271e68 100644
--- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
+++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHcMem.c
@@ -281,8 +281,6 @@ UfsPeimFreeMemPool (
//
// Unlink all the memory blocks from the pool, then free them.
- // UfsPeimUnlinkMemBlock can't be used to unlink and free the
- // first block.
//
for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) {
UfsPeimFreeMemBlock (Pool, Block);
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-10 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-10 6:30 [PATCH] MdeModulePkg: Remove some comments shenglei
2018-08-10 8:49 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox