From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CB9821BADAB3 for ; Tue, 14 Aug 2018 08:26:50 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id y2-v6so12704677wma.1 for ; Tue, 14 Aug 2018 08:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OgRZDKPOYJefX1alMHoVO7lGtRdmFoNJ/8GPVRVmkao=; b=IH29+mQwVLz/1X3yMxfBfaSoHAQpoF0ZIP0UCrkot/zGzKML6a6S5WR89QjBIc0Gg+ u/3/7tHkY0DMujtmQB6PUlAR23fbUovAaB3OCyrB+V0riDWO9/icjrOlyS2aPLl/ViO/ hnjLl/sve8NgqxL2Gsr/uBL/Qmg15a2lHIWmw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OgRZDKPOYJefX1alMHoVO7lGtRdmFoNJ/8GPVRVmkao=; b=KLiPoAk5focQa111R0NoMASDss0ssck5RaMbEOBEOM98Wr+Cc+luaI4rJL95kxTHDV 19zicagIRHv48OfINzOBpiT6NUjkoCly47eeCztEKb1adSMr1zjv0E9pTTWI+TAAyX2x qdG0DBlhcJe5C6k/fjvoY7sINIbildWJdf2zuNtxDyo2GCosPJVN8u0+tz5bTayVQlWi 7v83De/2Kgnp71dLUWSpbwnx8BJQkYTbYptfKm2quHlRNSNBmn/yBSSwOAshZWTJfvoT Ym+xxorlksg5tm+L/JS2fOk9Ip3BWf7iSsDlBCRYOgcwFG4w9ZkA137lJNdt3zYV3pha akJQ== X-Gm-Message-State: AOUpUlFTnXd7OfMLGMaVtv/Cx2SJR8TUiCzQBd2x8AJb1bIdeqjy2cXO WdrXs7rJ1SGvyoDZQlTrinowiQ== X-Google-Smtp-Source: AA+uWPw5E7/3vqKvuZ5EaOvZvHE0+mBblGJRiILIgoA9kZP+BH9es1ifKUPZDb/IDAsySCFisDxhDw== X-Received: by 2002:a1c:b406:: with SMTP id d6-v6mr11264510wmf.126.1534260408752; Tue, 14 Aug 2018 08:26:48 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v6-v6sm8158237wmc.43.2018.08.14.08.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 08:26:47 -0700 (PDT) Date: Tue, 14 Aug 2018 16:26:45 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Heyi Guo Message-ID: <20180814152645.w2675ilc7mjqbu4a@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-8-ming.huang@linaro.org> <20180802173647.paepialtuopbe6y5@bivouac.eciton.net> <22f0c26b-0666-82b5-2b1c-f71af63526a4@linaro.org> <20180808095909.tavnft3vmycftxc7@bivouac.eciton.net> <12d71306-5d19-837c-3827-8be1883b693a@linaro.org> <20180808125306.nllzdcfbnbc57wt7@bivouac.eciton.net> <5b310aff-f2f0-5b89-00fc-a778fe15a1a1@linaro.org> MIME-Version: 1.0 In-Reply-To: <5b310aff-f2f0-5b89-00fc-a778fe15a1a1@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 07/38] Silicon/Hisilicon/D06: Wait for all disk ready X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 15:26:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote: > > Which is exactly what an event is for. > > At the point where the SAS controller driver is currently updating the > > variable, it can instead call SignalEvent (). > > > > The WaitForDiskReady () function can be changed to wait/check for that event. > > As current solution(using variables) have run stable, I prefer don't change > SAS driver and this wait function. Is it OK? You can leave the driver out if you wish, but it cannot go into the 18.08 release with this design. This is why it is important to publish the code as soon as possible - especially for new platform ports. And to publish bits that are possible earlier, rather than wait and do everything in one go once the whole port is done. Best Regards, Leif