From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48DAF21BADAB3 for ; Tue, 14 Aug 2018 08:42:13 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id h10-v6so17601012wre.6 for ; Tue, 14 Aug 2018 08:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JfVFl4/1Psy85/pVx6rPPXDTcUfGgpIa5+x3R2CJqY4=; b=gUbXGPP2XRAg9f4XM+LHcUHxjgUFrzCn0CF7K4fVr5ZpJlDq6MeIXOBzEGUwrJ3Jzp ASYg5C+588YBNYgAA7N977neFFSKHxc4wtbPkXxUDwpwz/nbzvlAQakumnRB4dhhnUEW 103kwnnNJAemnyJosbiMbBOnhXRPhaquVwMEo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JfVFl4/1Psy85/pVx6rPPXDTcUfGgpIa5+x3R2CJqY4=; b=iKVnJ0DeBH5fk7+T1m0VwwUpNFF5bBjsIxZN52E2QCikMSl1rNCY06tiT2m1563L7J g0bdgkuUboosVzi5RqCv1HG6ZEb7e0qny4tMyfc/3FEoY/tmRnnOwyiGaDxc6LmsSjq1 Aa+rVDK83aOGO2DKu5BxBh5CSB27ykip8hmcKfQjkpWa+jhGdjSuJq14N7GEhxH6PqOM A3i2vsEVimIhz/x29Wl+a1da1DeTNvKwomKiNnBpumFLD8t7OLMFPPzf1IZTZ/ZqSYWh gk6kLE9Nwd8K70DOlLzl+M6zeB5nO8Wf8+7M0bYGV2BY4x95keCvMCDMd2hMGgaOik3v my8Q== X-Gm-Message-State: AOUpUlHCBnpHkXOdkNFaFik4MDyYdrlPO8bncb1hBJa7uP25iXu8jCAq 1TsN2na7m4EBV9qu2q+EcBGv7w== X-Google-Smtp-Source: AA+uWPxV16RgqqF0mpmfp+IlKHFW3Lv9ChGmQJyaMtphEsxl+KwdWmYDlrwyfOg6RmaUpqfzOuKubg== X-Received: by 2002:adf:f689:: with SMTP id v9-v6mr13727255wrp.201.1534261331589; Tue, 14 Aug 2018 08:42:11 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 139-v6sm32034956wmp.4.2018.08.14.08.42.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 08:42:10 -0700 (PDT) Date: Tue, 14 Aug 2018 16:42:08 +0100 From: Leif Lindholm To: Ming Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Heyi Guo Message-ID: <20180814154208.vbspczwsq2h3wcsl@bivouac.eciton.net> References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-28-ming.huang@linaro.org> <20180804095934.7dgxsy6ne7squzz7@bivouac.eciton.net> <5989d59b-204a-d220-19bc-2aa83dd1a1bc@linaro.org> <20180809102754.nzvblo5s3lqtmxqz@bivouac.eciton.net> <37acfb11-2df0-73f7-53f5-d2dbc2f9255d@linaro.org> MIME-Version: 1.0 In-Reply-To: <37acfb11-2df0-73f7-53f5-d2dbc2f9255d@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 27/38] Platform/Hisilicon/D06: Add EarlyConfigPeim peim X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 15:42:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 14, 2018 at 10:31:02AM +0800, Ming wrote: > >>> That { goes at the end of the previous line. > >>> > >>>> + StartupAp (); > >>> > >>> Hmm. At some point, we want to rename that function, to align with my > >>> comments above. > >> > > As this function is use in several platforms, if I rename this function, > D03/D05 should be rename in edk2-platforms and many functions in HwPkg > should be rename. > How about use the original name? I would prefer it changed. But it is not required for 18.08. We can discuss after that release. / Leif