From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 342F1210E2A6E for ; Tue, 14 Aug 2018 09:16:12 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id y9-v6so12832003wma.5 for ; Tue, 14 Aug 2018 09:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jV4kAr+vYGtHfJDLelRakMrP0dDAPUAklqsO0gRSum8=; b=DgQ/0in9z/tpuayBgL05E+F1GrerinpjqqPAy6etFr9p6VFiUD3t4JbyNwa4WllVBv TobZSryZk4sP+GeOauJboy9IznsAoi6Z5V1C+AUT+BRqNrQnmZBcdNt21wGF8xvBs4gT u13KSqr8oYNoR9M2kthe6tUFusOsLit5UJ/wY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jV4kAr+vYGtHfJDLelRakMrP0dDAPUAklqsO0gRSum8=; b=snnTD4S8/nAQFtJRoklCI0JTdm1yCQ+UsDNbSXznR7tRIn8pzE38FWqr+24QTKTtVL 4spOsT2W7g9ygd5j/s4AJj/2JjrME4bqadwzrmwK9kgqrzMWhV59ovkJei4JaP1v0kfj LtfMWxF8rQ2Ykq8VbsKdUJzuJTBmHPwXLIifKCAzNe4Ro8D840BD2bNfvX56F9EXuuZc lZEJ5ZV/Ul/f7vuhDoTmbGZjotsrOXWF0EwUuf8BnQ6XjLP7t7orzXQUAX4ZhAMQJd2/ 0Qj+xt7oAemOFPh6sN+f4i24DqPwOUgA2QxKUDxt8coUpsCkZtYjELLo9K95Swht+RfA R7mw== X-Gm-Message-State: AOUpUlFH2pn/NIZ6gm3diWGZ/DdbTgvfHakwEQO6dyVJ9v7dQgCFJorZ TRy8j/k0ryOLZeFPfFlZUttaBWha8SE= X-Google-Smtp-Source: AA+uWPx+MW6cZomg9+0tjz9n/BBUbclAk/2g1Niv+3teSOooybVxR4PVcRJ+Rl6Ag4fHpcEN7ESDMQ== X-Received: by 2002:a1c:7908:: with SMTP id l8-v6mr2536549wme.80.1534263370855; Tue, 14 Aug 2018 09:16:10 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c134-v6sm11543841wme.4.2018.08.14.09.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Aug 2018 09:16:09 -0700 (PDT) Date: Tue, 14 Aug 2018 17:16:07 +0100 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20180814161607.c7eitzf7coj4gcot@bivouac.eciton.net> References: <1533782704-29302-1-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1533782704-29302-1-git-send-email-haojian.zhuang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1 edk-platforms 0/2] Fix missing PL011UartClockLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 16:16:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Haojian, On Thu, Aug 09, 2018 at 10:45:04AM +0800, Haojian Zhuang wrote: > Fix build failure by appending PL011UartClockLib I don't think these patches are required. Commit 1160c702c24f ("Platform: Add PL011UartClockLib resolution to all PL011UartLib users") added this resolution to Silicon/Hisilicon/Hisilicon.dsc.inc, which is included by both these files. Can you confirm please? Best Regards, Leif > Haojian Zhuang (2): > Platform/HiKey960: add PL011UartClockLib > Platform/HiKey: add PL011UartClockLib > > Platform/Hisilicon/HiKey/HiKey.dsc | 1 + > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + > 2 files changed, 2 insertions(+) > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > -- > 2.7.4 >